From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: "Mou Chengshu(Ben)" <muchengshu@gmail.com>, isar-users@googlegroups.com
Cc: "Mou Chengshu(Ben)" <chengshu.mou@siemens.com>
Subject: Re: [PATCH v2] fix: unsupported value of disk format in ovf
Date: Fri, 23 Aug 2024 08:13:48 +0200 [thread overview]
Message-ID: <99c3cca9-b507-40a0-9360-614faece6701@siemens.com> (raw)
In-Reply-To: <20240823022356.160179-1-chengshu.mou@siemens.com>
On 23.08.24 04:23, Mou Chengshu(Ben) wrote:
> fix: unsupported value of disk format in ovf
>
Almost: duplicate subject line.
> Currently, Isar doesn't assign the variable 'VMDK_SUBFORMAT' into ovf template
> that causes generated ovf file contains unsupported disk format value and error
> message will be reported when import it into ESXi.
>
That's perfect!
Jan
> Signed-off-by: Mou Chengshu(Ben) <chengshu.mou@siemens.com>
> ---
> meta/classes/imagetypes_vm.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/imagetypes_vm.bbclass b/meta/classes/imagetypes_vm.bbclass
> index 56410de9..4da42447 100644
> --- a/meta/classes/imagetypes_vm.bbclass
> +++ b/meta/classes/imagetypes_vm.bbclass
> @@ -60,7 +60,7 @@ macgen() {
>
> OVA_VARS = "OVA_NAME OVA_MEMORY OVA_NUMBER_OF_CPU OVA_VRAM \
> OVA_FIRMWARE OVA_ACPI OVA_3D_ACCEL \
> - OVA_SHA_ALG VIRTUAL_MACHINE_IMAGE_FILE"
> + OVA_SHA_ALG VIRTUAL_MACHINE_IMAGE_FILE VMDK_SUBFORMAT"
>
> IMAGE_TEMPLATE_FILES:ova = "${OVF_TEMPLATE_FILE}"
> IMAGE_TEMPLATE_VARS:ova = "${OVA_VARS}"
--
Siemens AG, Technology
Linux Expert Center
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/99c3cca9-b507-40a0-9360-614faece6701%40siemens.com.
next prev parent reply other threads:[~2024-08-23 6:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 7:22 [PATCH 1/1] " 'Chengshu Mou' via isar-users
2024-08-21 5:12 ` Uladzimir Bely
2024-08-21 9:24 ` [PATCH v2] " Mou Chengshu(Ben)
2024-08-21 10:05 ` 'Jan Kiszka' via isar-users
2024-08-23 2:23 ` Mou Chengshu(Ben)
2024-08-23 6:13 ` 'Jan Kiszka' via isar-users [this message]
2024-08-23 7:25 ` Mou Chengshu(Ben)
2024-08-27 16:59 ` Uladzimir Bely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99c3cca9-b507-40a0-9360-614faece6701@siemens.com \
--to=isar-users@googlegroups.com \
--cc=chengshu.mou@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=muchengshu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox