From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6646963333394071552 X-Received: by 2002:a17:906:2352:: with SMTP id m18-v6mr2478031eja.9.1547827188294; Fri, 18 Jan 2019 07:59:48 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:1c0c:: with SMTP id k12-v6ls2430556ejg.1.gmail; Fri, 18 Jan 2019 07:59:47 -0800 (PST) X-Google-Smtp-Source: ALg8bN53QnM4ee7i9TNia5kqyjQpSZQwlE+TU7f5cLR1nPnd/dWh4vvqz6RXzSdOgKJl+HCaaJbR X-Received: by 2002:a17:906:6006:: with SMTP id o6-v6mr2483659ejj.4.1547827187884; Fri, 18 Jan 2019 07:59:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547827187; cv=none; d=google.com; s=arc-20160816; b=kcahSuL/xX34lIR4RrG0nhWgpudz4/8zMdO1YKRKVD05JxtBZsAGSk4y2p53e/DnBX KfHFqhFoB4KudCoIpfm6rsxef8DDbJqDY76BStRNwu+i36VHRqtRGlLrRLl8S6+oZzO5 AuGXEfPpwfINSpElhz+lbuu98dLWDikIow8ywGmOZcVoNcOHtpEKoYO9JTPTwRNwhyna 72MIXb9Al6aTAorzt+6YcLN+aQR49F7yjWTNvADNgvlgFG4yJ1MFRT16fid5t1D4vQ8g pKYEOUGm8n2DWy80pxR91TZtwvhKmYs0041/ot0itwburlJQR8hexOVzsIWuk0ChULLJ 7n4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :dkim-signature; bh=rvKuG6gINrktL03X2wN2yc6Kug1Y4PO3MO5ohppeHe4=; b=Gu4Jb+7YWz4JoFsWK/rb6ops925lZkxwyy3VQh3h9Tq07PAiiv9bZ1YgmqxckkMoBt OHuWtkF29NQQ1wjxA20Z9E/q5J+PgC53WZ9JACxb8HguDaDku05Ablyevdr5ncQbzps9 N0AVAYuQrA4nQFa1t2eUjA0/1/sAxIxCHjcbzhFTLvpbuwimOu8XvDl99lD2NQ4KkFJo 1u+i5+WG2Nk+QqkUm+UE1LtZpxrabZVkghy5PUCg8CAcMMLIoM3K+E6t5MhQV3xKeYDv 0B2W77S/6WjcETKJamBiWARvBD30UiUoqjIctfjM3j7OIWEoXtDUMTF6yAfMGWZC1qap QyYw== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=B1+xdbKT; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.4 as permitted sender) smtp.mailfrom=jan.kiszka@web.de Return-Path: Received: from mout.web.de (mout.web.de. [212.227.15.4]) by gmr-mx.google.com with ESMTPS id gq11-v6si693256ejb.0.2019.01.18.07.59.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 07:59:47 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.4 as permitted sender) client-ip=212.227.15.4; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=B1+xdbKT; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.4 as permitted sender) smtp.mailfrom=jan.kiszka@web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1547827187; bh=vwFSENeXwc9d4yulwqeYArn+RSPVBrebAiU64I0Ulpg=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=B1+xdbKT/iTMIxxrqgolxQMwFqQeyGAZ2d7Td/FAIYhVrzINzIE+TTu/ksMvcTDkF ej6uYiQYw/Wr/9VzwfJFZILJo4jiC+YpGDoUjXYAVB/DGk3ijIDLXmzcRf8tR5CO79 YSPB3ag+PgVA8xEhwmYaTxtuKXaTGJPCNC8oLpcc= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.0.24] ([83.215.108.61]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LqoAk-1hOVw90jzO-00eKep; Fri, 18 Jan 2019 16:59:47 +0100 Subject: Re: [PATCH v4 07/14] Move debian distro conf files to meta To: "Maxim Yu. Osipov" , isar-users@googlegroups.com References: <20190117163638.29167-1-mosipov@ilbers.de> <9cfc77af-2c1a-40f3-a751-a7086cc8947d@web.de> <539a63bf-2cae-4fec-57f8-c03a93a6322b@ilbers.de> From: Jan Kiszka Message-ID: <9a02940a-c6cd-0c6b-8dcd-9ce20add0f63@web.de> Date: Fri, 18 Jan 2019 16:59:46 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <539a63bf-2cae-4fec-57f8-c03a93a6322b@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:j+pS7deYPWAYxSoWeD4jqM69oungF2DGoW+7AIQkjy+JP/PGadv tGBOc0GcSFUKjfBQ4p2fl+A2Lt049hnG9ibQ/sfXRs4FaqOfLr7wYTP/ukQ0T8s5qPExupZ rT3oLwZqS/zMWJZio+ZFk53HGEeKVogfBZwDsXugIYIngM8my/EeVYFYH79/KUyDcogcin5 GSkvBSzRQ/mACwawgzw1Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:JHCo9E1NZjI=:Ce7+i1Tb7BQCV7M7XGcMQ5 dTlwZ7gZYOvY4SlnM4zDMzFF+aFwxTANf7vSTOo0TibGBMcvianvD8XgnVtdP/NF+LpKxMery iR6pleUo28p/qGQ7ktwA7JoovVHdDk4tUR7noXTV4sSZunZu3iMBeUE0KNS2K5d+PMYm4eq+N DRPoKiHdW3rPhCt96wvz16KUezarMUSa2FcNQlPo1den/zH9DIOqdfXhA7g20eCMm7mH2bN8p Ab6mLxxFX04RXGbrLuzQ31okoaAnHoX/WxgKW/O1dRSUnlDH5Tx8Q4cFzqg18MJ9ibNAoK8CH HgW7elk8pTo8i638l3EbAKvQBmqwWmHgMIFWQF2UzMDCIXSdgzLtEaob9WaXnmsC/NXK0krDd WYsG7gROoAFFKKowLQ1qc0/y+0LtodSIqOAamJwkhRQlsGnVdQ4cshKcHfm2Q1j7V8fiBPghp ZKwdvmtqgjAE989K/e5bbb2iQgg01b1epEH60B6qHTf6eT4oJ8okFHrlyTJGNxOo3KbvXXEdg divF/qUBjtnoHjt8+49ynZEvWS3c6K58rDCHucHZndDFRZb7oGUsxPSXNnO44uyoBT4gnmbY6 qEuVProq/PnrOL3/IHoQiYjMFLkW8D9WxHM+lFmhN6h1kaptLQ8foYjZd0MSq/EIdhNw1R/bE HfjJA8Cu4pe+O2AA3HN/n9V2bzev3g4JyMHQJAk0HmSStp16V1Dd+FnFIfxDTnmt59gOiwI8o Z4NBOLKR/FOG6fnsk3N89Milunwng+jPl1YnHEJI+RtXiEq7u7y2ipOTbmh82FjRpLM4bJ7cd I8yAWvFDz49mDiTQcDr1dypzVgYye7Qr0JylI1JiNKq8fVpuZUOQH1Bv2RS2HNKVvHvR5qcHK 2SVUAmXe5LEzkgvJvS+g8SVjowW9HPKikyCImLqnqeTb1xeBwKpnrKJ4kqmEGPL3UIA16YvUY woukb98s8zg== X-TUID: 5AMunYgjE6mR On 18.01.19 16:43, Maxim Yu. Osipov wrote: > On 1/18/19 4:27 PM, Jan Kiszka wrote: >> On 17.01.19 17:36, Maxim Yu. Osipov wrote: >>> From: Jan Kiszka >>> >>> This only keeps specialties and examples in meta-isar, allowing to bas= e >>> normal Debian layers solely on meta. >>> >>> Signed-off-by: Jan Kiszka >>> Signed-off-by: Maxim Yu. Osipov >>> --- >>> =C2=A0 meta-isar/conf/distro/raspbian-jessie.conf=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 2 +- >>> =C2=A0 meta/classes/isar-image.bbclass=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 3 ++- >>> =C2=A0 {meta-isar =3D> meta}/conf/distro/debian-buster.conf=C2=A0=C2= =A0=C2=A0=C2=A0 | 0 >>> =C2=A0 {meta-isar =3D> meta}/conf/distro/debian-buster.list=C2=A0=C2= =A0=C2=A0=C2=A0 | 0 >>> =C2=A0 {meta-isar =3D> meta}/conf/distro/debian-common.conf=C2=A0=C2= =A0=C2=A0=C2=A0 | 0 >>> =C2=A0 {meta-isar =3D> meta}/conf/distro/debian-configscript.sh | 0 >>> =C2=A0 {meta-isar =3D> meta}/conf/distro/debian-jessie.conf=C2=A0=C2= =A0=C2=A0=C2=A0 | 0 >>> =C2=A0 {meta-isar =3D> meta}/conf/distro/debian-jessie.list=C2=A0=C2= =A0=C2=A0=C2=A0 | 0 >>> =C2=A0 {meta-isar =3D> meta}/conf/distro/debian-stretch.conf=C2=A0=C2= =A0=C2=A0 | 0 >>> =C2=A0 {meta-isar =3D> meta}/conf/distro/debian-stretch.list=C2=A0=C2= =A0=C2=A0 | 0 >>> =C2=A0 10 files changed, 3 insertions(+), 2 deletions(-) >>> =C2=A0 rename {meta-isar =3D> meta}/conf/distro/debian-buster.conf (10= 0%) >>> =C2=A0 rename {meta-isar =3D> meta}/conf/distro/debian-buster.list (10= 0%) >>> =C2=A0 rename {meta-isar =3D> meta}/conf/distro/debian-common.conf (10= 0%) >>> =C2=A0 rename {meta-isar =3D> meta}/conf/distro/debian-configscript.sh= (100%) >>> =C2=A0 rename {meta-isar =3D> meta}/conf/distro/debian-jessie.conf (10= 0%) >>> =C2=A0 rename {meta-isar =3D> meta}/conf/distro/debian-jessie.list (10= 0%) >>> =C2=A0 rename {meta-isar =3D> meta}/conf/distro/debian-stretch.conf (1= 00%) >>> =C2=A0 rename {meta-isar =3D> meta}/conf/distro/debian-stretch.list (1= 00%) >>> >>> diff --git a/meta-isar/conf/distro/raspbian-jessie.conf >>> b/meta-isar/conf/distro/raspbian-jessie.conf >>> index de8b5a1..4ebf523 100644 >>> --- a/meta-isar/conf/distro/raspbian-jessie.conf >>> +++ b/meta-isar/conf/distro/raspbian-jessie.conf >>> @@ -8,5 +8,5 @@ BASE_DISTRO_CODENAME =3D "jessie" >>> >>> =C2=A0 DISTRO_APT_SOURCES +=3D "conf/distro/raspbian-jessie.list" >>> =C2=A0 DISTRO_APT_KEYS +=3D >>> "https://archive.raspbian.org/raspbian.public.key;sha256sum=3Dca59cd4f= 2bcbc3a1d41ba6815a02a8dc5c175467a59bd87edeac458f4a5345de" >>> >>> -DISTRO_CONFIG_SCRIPT?=3D "raspbian-configscript.sh" >>> +DISTRO_CONFIG_SCRIPT ?=3D "raspbian-configscript.sh" >>> =C2=A0 DISTRO_KERNELS ?=3D "rpi rpi2 rpi-rpfv rpi2-rpfv" >>> diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image= .bbclass >>> index 754e896..3f65b7a 100644 >>> --- a/meta/classes/isar-image.bbclass >>> +++ b/meta/classes/isar-image.bbclass >>> @@ -7,6 +7,7 @@ inherit image >>> =C2=A0 inherit isar-bootstrap-helper >>> >>> =C2=A0 FILESPATH =3D. "${LAYERDIR_isar}/conf/distro:" >> >> This line must go, or we have layer violation bug: no references from t= he core >> to meta-isar. Keep in mind that other layers than meta-isar may want to= provide >> a difference distro as well and should be able to do so without this ha= ck. > > I didn't want to drop the patch from the queue, so I provided a quick fi= x. > I/(you?) will have a look for better solution. > >> I thought I tested the raspi case - isn't it part of the fast CI test? > > No...it's a part of the long one. Right, I thought I ran "bitbake multiconfig:rpi-jessie:isar-image-base" separately but probably not until the very end (where the error occurs). J= ust reproduced. My patch seem to have revealed a sleeping issue in isar_image_conf_rootfs: diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbc= lass index cf68947..41266d7 100644 =2D-- a/meta/classes/isar-image.bbclass +++ b/meta/classes/isar-image.bbclass @@ -47,7 +47,7 @@ isar_image_conf_rootfs() { sudo install -m 755 "${WORKDIR}/${DISTRO_CONFIG_SCRIPT}" "${IMAGE= _ROOTFS}" sudo chroot ${IMAGE_ROOTFS} /${DISTRO_CONFIG_SCRIPT} "${MACHINE_S= ERIAL}" \ "${BAUDRATE_= TTY}" - sudo rm "${IMAGE_ROOTFS}/${DISTRO_CONFIG_SCRIPT}" + sudo rm "${IMAGE_ROOTFS}/$(basename ${DISTRO_CONFIG_SCRIPT})" fi } Jan