From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7039983387261534208 X-Received: by 2002:ac2:5388:: with SMTP id g8mr2351103lfh.64.1639739086763; Fri, 17 Dec 2021 03:04:46 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9b53:: with SMTP id o19ls34148ljj.2.gmail; Fri, 17 Dec 2021 03:04:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJwqlMdX4P9w0bJ0hnouNd4JemgpimMlSss5oJvMpSaw9l7Qrda7MrkjJyAPGPkyDNmmE6gi X-Received: by 2002:a05:651c:b2b:: with SMTP id b43mr2424780ljr.0.1639739085717; Fri, 17 Dec 2021 03:04:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1639739085; cv=none; d=google.com; s=arc-20160816; b=mSATzA8TqtLQbrKhDZ70mlIUjR7Z74k5krvdRp1ldDPTVRhrVqCg1uOSF6NFmCxmS/ gycXGnm1x3DP1hYAzKXmtvCtdzQ3ga5/jtwOKidDmyKqvq8FkCDbZjTltPaSaE4+esdc FAk7MQeq/FZqxsC9Y5wqOdHQI5LZLQ9O9HfaX2hK4xRprDBZBDuM0MdYp7X+HveYOm7b /bOu8PfebqQcNfciHnf9se+MVxJbE+gABb+fFIwS9597XuRuC4WMeH9tnhcKX13EdTpa EMge0XK4uZpmA09h3kB83LHk8oWBLJwWyGTHQcxHgXvwfFgKDmAUz/rBmgBiaClfRDtF o9Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=bbHi4geOftn0vJAEl4KKc2NXOXOq5kyZ5ZCQ/0dqYtE=; b=lRrDtyxNFOrvcE5Ux/u2eg2+xzQxLhByApTnDQ7ekv5uGCfE2R0eUSDqzBVH94Z/Kx 6OSkk+DWpLvrDyNs+PQRbfVvxY1BXsG/K5VrQhM/ik5NV4IXaQQ7SqGQAIJHD68l7fjD nTQ1uc6jQ5MX1hQOY+aQHakUGpyaie3WjT2WmuwHxSEl3p8uK4ZUkJQmWL1YfzN0NsV6 npvyPYcVrLs32+P7VNiXwrQrOy0LFutWn4c8w33ylWBKScmCNoTg3EH8hjwGj+io2VjU miRmfKV2zo5aTnfNCm1SA0XMR3Gx5jW3RJgDYHc7eYQV+hEXg/5l0Fzxyb17DdvPYX1f TEuQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id e15si519996ljg.0.2021.12.17.03.04.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Dec 2021 03:04:45 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [192.168.67.164] (mm-214-81-214-37.mgts.dynamic.pppoe.byfly.by [37.214.81.214] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 1BHB4ijR017881 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 17 Dec 2021 12:04:44 +0100 Subject: Re: [PATCH 0/2] Fail on the first error inside sudo To: isar-users References: <20211210081054.225747-1-amikan@ilbers.de> From: Anton Mikanovich Message-ID: <9a5eb38a-aa6a-9be2-1703-a09fb6abfed9@ilbers.de> Date: Fri, 17 Dec 2021 14:04:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211210081054.225747-1-amikan@ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: F4QZwABSY0uC 10.12.2021 11:10, Anton Mikanovich wrote: > There in no need in further execution if any command failed. But inside > the sudo sections (also with chroot) we didn't have 'set -e' declared. > It leads to incorrect execution of the next code in case of failures. > So adding 'set -e' to exit immediately. > > Also fix rmdir which was failed (but masked) on execution if there were > no base-apt used. > > Anton Mikanovich (2): > rootfs: Execute rmdir only if needed > sudo: Fail on the first error > > meta/classes/deb-dl-dir.bbclass | 2 ++ > meta/classes/image-locales-extension.bbclass | 1 + > meta/classes/image.bbclass | 9 +++++---- > meta/classes/rootfs.bbclass | 2 ++ > meta/classes/vm-img.bbclass | 1 + > meta/classes/wic-img.bbclass | 1 + > meta/recipes-devtools/buildchroot/buildchroot.inc | 1 + > 7 files changed, 13 insertions(+), 4 deletions(-) > Applied to next. -- Anton Mikanovich Promwad Ltd. External service provider of ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn, Germany +49 (89) 122 67 24-0 Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov