From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247987705053184 X-Received: by 10.129.84.135 with SMTP id i129mr3395013ywb.71.1502218748884; Tue, 08 Aug 2017 11:59:08 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.36.9.209 with SMTP id 200ls2314253itm.15.gmail; Tue, 08 Aug 2017 11:59:08 -0700 (PDT) X-Received: by 10.129.78.15 with SMTP id c15mr3480863ywb.204.1502218748638; Tue, 08 Aug 2017 11:59:08 -0700 (PDT) Received: by 10.55.154.147 with SMTP id c141msqke; Tue, 8 Aug 2017 06:47:35 -0700 (PDT) X-Received: by 10.25.18.205 with SMTP id 74mr474713lfs.35.1502200054880; Tue, 08 Aug 2017 06:47:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502200054; cv=none; d=google.com; s=arc-20160816; b=risXxAcsINRx97p/k3ivYBdgDg6q6SkBv/PkkOUjYXEzoMdbP8CDfRdOuwu1bHUUo9 gfbgtBNJHeFlnGHs26mpQEEc5YGeVg/mf8ZJFse2Fo/CSqVmLMZP4WW+VN1X8Ws1iHwy vqavBG5oAWXkvJ0yannBcN+hlBgF/XJoT1DQIOhp6Dqq4j3IKeeraE07XH5fiLcNAI2/ y3XnTrGv8sCzZWtWNHjFU0oRQ9Uj2uDg+DCAzw+yQ/JO8UhSCALRJsmHKBBfsySMXV3N d6iTbDBsVR/UoKKZcmKAWjiNx3psITYd53rvjk8WZpPCt/n572VQmwlapuC3NtLUC5XU hGcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=jmVzbFNahYtNue5FasG+YGeB+ssNON34Hcx0AAko8r0=; b=rK+XHV7pzAThd6GJiITbRjf4m0OP7DHYmOeMXV6RMHugZCdmFcKfKbbsf2/uR63g7c I5jHX2OlJ1UEBTcXlanj2kqekH4VgWmwgB/wLoyMnviGLtPGrDRdV8RODIL6X4p0sGod OYtrDDV5eqMaIQOGOrV2tVHjHnZPG6tYeEkRBxcmRtCyIwBP4strf4vFh6FUG17GhbeV Yke02aDrSu5yOc3GX3ztFCg+eIjXZOFCMz6kN/wbQ34WJJrq2Tz6FJRHWp1ntXszY6D5 q0yNW+sqoZZCu90hTLynQTaGKYqCJ+NaWWiCtG1jKqM9GPXcVwdk004VOoi8SQw8qZ0i TYsQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id 81si507749wmh.1.2017.08.08.06.47.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 06:47:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id v78DlVM9023260 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 8 Aug 2017 15:47:33 +0200 Subject: Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function To: Henning Schild Cc: isar-users@googlegroups.com References: <369a52a90daaf90bbf7ebcc8831589b7085fcfa3.1501760818.git.henning.schild@siemens.com> <20170808100527.097c4ab1@md1em3qc> <20170808140809.1636322c@md1em3qc> <55765622-5df2-3353-2326-7f3d66a0e57e@ilbers.de> <20170808151247.40b2f573@md1em3qc> From: Alexander Smirnov Message-ID: <9a926579-707a-aca9-43e3-9b550a4e88a2@ilbers.de> Date: Tue, 8 Aug 2017 16:47:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170808151247.40b2f573@md1em3qc> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 7ujKlNEzRfWn On 08/08/2017 04:12 PM, Henning Schild wrote: > Am Tue, 8 Aug 2017 15:29:35 +0300 > schrieb Alexander Smirnov : > >> Hi, >> >> On 08/08/2017 03:08 PM, Henning Schild wrote: >>> Am Tue, 8 Aug 2017 12:33:58 +0300 >>> schrieb Alexander Smirnov : >>> >>>> 2017-08-08 11:05 GMT+03:00 Henning Schild >>>> : >>>> >>>>> Am Mon, 7 Aug 2017 22:36:18 +0300 >>>>> schrieb Alexander Smirnov : >>>>> >>>>>> I'm not sure that this function is unused. It's usually used for >>>>>> debug purposes to route traces to console. >>>>> >>>>> It is unused in Isar and not part of the default base class of >>>>> bitbake. >>>>>> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html >>>>>> chapter: 2.3.8.2 >>>>> >>>>> OE implements it in meta/classes/logging.bbclass >>>>> >>>>> >>>> That's a good hint! So probably we can move this function to >>>> similar class instead of removing it. >>> >>> I would still remove it since it is not used. When people need it >>> they can introduce it again. For logging we have bbnote bbwarn and >>> bbfatal from base.bbclass already. Ahh, I suppose I got it now, I thought that bbdebug was a part of default base.class, that why I insisted on keeping it. But now I see that default class doesn't contain this blob. Ok, agreed. Alex >>> >>> Our bitbake does not seem to know "debug_level" so it is outdated >>> and unused. >> >> I'll send patch which introduces logging class and move all the >> 'bbXXX' helpers to it (also fix bbdebug). > > Please do not touch base.bbclass! Or come up with one that is really > different from the bitbake default one for a good reason. > >> I really don't like the idea to drop debug capabilities only because >> they are not used at the moment. If this interface is going to be >> dropped, then we need to introduce new interface before. > > Like Isar was used by anyone or this was anything like a tiny > broken print function.... without users or a release who cares about > interfaces? But keep it like the bugs in ext4! > > Can we please start dicsussing the real patches? > > Henning > >> Alex >> >>> >>>> >>>>>> I think it makes sense to keep it to debug complicated classes >>>>>> and recipes in future. >>>>> >>>>> Ok. >>>>> >>>>> Henning >>>>> >>>>>> 2017-08-03 14:55 GMT+03:00 Henning Schild >>>>>> : >>>>>> >>>>>>> Signed-off-by: Henning Schild >>>>>>> --- >>>>>>> meta/classes/isar-base.bbclass | 12 ------------ >>>>>>> 1 file changed, 12 deletions(-) >>>>>>> >>>>>>> diff --git a/meta/classes/isar-base.bbclass >>>>>>> b/meta/classes/isar-base. bbclass >>>>>>> index 67d38a1..efd4223 100644 >>>>>>> --- a/meta/classes/isar-base.bbclass >>>>>>> +++ b/meta/classes/isar-base.bbclass >>>>>>> @@ -21,16 +21,4 @@ >>>>>>> >>>>>>> THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}" >>>>>>> >>>>>>> -bbdebug() { >>>>>>> - test $# -ge 2 || { >>>>>>> - echo "Usage: bbdebug level \"message\"" >>>>>>> - exit 1 >>>>>>> - } >>>>>>> - >>>>>>> - test ${@bb.msg.debug_level['default']} -ge $1 && { >>>>>>> - shift >>>>>>> - echo "DEBUG:" $* >>>>>>> - } >>>>>>> -} >>>>>>> - >>>>>>> do_build[nostamp] = "0" >>>>>>> -- >>>>>>> 2.13.0 >>>>>>> >>>>>>> >>>>> >>>>> >>> >> > -- With best regards, Alexander Smirnov ilbers GmbH Baierbrunner Str. 28c D-81379 Munich +49 (89) 122 67 24-0 http://ilbers.de/ Commercial register Munich, HRB 214197 General manager: Baurzhan Ismagulov