Re: [PATCH v4 1/3] isar-bootstrap|configscript: implement one shot config option

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi Maxim,

On 2018-05-29 13:18, Maxim Yu. Osipov wrote:
> On 05/29/2018 12:56 PM, Claudius Heine wrote:
>> On 2018-05-29 10:20, [ext] Claudius Heine wrote:
>>>>>   # SPDX-License-Identifier: MIT
>>>>> +IMAGE_CFG_PACKAGE ??= ""
>>>>
>>>> Are you going to rename this variable to IMAGE_CFG_PACKAGES
>>>> and add a comment it in a separate patch?
>>>
>>> Oh, sorry. Forgot about that. I will prepare v5.
>>
>> I have thought on this and I think that 'IMAGE_CFG_PACKAGES' is a bad 
>> variable name, since it implies to be the variable to put all 
>> configuration packages into.
>> How about 'IMAGE_ONESHOT_PACKAGES', 'IMAGE_VOLATILE_PACKAGES' or 
>> 'IMAGE_TEMPORARY_PACKAGES'?
> 
> The purpose of these packages is to do image post configuration (or 
> tweaking)...
> May be IMAGE_POSTCONFIG_PACKAGES or IMAGE_TWEAK_PACKAGES?

Thanks for your suggestions!
I started with `IMAGE_TRANSIENT_PACKAGES` and quite like that.

My problem with names like `IMAGE_CFG_PACKAGES` or your suggestions is 
that it explains what kind of packages might make sense to be put there 
instead of how those packages are handled.

This variable is not the right one for all configuration packages, since 
a configuration package might deploy a configuration file not in a 
package script, but part of the package files. Then this file would be 
removed from the image it that package was added to this variable.

So instead I try to explain what will happen to those packages. "one 
shot" doesn't explain it good enough, while 'volatile' and 'temporary' 
might be misunderstood. 'Transient' however explains quite well IMO.

regards,
Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de