From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6558749580291211264 X-Received: by 2002:a19:915e:: with SMTP id y30-v6mr385571lfj.7.1527593916339; Tue, 29 May 2018 04:38:36 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:5511:: with SMTP id n17-v6ls1409468lfe.6.gmail; Tue, 29 May 2018 04:38:36 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIQAhN1xa1EMa7t0hlRymhCLesquLTUK7MLf8RWSynGZ37iGtLVBRqq1cGjhW3ndqa39Bbk X-Received: by 2002:a19:a414:: with SMTP id q20-v6mr759376lfc.42.1527593915699; Tue, 29 May 2018 04:38:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527593915; cv=none; d=google.com; s=arc-20160816; b=Bha1e9BpbSYOAkdZnZA3o1MByh4JmYr41J+q8adayf/LyFphSxPa8GdLYkPbEnN1L8 6azBYqSbgggnVoZm7rmMM7HUVLi1zhcAFxs3F1DXpz8/IQnFNqZWhNbZ2A1Tl1QkXnwI TpxypA1lFTcrfBBOWiUGQ9HR8uiCCN/HE+qkLijl1YN9c61SOZk4JvbQzqf2y47qx8MX BSN93XoJqlAgQRUcuqKdwyhtkR0oRZJM+zZQ0he2i3HQX4Kz9eBKrNO9oWJmHLAM/mVb 0fILHoxaRLRhoovBD39xJ2mPWYVrOHUtCkDNVQb//CEK9/ejSSq0QBKayGbaDt0izCF+ rCcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=wQ51rZIKpJckHmy52cB9p176stoWWFg51IlHrzg0DlY=; b=VTjX+Ebs4fM1UNm1Db7jqf/E7AhC4VNZ1Zfs0iN5JFzu2g0Liw8xyAB+EAjMyfbV/F KZtyd0hJkURCb7c/een8LchQQ2iYknjrrC/cnQaRnpPlB/LM9moIBNO9p0arGEKA7Td3 QVKwglmIR+LpKIJj332tVdnyb7XrILt3Thvz+dnRwc4m2d3Z3m748wNSiWjNidqBa8N/ YKUTEPPdJWjp0vdJBojiZGwBeIx1R96TrB3KGIYlFYFkIXwQz3WKHdJdYUYaMjRNqEVd Ix0cB6pP2mQdqkalDcaBymS+JQP09mxF0SDxpAu0bdKcoxmXTI8VuERjp91dIFY4w15u 1t+Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id v13-v6si1309109lji.0.2018.05.29.04.38.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 May 2018 04:38:35 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id w4TBcXfd006308 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 May 2018 13:38:34 +0200 Received: from [139.25.69.69] (linux-ses-ext02.ppmd.siemens.net [139.25.69.69]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id w4TBcXFR016163; Tue, 29 May 2018 13:38:33 +0200 Subject: Re: [PATCH v4 1/3] isar-bootstrap|configscript: implement one shot config option To: "Maxim Yu. Osipov" Cc: isar-users@googlegroups.com, Claudius Heine References: <20180528105643.23518-1-claudius.heine.ext@siemens.com> <20180528105643.23518-2-claudius.heine.ext@siemens.com> <6193ea08-16c2-b1be-c0d5-f571ff99d9db@ilbers.de> <781ae027-0ca9-1aac-7099-651134a92714@siemens.com> From: Claudius Heine Message-ID: <9acd5170-66e0-2a65-54df-1ad27c8f5159@siemens.com> Date: Tue, 29 May 2018 13:38:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: DEprHXH1pgAG Hi Maxim, On 2018-05-29 13:18, Maxim Yu. Osipov wrote: > On 05/29/2018 12:56 PM, Claudius Heine wrote: >> On 2018-05-29 10:20, [ext] Claudius Heine wrote: >>>>>   # SPDX-License-Identifier: MIT >>>>> +IMAGE_CFG_PACKAGE ??= "" >>>> >>>> Are you going to rename this variable to IMAGE_CFG_PACKAGES >>>> and add a comment it in a separate patch? >>> >>> Oh, sorry. Forgot about that. I will prepare v5. >> >> I have thought on this and I think that 'IMAGE_CFG_PACKAGES' is a bad >> variable name, since it implies to be the variable to put all >> configuration packages into. >> How about 'IMAGE_ONESHOT_PACKAGES', 'IMAGE_VOLATILE_PACKAGES' or >> 'IMAGE_TEMPORARY_PACKAGES'? > > The purpose of these packages is to do image post configuration (or > tweaking)... > May be IMAGE_POSTCONFIG_PACKAGES or IMAGE_TWEAK_PACKAGES? Thanks for your suggestions! I started with `IMAGE_TRANSIENT_PACKAGES` and quite like that. My problem with names like `IMAGE_CFG_PACKAGES` or your suggestions is that it explains what kind of packages might make sense to be put there instead of how those packages are handled. This variable is not the right one for all configuration packages, since a configuration package might deploy a configuration file not in a package script, but part of the package files. Then this file would be removed from the image it that package was added to this variable. So instead I try to explain what will happen to those packages. "one shot" doesn't explain it good enough, while 'volatile' and 'temporary' might be misunderstood. 'Transient' however explains quite well IMO. regards, Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de