From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Tue, 11 Nov 2025 14:58:25 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-lj1-f189.google.com (mail-lj1-f189.google.com [209.85.208.189]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 5ABDwNoh025211 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 11 Nov 2025 14:58:24 +0100 Received: by mail-lj1-f189.google.com with SMTP id 38308e7fff4ca-37a3c96acf8sf5557701fa.0 for ; Tue, 11 Nov 2025 05:58:23 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1762869498; cv=pass; d=google.com; s=arc-20240605; b=POEbJwbLbIAHpGiI361DK7G1c60Q9Kwn0Ue2NR4qQEfsDLEhOCNfAqNAg6FonE8r2h VdWU0iEaJGlPasnyb2+z1OGos8AsUVGLAVxzy12DlKmpkvksbdZ8bQtkAOUtwxKPNJSl EOW2Gw5BaRzvTFYXTMrLYTo8/aSUf93AsDeWdij6C2ohtzDSR9xYxyClCdHQgRBjQPNz py4z87y/c5lntEXuLFU5lYrfbxJHl/Euo4S6+OV+rliB6EJgFjCTgKx840MfGDFWxQOJ fgtgECYeboN8k9bfzwykREjpPGdv7eGTdmPxYPg/UYIlMPPgxcXfXwOv0kXALPh8Te03 WeHQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:content-transfer-encoding :in-reply-to:content-language:references:cc:to:subject:from :user-agent:mime-version:date:message-id:sender:dkim-signature; bh=m0JEmG8n8ntbkoZUQpZCW1q2rLBJlEzzSho9MNWgHAk=; fh=0tKTv0bFujBDY1aao27xGiF75C/m5cJSU6u1mZQ7G1c=; b=XJokOBHN8YHLEjhoPzoNmpI9M0eYnr216i0WTqCXcDSCgSnrQLDpbeadquPVCPdolW CMDaZRLYxfImrLhhZAOjKIIVH7kWW1xtwfJOU1nSKoOlDBcjdOCa6K3CbrbFAVIBvK77 8UJUaHx6inPCy/u/DYCJgSiR/hruGwr8hVVj4VwLFJV7yGuicMPQfk2e/RJx3Oy4WcQi L/X0iA3kOn8v5oKUTwEr5U+ikwTvzSF7qVVfTGk/S+w9Q+LtS0qrKbqkVNMG5fUvd8oU Qo9Gqivqy4n7pJW6GMZnO3Y2YIayiqSK8G4CJ/tAfgiV6xsEEyVLQSO6VTZOiJC3Pi9P b9Rw==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1762869498; x=1763474298; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:content-transfer-encoding:in-reply-to :content-language:references:cc:to:subject:from:user-agent :mime-version:date:message-id:sender:from:to:cc:subject:date :message-id:reply-to; bh=m0JEmG8n8ntbkoZUQpZCW1q2rLBJlEzzSho9MNWgHAk=; b=O41rqx+/R8qLJe8x0mcqWgDDzegUy4avESCRkskArqB4Pqvo7TAGqcKMC2DRtJFIii 44K5Tqkuzm4NLhOhyryz73t+3Xjdl5QgKXUuhpsVkbpKtDU7RfI5Isn2mS6omPcUFCCY 6v9VC5gsZOTTMDnyoIsZCkfwb1/qCY74Eu2kR/j0dWpach/jjhIOtsOw6W+C5PYxy7hv EnGC2eVj6yXiZPmQQWOjFMzJJc+pcO3jW7TwknxQhyYUol/FjFO5zFaQI9V83xYEs5dC U+AIcgXm6WH995l2z9gtFR6oPLXj7Ljrnvi2OrF9ZWTfrWIhUbeOIezEDsgSOncfF/0u XcXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762869498; x=1763474298; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-beenthere:x-gm-message-state:sender:from:to:cc:subject:date :message-id:reply-to; bh=m0JEmG8n8ntbkoZUQpZCW1q2rLBJlEzzSho9MNWgHAk=; b=OZb+eJf+PGXMY4w3KkH2N8GX1lVqayKjXBLSHZOzRqQiEWF8EMAnKL1VYTzYwh5trD 1/UdUl9+ij/KX9QC6wtAAfu9pVqjUf9jZPvwdzz7XerwLj8lJnKyboNjSEyreqxOqLD+ dOcMygVNgA1m7KMFNXLPlimD5MP0mmlcKRJY66EaCpsznK8TaMr0nOp9RSTPSb8rNA4Z KjH4RV77bWFHoYWO78abM6LlM4Z+99R+TuexiQFISqp+pbCzPw7BVUTSOvCgxWMhyT4O BVVLB/EtoLfd4uh2C4FJb/QkQVMF66O+TsSht6hh4EQo9jf9t4McIS7jUz6zYxFly9sP d/yw== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCWOaU0sS0YngbXpDa15XNfddS5gsrN0NeVM/jQyVWbskTT8d+JXyLqoLWJkMe9BAdSQk27K@ilbers.de X-Gm-Message-State: AOJu0YyfirLKYKVXDK+DUs2FRec0d0QQZaZliMiXSAD1AijM8U+pwsAP mfipUNoRxDtTlJ6CxWnMKCPkzuFFVlEwL58Bu7EF1e8cW/O9/CLQQ7Eb X-Google-Smtp-Source: AGHT+IFMpITEXJ7rBfQR/e26jDAqd5I6kYBQLtQ2r3fgecqG4S6gUjFrwu2etoJ1eTY7zvKmvcUzTw== X-Received: by 2002:a05:651c:19a5:b0:37a:415a:1fb0 with SMTP id 38308e7fff4ca-37a9532c872mr10085701fa.19.1762869497710; Tue, 11 Nov 2025 05:58:17 -0800 (PST) X-BeenThere: isar-users@googlegroups.com; h="Ae8XA+YZKT/56b9tcl1XePfd8i0p7pnsZgaH037Q2gMKIiOMaw==" Received: by 2002:a05:651c:4409:10b0:376:38d9:bdd3 with SMTP id 38308e7fff4ca-37a5de0feefls3358421fa.0.-pod-prod-00-eu; Tue, 11 Nov 2025 05:58:14 -0800 (PST) X-Received: by 2002:a05:651c:20db:10b0:37a:3ab8:66a1 with SMTP id 38308e7fff4ca-37a9532a487mr7324141fa.9.1762869494395; Tue, 11 Nov 2025 05:58:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1762869494; cv=none; d=google.com; s=arc-20240605; b=HbFKyXQVcuTMrmoKvcT9WFSn/YhcV9XdHgOkdNCnKCH9q0x/j7hnvnU+DkwHe3gtKu rp+cgI2MhaIuDANJ1E1xGFRtJ8154vpufN5E3on73d19gDEn2ysPREJKFv9+Vu0BdpH7 TG4RevTAxjzBlJKanDH4gcUA9heq2A1iI6ebrz9pFjeY/G8knMg3mFuvraUi4tKGmpMW A3oeMLN2xCZRSEW32kk4AMTDVRaquHifo5R3Dij23r1COw9MpbhldsPh3+LK8n/DIR0M j5TIiTFGLIVBGAPb6RIbSVoCZJ9QZv5v0MeSlejMfs3vsyhu9mytBto0et81CS5YbA5z wBJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id; bh=/d4VqI3fP61R/FjWS8JN3YXctJQs8glTMh5rRPUZAdY=; fh=aknz0lT/RafW5pvqDEonImgS9GVFcECmI7XqObWFCV8=; b=b8ZRzXxmwsDGxnTWehrumppJCPZYUN2E5OS53h9rcDTdo2xSY0SqlrHIqPWu7ihYTZ XarxsketmIkPdnTiDSAZeRxHtbD/S1wUrACX9xIHFqezTQadK0Xvz+akPD7DYrrzuHKc KfhDGXkzD+g0aHf0VxtnQWXW/B61wCgMWo5d8IiPMAm4AntyED/ruGO6DCWjyq5mEGvq IaNNqVZV3zR2+imlLdcmBmoe0qb+a2nTNzSIPwA9uvt1dzXHo5n7K9NoErF9IkUuYcTI 1lGLKgcHi6Vtn1mze/fI4i9IcaLXouLz7vE0Jlyj7Mo/rR5LiOtYpeIRJphzGXoEYwcC f++g==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 38308e7fff4ca-37a5f0ff762si1427841fa.6.2025.11.11.05.58.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Nov 2025 05:58:14 -0800 (PST) Received-SPF: pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [192.168.178.117] ([88.130.203.42]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 5ABDwCNE025206 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Nov 2025 14:58:13 +0100 Message-ID: <9b0a6eb6-efaa-4656-b5a6-95b83e0af247@ilbers.de> Date: Tue, 11 Nov 2025 14:58:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Zhihang Wei Subject: Re: [PATCH 2/4] CI: add smoke-tests for switch to dracut in isar-image-ci To: "cedric.hombourger@siemens.com" Cc: "isar-users@googlegroups.com" References: <20251101111326.600581-1-cedric.hombourger@siemens.com> <20251101111326.600581-3-cedric.hombourger@siemens.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: wzh@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: teyPcUQEm0Lm On 11/7/25 14:42, cedric.hombourger@siemens.com wrote: > On Fri, 2025-11-07 at 14:09 +0100, Zhihang Wei wrote: >> On 11/1/25 12:13, 'Cedric Hombourger' via isar-users wrote: >>> Use IMAGE_PREINSTALL to install dracut in the isar-image-ci >>> image and verify that it builds and boots. We also check that >>> a dracut-shutdown service is active (as an indication that >>> the system was booted using a dracut initrd). A single test >>> is provided as well as cross-{machine,distro} tests. >>> >>> Signed-off-by: Cedric Hombourger >>> --- >>> =C2=A0 testsuite/citest.py | 58 >>> +++++++++++++++++++++++++++++++++++++++++++++ >>> =C2=A0 1 file changed, 58 insertions(+) >>> >>> diff --git a/testsuite/citest.py b/testsuite/citest.py >>> index a1214e9c..23900a6c 100755 >>> --- a/testsuite/citest.py >>> +++ b/testsuite/citest.py >>> @@ -278,6 +278,64 @@ class KernelTests(CIBaseTest): >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 self.perform_bu= ild_test(targets, image_install=3D' >>> '.join(modules), lines=3Dlines) >>> =20 >>> =20 >>> +class InitRdBaseTest(CIBaseTest): >>> +=C2=A0=C2=A0=C2=A0 """ >>> +=C2=A0=C2=A0=C2=A0 Helper class for InitRd build tests >>> +=C2=A0=C2=A0=C2=A0 """ >>> + >>> +=C2=A0=C2=A0=C2=A0 DRACUT_CONF =3D [ >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IMAGE_PREINSTALL:append = =3D ' dracut'", >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IMAGE_INSTALL:remove =3D '= enable-fsck'", >>> +=C2=A0=C2=A0=C2=A0 ] >>> + >>> +=C2=A0=C2=A0=C2=A0 def dracut_in_image(self, targets): >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 machine =3D 'qemuamd64' >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 distro =3D 'bookworm' >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 image =3D 'isar-image-ci' >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 self.init() >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 self.perform_build_test(tar= gets, >>> lines=3DInitRdBaseTest.DRACUT_CONF) >>> + >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for target in targets: >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 con= fig =3D target.split(':') >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mac= hine =3D config[1].split('-')[0] >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dis= tro =3D config[1].split('-')[1] >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ima= ge =3D config[2] >>> + >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # s= ystems booted via a dracut initrd have a dracut- >>> shutdown service >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # c= heck its presence >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sel= f.vm_start( >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 machine.removeprefix('qemu'), distro, image=3Dimage, >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 cmd=3D"systemctl is-active dracut-shutdown" >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ) >>> + >>> + >> I would suggest to move the definition of class >> InitRdBaseTest(CIBaseTest) >> to cibase.py. In citest.py there should only be definition of tests >> that we >> can directly run. > Are we sure we want to do this? While that's an easy change, I fear > that it would negatively impact readability of the tests that are > defined below. cibase is really at the framework level. The above class > is getting into the specifics. That's true. Let's keep it as it is. It will be applied after the dracut=20 patch set. > > We will anyhow need to revisit the structure of our test. If we are > successful in getting more test-case contributions (as I am really > hoping and now pushing for), then we would end-up with an enormous > citest.py file. We will need to break it down. > The reason for having a single citest.py file is that we couldn=E2=80=99t= =20 quickly find a way to make Avocado list all test cases spread across multiple py files without having to specify each file explicitly on the command line. So, the current architecture is to have a plain overview of all TCs in citest.py an= d their implementations in cibase.py (which also breaks locality). If you know a way to start avocado with one location (e.g., a directory), w= e could evaluate the "one TC -- one py file" approach. > I would therefore like to give us some time to re-think the overall > structure of our testsuite/. > > Is that agreeable? > >>> +class InitRdTest(InitRdBaseTest): >>> +=C2=A0=C2=A0=C2=A0 """ >>> +=C2=A0=C2=A0=C2=A0 Tests for initrd generation >>> +=C2=A0=C2=A0=C2=A0 :avocado: tags=3Dinitrd,single,full >>> +=C2=A0=C2=A0=C2=A0 """ >>> + >>> +=C2=A0=C2=A0=C2=A0 def test_dracut_in_image(self): >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 """Test switch to dracut in= an image recipe.""" >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 self.dracut_in_image(['mc:q= emuamd64-bookworm:isar-image- >>> ci']) >>> + >>> + >>> +class InitRdCrossTests(InitRdBaseTest): >>> +=C2=A0=C2=A0=C2=A0 """ >>> +=C2=A0=C2=A0=C2=A0 Tests for initrd generation >>> +=C2=A0=C2=A0=C2=A0 :avocado: tags=3Dinitrd,full >>> +=C2=A0=C2=A0=C2=A0 """ >>> + >>> +=C2=A0=C2=A0=C2=A0 def test_dracut_in_image(self): >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 """Test switch to dracut in= an image recipe.""" >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 self.dracut_in_image([ >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 'mc= :qemuamd64-bookworm:isar-image-ci', >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 'mc= :qemuamd64-trixie:isar-image-ci', >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 'mc= :qemuarm64-bookworm:isar-image-ci', >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 'mc= :qemuarm64-trixie:isar-image-ci' >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ]) >>> + >>> + >>> =C2=A0 class WicTest(CIBaseTest): >>> =20 >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 """ >> Thanks for adding new test cases. I have tested the v7 dracut patch >> set >> against these test cases and others in current CI, didn't show any >> error. >> We'll continue with this patch set after dracut can be applied. >> >> Best regards, >> Zhihang --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/= 9b0a6eb6-efaa-4656-b5a6-95b83e0af247%40ilbers.de.