public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Uladzimir Bely <ubely@ilbers.de>, isar-users@googlegroups.com
Subject: Re: [PATCH v3 2/3] sbuild: Set high prio for the packages from isar-apt repo
Date: Wed, 11 Jan 2023 15:52:28 +0100	[thread overview]
Message-ID: <9b8c22e4-70d3-23a5-0334-fc382d45e87e@siemens.com> (raw)
In-Reply-To: <bc325d66-b73d-f236-6886-b28fe3c3bfe8@siemens.com>

On 11.01.23 15:36, Jan Kiszka wrote:
> On 31.10.22 07:06, Uladzimir Bely wrote:
>> This sets high priority for `isar-apt` repo during sbuild session.
>> So, even if some dependency in other repos has higher version than
>> one we previously built and placed in isar-apt, the second one wil
>> be selected.
>>
>> This repeats the behaviour that is implemented in rootfs.bbclass
>> via `rootfs_configure_isar_apt` that is disabled for sbuild chroot.
>>
>> We can't simply enable this task for sbuild while we don't want to
>> have `/etc/apt/sources.list.d/isar-apt.list` file in sbuild chroot
>> while it's handled via sbuild by `--extra-repository` option
>>
>> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
>> ---
>>  meta/classes/dpkg.bbclass | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
>> index dfa097f8..c7e7dd34 100644
>> --- a/meta/classes/dpkg.bbclass
>> +++ b/meta/classes/dpkg.bbclass
>> @@ -91,6 +91,7 @@ dpkg_runbuild() {
>>          --host=${PACKAGE_ARCH} --build=${SBUILD_HOST_ARCH} ${profiles} \
>>          --no-run-lintian --no-run-piuparts --no-run-autopkgtest --resolve-alternatives \
>>          --no-apt-update \
>> +        --chroot-setup-commands="echo \"Package: *\nPin: release n=${DEBDISTRONAME}\nPin-Priority: 1000\" > /etc/apt/preferences.d/isar-apt" \
>>          --chroot-setup-commands="rm -f /var/log/dpkg.log" \
>>          --chroot-setup-commands="cp -n --no-preserve=owner ${ext_deb_dir}/*.deb -t ${deb_dir}/ || :" \
>>          --finished-build-commands="rm -f ${deb_dir}/sbuild-build-depends-main-dummy_*.deb" \
> 
> This remains a nop, doesn't it? There is no isar-apt in sbuild-chroot as
> far as I understand the logic so far. I didn't understand yet how
> isar-apt packages are otherwise injected into the build env, but this is
> not working at all.

Finally found it: sbuild --extra-repository ...

> What definitely works better here is properly
> mounting isar-apt into the schroot via its config.

That was too fast, still no preferences in effect here.

Could it be that we would need some "--extra-preferences" (which do not
exist) because sbuild creates a clean /etc/apt for the build, ignoring
the preferences in the schroot?

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux


  reply	other threads:[~2023-01-11 14:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31  6:06 [PATCH v3 0/3] Don't update apt database on every package build Uladzimir Bely
2022-10-31  6:06 ` [PATCH v3 1/3] sbuild: " Uladzimir Bely
2022-10-31  6:06 ` [PATCH v3 2/3] sbuild: Set high prio for the packages from isar-apt repo Uladzimir Bely
2023-01-11 14:36   ` Jan Kiszka
2023-01-11 14:52     ` Jan Kiszka [this message]
2023-01-11 17:34       ` Jan Kiszka
2023-01-12  7:46         ` Uladzimir Bely
2022-10-31  6:06 ` [PATCH v3 3/3] sbuild: Allow downgrades when installing dependencies Uladzimir Bely
2022-11-15  7:49 ` [PATCH v3 0/3] Don't update apt database on every package build Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b8c22e4-70d3-23a5-0334-fc382d45e87e@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=ubely@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox