RE: [PATCH 0/3] umount fixes and cleanups

["Hombourger, Cedric" <Cedric_Hombourger@mentor.com>]

FWIW, here is an excerpt of the script being used in our (Mentor) CI

# ---------------------------------------------------------------------------------------------------------------------
# Clean previous build
# ---------------------------------------------------------------------------------------------------------------------

check_build_mounts() {
   local tries=0

   while :
   do
       mounts=$(mount|awk '{print $3;}'|grep ^${PWD}/ || true);
       [ -z "${mounts}" ] && break

       for m in ${mounts}
       do
           sudo umount ${m} 2>/dev/null || true
       done

       # Abort if some mounts remain after multiple attempts
       tries=$((${tries} + 1))
       if [ ${tries} -ge 3 ]
       then
          echo "# error: mounts within 'tmp' are busy!" >&2
          exit 1
       fi
       sleep 1
   done
}

# Make sure no mounts were left from a previous build before wiping "tmp" out
echo "# info: trying to remove mounts from previous build(s)..."
check_build_mounts

# Wipe out "tmp"
if [ "${CLEANBUILD}" -eq "1" ]; then
   echo "# info: deleting previous build(s)..."
   sudo rm -rf tmp
fi

-----Original Message-----
From: Maxim Yu. Osipov [mailto:mosipov@ilbers.de] 
Sent: Wednesday, December 5, 2018 2:12 PM
To: Jan Kiszka <jan.kiszka@siemens.com>; isar-users <isar-users@googlegroups.com>
Cc: Hombourger, Cedric <Cedric_Hombourger@mentor.com>
Subject: Re: [PATCH 0/3] umount fixes and cleanups

On 12/5/18 12:29 PM, Jan Kiszka wrote:
> Patches related to resolving the pending CI issues as well as 
> simplifying the umounts used during cleanup.

Tried to run in patch queue:

027b7cf Remove redundant recursive umounts
c1bdc33 isar-events: Improve umount handler
b354273 ci: Wait for bitbake worker to finish before deleting artifacts
9cf29e6 isar-bootstrap: Fix and cleanup bind mounting
b354026 isar-image: umount base-apt when doing offline build e965c0d gitlab-ci: Switch to ci_build.sh ...

After execution of problematic test case (I rebooted PC and executed steps in clean tree):

my stretch Debian system was entered into unusable state as many important mounts were disappeared (see log of mount points before and after execution  of last command attached).

Maxim.


> Jan
> 
> Jan Kiszka (3):
>    ci: Wait for bitbake worker to finish before deleting artifacts
>    isar-events: Improve umount handler
>    Remove redundant recursive umounts
> 
>   meta/classes/isar-events.bbclass                   | 38 ++++++++--------------
>   meta/classes/isar-image.bbclass                    |  4 +--
>   .../recipes-core/isar-bootstrap/isar-bootstrap.inc |  4 +--
>   scripts/ci_build.sh                                |  1 +
>   4 files changed, 18 insertions(+), 29 deletions(-)
> 


--
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov