From: Jan Kiszka <jan.kiszka@siemens.com>
To: "[ext] Claudius Heine" <claudius.heine.ext@siemens.com>,
isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: Re: [PATCH v4 0/6] Python refactoring
Date: Tue, 12 Mar 2019 16:26:45 +0100 [thread overview]
Message-ID: <9ca8abb2-3f3c-747a-f3dc-19a0a2eb8b41@siemens.com> (raw)
In-Reply-To: <e13379e18036fa04d96d9c5c114e6341a7799713.camel@siemens.com>
On 12.03.19 15:56, [ext] Claudius Heine wrote:
> This should probaly also be part of the isar release. It should fix
> those 'ResourceWarning: unclosed file <_io.BufferedReader name=32>'
> bitbake warnings.
Which of the commits should fix that, and why? Remains non-obvious to me.
But I don't disagree that fixes, even minor ones, should be part of the release.
There are way more fixes pending, let's give Maxim some time.
Jan
>
> On Mon, 2019-03-04 at 14:07 +0100, [ext] claudius.heine.ext@siemens.com
> wrote:
>> From: Claudius Heine <ch@denx.de>
>>
>> Hi,
>>
>> I just took Haralds patchset + Maxims rebase and fixed it up.
>>
>> There was just a tiny change necessary, I added that in an additional
>> patch.
>> It builds on my machine (qemuamd64) and I am currently testing it on
>> isar-ci.
>>
>> If that is successful and review is ok, my patch can be merged into
>> the
>> 'Remove all uses of subprocess.call(shell=True)' or left separately.
>>
>> regards,
>> Claudius
>>
>> Claudius Heine (1):
>> isar-bootstrap-helper: get_deb_host_arch: fix decoding
>>
>> Harald Seiler (5):
>> Remove all uses of subprocess.call(shell=True)
>> Use modern python formatting
>> image: Remove recursion in get_image_name
>> wic: Refactor fakeroot script
>> Fix python style
>>
>> .../example-module/example-module.bb | 8 ++-
>> meta/classes/base.bbclass | 70 ++++++++++++-----
>> --
>> meta/classes/image.bbclass | 22 ++++--
>> meta/classes/isar-bootstrap-helper.bbclass | 8 +--
>> meta/classes/isar-events.bbclass | 14 ++--
>> meta/classes/patch.bbclass | 13 ++--
>> meta/classes/wic-img.bbclass | 21 ++++--
>> .../isar-bootstrap/isar-bootstrap-host.bb | 9 ++-
>> .../isar-bootstrap/isar-bootstrap-target.bb | 5 +-
>> .../isar-bootstrap/isar-bootstrap.inc | 12 ++--
>> scripts/wic_fakeroot | 9 +--
>> 11 files changed, 120 insertions(+), 71 deletions(-)
>>
>> --
>> 2.20.1
>>
>
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2019-03-12 15:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 13:07 claudius.heine.ext
2019-03-04 13:07 ` [PATCH v4 1/6] Remove all uses of subprocess.call(shell=True) claudius.heine.ext
2019-03-04 13:07 ` [PATCH v4 2/6] isar-bootstrap-helper: get_deb_host_arch: fix decoding claudius.heine.ext
2019-03-04 13:07 ` [PATCH v4 3/6] Use modern python formatting claudius.heine.ext
2019-03-04 13:07 ` [PATCH v4 4/6] image: Remove recursion in get_image_name claudius.heine.ext
2019-03-04 13:08 ` [PATCH v4 5/6] wic: Refactor fakeroot script claudius.heine.ext
2019-03-04 13:08 ` [PATCH v4 6/6] Fix python style claudius.heine.ext
2019-03-04 16:21 ` [PATCH v4 0/6] Python refactoring Claudius Heine
2019-03-11 10:10 ` Maxim Yu. Osipov
2019-03-11 12:22 ` Claudius Heine
2019-03-12 14:56 ` Claudius Heine
2019-03-12 15:26 ` Jan Kiszka [this message]
2019-03-12 15:34 ` Claudius Heine
2019-03-12 16:03 ` Jan Kiszka
2019-03-12 16:17 ` Claudius Heine
2019-03-12 22:36 ` Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ca8abb2-3f3c-747a-f3dc-19a0a2eb8b41@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=ch@denx.de \
--cc=claudius.heine.ext@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox