From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6664521764891000832 X-Received: by 2002:a5d:638b:: with SMTP id p11mr1965252wru.6.1552404409327; Tue, 12 Mar 2019 08:26:49 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:cc03:: with SMTP id f3ls425210wmh.3.canary-gmail; Tue, 12 Mar 2019 08:26:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqxiilwK8syJ2ZzozrWZiyPmIcfs1bjpSvJUga6hIf5prmGlHUZ/7N8iYCNNmkMlgotf+9CC X-Received: by 2002:a1c:f107:: with SMTP id p7mr301046wmh.12.1552404408326; Tue, 12 Mar 2019 08:26:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552404408; cv=none; d=google.com; s=arc-20160816; b=prkOYxB0A5BQx9hAz7eXQ4tdY5Byi/5TBgvlMTUcvKu5DlEcrHO3ijok0udWm0enlJ jiR4QqdUrikNkZoihfnpL76VIos/YfimtZzxt6CCt6SzsW63T2CRAJN4KftdCbWBmj7X hu0jd7olJC3V1ANjov9+tHDiju0d9ckrLhoniQ0yvK1HXD56ok1cgZ9CVvLOuGPH8HYz 4mCe7xdF0mYlIG4xsrdvXrGnjvkpdLuKJBW6A1Wt1LErz74Ss7WA+ngxZrzWaHZCrlu7 JfQQsPML7WEEJ+Dqp0NFFDKOeEb9Uk7jPz8flOGIRpBW6wxym5J6fEnpDpysmBHDAKZm B5OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=hyE5tufzPSwmTU6feenhPLQglVJdgPyVdOBGZvMGdks=; b=KHn1+psv+mZGOuBFFQFYD8ZTrFWXWgXL3PinA04cX7u0/vFf7K+VTfoo6UuIFW015a tzzqfpQynWm3ewBtkoYBPJ5ftky5EOYWJ1wMxchGxBe4XPUOHMUs3yQ/2beRaRnMUrdX DV0tNSKmonfWWJn4dix62zVEKSbo9SDh50mhPbtGtUu3kla0OxWtvJpkXcMpHijbDHoo niA3zYrZjChHTI69NxhboU/Do6sFiT8CMnYNqxOE/Ch7gN3ONtcsY8VgM8YU6+4Irfku URmGWiSKN8OM3kjwv6F7kjnj9Ksew5Cw0ksJ/3F3IMIMln4PH/WoN3rqW0BlJMjmff1i q+nQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id r15si117611wmc.4.2019.03.12.08.26.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2019 08:26:48 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x2CFQkDg016179 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Mar 2019 16:26:46 +0100 Received: from [167.87.52.219] ([167.87.52.219]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x2CFQjGU030994; Tue, 12 Mar 2019 16:26:45 +0100 Subject: Re: [PATCH v4 0/6] Python refactoring To: "[ext] Claudius Heine" , isar-users@googlegroups.com Cc: Claudius Heine References: <20190304130801.20628-1-claudius.heine.ext@siemens.com> From: Jan Kiszka Message-ID: <9ca8abb2-3f3c-747a-f3dc-19a0a2eb8b41@siemens.com> Date: Tue, 12 Mar 2019 16:26:45 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: Z7POzBsapzTX On 12.03.19 15:56, [ext] Claudius Heine wrote: > This should probaly also be part of the isar release. It should fix > those 'ResourceWarning: unclosed file <_io.BufferedReader name=32>' > bitbake warnings. Which of the commits should fix that, and why? Remains non-obvious to me. But I don't disagree that fixes, even minor ones, should be part of the release. There are way more fixes pending, let's give Maxim some time. Jan > > On Mon, 2019-03-04 at 14:07 +0100, [ext] claudius.heine.ext@siemens.com > wrote: >> From: Claudius Heine >> >> Hi, >> >> I just took Haralds patchset + Maxims rebase and fixed it up. >> >> There was just a tiny change necessary, I added that in an additional >> patch. >> It builds on my machine (qemuamd64) and I am currently testing it on >> isar-ci. >> >> If that is successful and review is ok, my patch can be merged into >> the >> 'Remove all uses of subprocess.call(shell=True)' or left separately. >> >> regards, >> Claudius >> >> Claudius Heine (1): >> isar-bootstrap-helper: get_deb_host_arch: fix decoding >> >> Harald Seiler (5): >> Remove all uses of subprocess.call(shell=True) >> Use modern python formatting >> image: Remove recursion in get_image_name >> wic: Refactor fakeroot script >> Fix python style >> >> .../example-module/example-module.bb | 8 ++- >> meta/classes/base.bbclass | 70 ++++++++++++----- >> -- >> meta/classes/image.bbclass | 22 ++++-- >> meta/classes/isar-bootstrap-helper.bbclass | 8 +-- >> meta/classes/isar-events.bbclass | 14 ++-- >> meta/classes/patch.bbclass | 13 ++-- >> meta/classes/wic-img.bbclass | 21 ++++-- >> .../isar-bootstrap/isar-bootstrap-host.bb | 9 ++- >> .../isar-bootstrap/isar-bootstrap-target.bb | 5 +- >> .../isar-bootstrap/isar-bootstrap.inc | 12 ++-- >> scripts/wic_fakeroot | 9 +-- >> 11 files changed, 120 insertions(+), 71 deletions(-) >> >> -- >> 2.20.1 >> > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux