public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: Sai Sree Kartheek Adivi <s-adivi@ti.com>,
	isar-users@googlegroups.com, vigneshr@ti.com
Subject: Re: [PATCH] initramfs-tee-ftpm-hook: Fix missing separator in OVERRIDES append
Date: Thu, 27 Nov 2025 08:15:03 +0100	[thread overview]
Message-ID: <9d4edebd-2075-47b8-9e0c-9070502e3a03@siemens.com> (raw)
In-Reply-To: <20251126112816.3415995-1-s-adivi@ti.com>

On 26.11.25 12:28, Sai Sree Kartheek Adivi wrote:
> Prepend the missing colon to the appended string to ensure 'supp-user'
> is registered as a distinct override.
> 
> This ensures that SRC_URI:supp-user takes effect when
> TEE_SUPPLICANT_IN_USERLAND is to "1".
> 
> Fixes: 3896e4da ("initramfs-tee-ftpm-hook: Use override to model variations")
> Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com>
> ---
>  .../initramfs-tee-ftpm-hook/initramfs-tee-ftpm-hook_0.3.bb      | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-initramfs/initramfs-tee-ftpm-hook/initramfs-tee-ftpm-hook_0.3.bb b/meta/recipes-initramfs/initramfs-tee-ftpm-hook/initramfs-tee-ftpm-hook_0.3.bb
> index 94399374..f1015028 100644
> --- a/meta/recipes-initramfs/initramfs-tee-ftpm-hook/initramfs-tee-ftpm-hook_0.3.bb
> +++ b/meta/recipes-initramfs/initramfs-tee-ftpm-hook/initramfs-tee-ftpm-hook_0.3.bb
> @@ -12,7 +12,7 @@ require recipes-initramfs/initramfs-hook/hook.inc
>  # NOTE: default will eventually be flipped
>  TEE_SUPPLICANT_IN_USERLAND ?= "1"
>  
> -OVERRIDES .= "${@'supp-user' if bb.utils.to_boolean(d.getVar('TEE_SUPPLICANT_IN_USERLAND')) else ''}"
> +OVERRIDES .= "${@':supp-user' if bb.utils.to_boolean(d.getVar('TEE_SUPPLICANT_IN_USERLAND')) else ''}"
>  
>  SRC_URI:supp-user += "file://local-top"
>  

Thanks, good catch!

Jan

PS: We can temporarily carry that fix in isar-cip-core if upstream isar
should take longer to merge.

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/9d4edebd-2075-47b8-9e0c-9070502e3a03%40siemens.com.

  reply	other threads:[~2025-11-27  7:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26 11:28 'Sai Sree Kartheek Adivi' via isar-users
2025-11-27  7:15 ` 'Jan Kiszka' via isar-users [this message]
2025-11-27  8:45   ` Zhihang Wei
2025-11-27  8:48     ` 'Jan Kiszka' via isar-users
2025-11-27 16:18 ` Zhihang Wei
2025-11-27 16:47   ` 'Jan Kiszka' via isar-users
2025-11-28  8:55     ` Zhihang Wei
2025-11-28 16:05 ` Zhihang Wei
2025-11-28 16:06 ` Zhihang Wei
  -- strict thread matches above, loose matches on Subject: below --
2025-11-26  9:24 'Sai Sree Kartheek Adivi' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d4edebd-2075-47b8-9e0c-9070502e3a03@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=s-adivi@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox