From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>, isar-users@googlegroups.com
Subject: Re: [PATCH] buildchroot: Add buildchroot dependency for imager
Date: Thu, 8 Jul 2021 14:11:06 +0200 [thread overview]
Message-ID: <9d5d6b80-626c-74ff-bb8c-cd98da1d6a92@siemens.com> (raw)
In-Reply-To: <0adf5409-2bd8-26d8-53d6-f6c631bacca1@ilbers.de>
On 08.07.21 13:44, Anton Mikanovich wrote:
> 08.07.2021 14:37, Jan Kiszka wrote:
>> But there is
>>
>> do_install_imager_deps[depends] = "buildchroot-target:do_build"
>>
>> in meta/classes/image-tools-extension.bbclass. Why is the above
>> additionally needed?
>>
>> Jan
>>
> Because buildchroot is not always buildchroot-target, but depends on
> ISAR_CROSS_COMPILE value.
It was always buildchroot-target for imaging, so far
> This change is mostly done for situations like in `[PATCH] ubifs-img:
> Force cross-compile usage`.
And that creates a new situation, indeed.
> Hardcoded dependency should be removed, I will prepare v2 and change
> commit log.
Right, that would be good. However, the original dependency was omre
cleanly located than this hack. Why should builchroot know who all
depends on it?
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2021-07-08 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 16:41 Anton Mikanovich
2021-07-08 11:37 ` Jan Kiszka
2021-07-08 11:44 ` Anton Mikanovich
2021-07-08 12:11 ` Jan Kiszka [this message]
2021-07-08 12:25 ` Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d5d6b80-626c-74ff-bb8c-cd98da1d6a92@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox