From: Zhihang Wei <wzh@ilbers.de>
To: Felix Moessbauer <felix.moessbauer@siemens.com>,
isar-users@googlegroups.com
Subject: Re: [PATCH 1/1] compat: handle user errors gracefully to avoid parser splat
Date: Mon, 2 Mar 2026 09:41:27 +0100 [thread overview]
Message-ID: <9d8f796e-dd33-42e5-8d29-5469050db6fb@ilbers.de> (raw)
In-Reply-To: <20260227101009.2465660-1-felix.moessbauer@siemens.com>
Applied to next, thanks.
Zhihang
On 2/27/26 11:10, 'Felix Moessbauer' via isar-users wrote:
> A common user error is to forget to define a machine (or use one that is
> not defined). In this case, a huge parsing error is printed, giving no
> indication what the actually user error is. Instead of crashing the
> parser, we now report a meaningful user error.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
> Dear maintainers,
>
> I recommend to include this patch in the upcoming release.
>
> Best regards,
> Felix
>
> meta/classes-recipe/compat.bbclass | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta/classes-recipe/compat.bbclass b/meta/classes-recipe/compat.bbclass
> index 907c3ce2..7df55576 100644
> --- a/meta/classes-recipe/compat.bbclass
> +++ b/meta/classes-recipe/compat.bbclass
> @@ -19,6 +19,9 @@ python() {
> package_arch = d.getVar('PACKAGE_ARCH')
> overrides = d.getVar('OVERRIDES').split(':')
>
> + if not distro_arch:
> + bb.fatal("DISTRO_ARCH is not set")
> +
> localdata = bb.data.createCopy(d)
> new_overrides = [distro_arch] + [o for o in overrides if not o == package_arch]
> localdata.setVar('OVERRIDES', ':'.join(new_overrides))
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/9d8f796e-dd33-42e5-8d29-5469050db6fb%40ilbers.de.
prev parent reply other threads:[~2026-03-02 8:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 10:10 'Felix Moessbauer' via isar-users
2026-03-02 8:41 ` Zhihang Wei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d8f796e-dd33-42e5-8d29-5469050db6fb@ilbers.de \
--to=wzh@ilbers.de \
--cc=felix.moessbauer@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox