Re: [PATCH v3 0/1] Template system

["Maxim Yu. Osipov" <mosipov@ilbers.de>]

Hi Claudius,

Good news:

I've installed gettext-base in ilbers CI and with this version of patch 
your series applied over current next was built OK:
http://isar-build.org:8080/job/isar_mosipov_next/142/consoleFull

Only smoke test for qemui386-buster failed - but this is not relevant to 
your patches (this sporadically happens and needs to be investigated 
separately).

Bad news:

So far build of de0-nano-soc-stretch target with enabled 
CROSS_COMPILATION was not included into CI.
After upgrade of CI server I'll include de0-nano-soc-stretch target into 
CI "fast" build as this is a supported target which in particular builds 
linux kernel and u-boot.
The corresponding patch will be sent afterwards.

So I tried to build de0-nano-soc-stretch target (on my branch 
https://github.com/ilbers/isar/commits/mosipov-next)  with enabled 
CROSS_COMPILATION - and it fails after applying your patches. See log 
below. Build of de0-nano-soc-stretch with enabled CROSS_COMPILATION on 
current 'next' passes OK.


========
bitbake multiconfig:de0-nano-soc-stretch:isar-image-base

<snip>

NOTE: Executing RunQueue Tasks
ERROR: mc:de0-nano-soc-stretch:u-boot-2018.09-r0 do_install_builddeps: 
Function failed: do_install_builddeps (log file is located at 
/home/myo/work/isar/src/trunk/isar/build/tmp/work/debian-stretch-armhf/u-boot-2018.09-r0/temp/log.do_install_builddeps.5395)
ERROR: Logfile of failure stored in: 
/home/myo/work/isar/src/trunk/isar/build/tmp/work/debian-stretch-armhf/u-boot-2018.09-r0/temp/log.do_install_builddeps.5395
Log data follows:
| DEBUG: Executing shell function do_install_builddeps
| Get:1 file:/isar-apt isar InRelease
| Ign:1 file:/isar-apt isar InRelease
| Get:2 file:/isar-apt isar Release [3563 B]
| Get:2 file:/isar-apt isar Release [3563 B]
| Get:3 file:/isar-apt isar Release.gpg
| Ign:3 file:/isar-apt isar Release.gpg
| Get:4 file:/isar-apt isar/main armhf Packages [544 B]
| Reading package lists...
| mk-build-deps: warning:     debian/changelog(l1): badly formatted 
heading line
| LINE: ${PN} (${PV}) unstable; urgency=low
| mk-build-deps: warning:     debian/changelog(l2): found blank line 
where expected first heading
| mk-build-deps: warning:     debian/changelog(l3): found change data 
where expected first heading
| LINE:   * Generated package.
| mk-build-deps: warning: unknown information field '' in input data in 
parsed version of changelog
| hostname: Name or service not known
| dpkg-architecture: warning: specified GNU system type 
arm-linux-gnueabihf does not match CC system type x86_64-linux-gnu, try 
setting a correct CC environment variable
| dh_testdir
| dh_testroot
| dh_prep
| dh_testdir
| dh_testroot
| dh_install
| dh_install: Compatibility levels before 9 are deprecated (level 7 in use)
| dh_installdocs
| dh_installdocs: Compatibility levels before 9 are deprecated (level 7 
in use)
| dh_installchangelogs
| dpkg-parsechangelog: warning:     debian/changelog(l1): badly 
formatted heading line
| LINE: ${PN}-cross-build-deps (1.0) unstable; urgency=low
| dpkg-parsechangelog: warning:     debian/changelog(l2): found blank 
line where expected first heading
| dpkg-parsechangelog: warning:     debian/changelog(l3): found change 
data where expected first heading
| LINE:   * First version
| dpkg-parsechangelog: warning: unknown information field '' in input 
data in parsed version of changelog
| dh_compress
| find: 'debian/-cross-build-deps': No such file or directory
| dh_fixperms
| dh_installdeb
| dh_installdeb: Compatibility levels before 9 are deprecated (level 7 
in use)
| dh_gencontrol
| dpkg-gencontrol: error: illegal package name '${PN}-cross-build-deps': 
character '$' not allowed
| dh_gencontrol: dpkg-gencontrol -p${PN}-cross-build-deps 
-ldebian/changelog -Tdebian/${PN}-cross-build-deps.substvars 
-Pdebian/${PN}-cross-build-deps returned exit code 255
| debian/rules:20: recipe for target 'binary-indep' failed
| make: *** [binary-indep] Error 2
| Error in the build process: exit status 2
| dpkg: error: cannot access archive 
'${PN}-cross-build-deps_1.0_armhf.deb': No such file or directory
| mk-build-deps: dpkg --unpack failed
| WARNING: exit code 2 from a shell command.
| ERROR: Function failed: do_install_builddeps (log file is located at 
/home/myo/work/isar/src/trunk/isar/build/tmp/work/debian-stretch-armhf/u-boot-2018.09-r0/temp/log.do_install_builddeps.5395)
======



On 2/13/19 4:13 PM, claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
> 
> Hi,
> 
> so after having access to the ilbers ci I could find some issues with
> this patch.
> 
> I will try to describe the issue I think happened here:
> 
> Initially I added the 'do_transform_template' task with a 'before
> do_build' that normally just triggers the template generation process if
> the default task 'do_build' is run. The 'do_transform_template' task has
> the default '${DISTRO}-${DISTRO_ARCH}' stamp-extra-info that we have to
> add to pretty much all new tasks in isar.
> 
> That might be ok for normal recipes, but the buildchroot-* recipes add
> stuff to the virtual default `do_build` and that now depend on the
> `do_transform_template` task and its dependencies.
> 
> Currently that is a bit to complex for me to exactly figure out how
> those errors get triggered, but since that works in the internal CI, but
> not on ilbers, that messes up the bitbake task order.
> 
> So my solution is to remove the 'before do_build', now
> 'do_transform_template' is no longer executed per default. 'dpkg-base'
> and the image classes add their own dependencies if they need that task.
> 
> Currently the build a ilbers ci still fails, because apparently
> gettext-base is not installed there. I added gettext-base as a
> dependency to the user_manual.md
> 
> regards,
> Claudius
> 
> Changes from v2:
>   - put subprocess into context manager
>   - added 'gettext-base' isar dependency
>   - remove 'before do_build' from addtask
> 
> Changes from v1:
>   - fixed spelling mistakes of documentation
> 
> Claudius Heine (1):
>    meta: added do_transform_template task as templating system and switch
> 
>   doc/technical_overview.md                     | 25 ++++++++
>   doc/user_manual.md                            |  1 +
>   meta/classes/base.bbclass                     |  1 +
>   meta/classes/dpkg-base.bbclass                |  2 +-
>   meta/classes/template.bbclass                 | 62 +++++++++++++++++++
>   .../debian/{changelog => changelog.tmpl}      |  2 +-
>   meta/recipes-bsp/u-boot/files/debian/control  | 19 ------
>   .../u-boot/files/debian/control.tmpl          | 19 ++++++
>   meta/recipes-bsp/u-boot/u-boot-custom.inc     | 12 ++--
>   .../debian/{changelog => changelog.tmpl}      |  2 +-
>   .../linux-module/files/debian/control         | 11 ----
>   .../linux-module/files/debian/control.tmpl    | 11 ++++
>   meta/recipes-kernel/linux-module/module.inc   |  7 +--
>   13 files changed, 130 insertions(+), 44 deletions(-)
>   create mode 100644 meta/classes/template.bbclass
>   rename meta/recipes-bsp/u-boot/files/debian/{changelog => changelog.tmpl} (74%)
>   delete mode 100644 meta/recipes-bsp/u-boot/files/debian/control
>   create mode 100644 meta/recipes-bsp/u-boot/files/debian/control.tmpl
>   rename meta/recipes-kernel/linux-module/files/debian/{changelog => changelog.tmpl} (74%)
>   delete mode 100644 meta/recipes-kernel/linux-module/files/debian/control
>   create mode 100644 meta/recipes-kernel/linux-module/files/debian/control.tmpl
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov