From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6652594697292218368 X-Received: by 2002:a1c:2088:: with SMTP id g130mr131935wmg.6.1550130884026; Wed, 13 Feb 2019 23:54:44 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:35c6:: with SMTP id c189ls217210wma.13.canary-gmail; Wed, 13 Feb 2019 23:54:43 -0800 (PST) X-Google-Smtp-Source: AHgI3IaB57nXPQNyRar58ixWP2wkuqxnrgfdOiB/8Vy1JwJk1b7uU+PgXn8joWSMU10yN3bzh1Pe X-Received: by 2002:a1c:28c4:: with SMTP id o187mr147542wmo.7.1550130883590; Wed, 13 Feb 2019 23:54:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550130883; cv=none; d=google.com; s=arc-20160816; b=o0GElGzn7oiA9OZG1Qe5b3/x/Fk9ytG+AXxidoVtqKwh/S4NLc4D6GuCR9J8NTkkxC HwK8Vbwk8ghstHOjyVgzDRo+JEZwwnIitteMlvHBZj85rbWv8Z/2d2twk+yM2Wq1JOns kpQXVZ4b75ZmNiUDQXc3miXsIrv3TnEcGeeFawNhLMbGgS+dvNxr+mZXs4M2j1/V6gcG bUnx8DXGz+vNUZa5dnUcdzFvXxdzl6wOsYEy7nMOruBfJhWbCZSo5GjP7Sxii2gI6RBE rkyBo1FLt1jzmwRMewIS3I/v83bcN2Xvmi14j7Y8TGbwWq9LoQ1ZUm+DpaX9S8A6MrUZ VOqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=f4F6UQkzbAVv66L7JgTTbZVLZyWx5HC8GxKOmDaenDI=; b=P1VDvEtwU0eDGinNiQCJI+Y7vEAKRR9q+n8GThEpb5+U5p7Kncg1y0CQ/x72YlIZWT aI8Nb4nZK8tsfLLh1AjPMYyiz3G0xtcjk5pBHYe+9ah1ZKbBAihcqviwbFyKzeKx7mwD i7EANcWAoSxWX/7pwEZUB8q8w1ZKRSUqdrIPoiqNtfGJl+vsWQ4hBroLn37W/qGAcI3V zZFJbMS/Kt9OPvL07a8vFQqgaHrRVyhcwFOzvshG8jMJ9eNnNg8THe3CUXXcYga1W5sA MeMSe7IPyGu1bsh0Qa5lyKN9dUoUqvybst1OjW4B4l5tjqVwS2JZfxrNSjBh1HN7GUxe nc1A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id c12si63440wrn.5.2019.02.13.23.54.43 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Feb 2019 23:54:43 -0800 (PST) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.163] (d51A48A80.access.telenet.be [81.164.138.128]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x1E7sfKm026765 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Feb 2019 08:54:41 +0100 Subject: Re: [PATCH v3 0/1] Template system To: claudius.heine.ext@siemens.com, isar-users@googlegroups.com Cc: Claudius Heine References: <20190213151346.2498-1-claudius.heine.ext@siemens.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <9de0d59a-50c9-f993-66c6-e08ddbfad028@ilbers.de> Date: Thu, 14 Feb 2019 08:54:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190213151346.2498-1-claudius.heine.ext@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: tATPkvYSUYY+ Hi Claudius, Good news: I've installed gettext-base in ilbers CI and with this version of patch your series applied over current next was built OK: http://isar-build.org:8080/job/isar_mosipov_next/142/consoleFull Only smoke test for qemui386-buster failed - but this is not relevant to your patches (this sporadically happens and needs to be investigated separately). Bad news: So far build of de0-nano-soc-stretch target with enabled CROSS_COMPILATION was not included into CI. After upgrade of CI server I'll include de0-nano-soc-stretch target into CI "fast" build as this is a supported target which in particular builds linux kernel and u-boot. The corresponding patch will be sent afterwards. So I tried to build de0-nano-soc-stretch target (on my branch https://github.com/ilbers/isar/commits/mosipov-next) with enabled CROSS_COMPILATION - and it fails after applying your patches. See log below. Build of de0-nano-soc-stretch with enabled CROSS_COMPILATION on current 'next' passes OK. ======== bitbake multiconfig:de0-nano-soc-stretch:isar-image-base NOTE: Executing RunQueue Tasks ERROR: mc:de0-nano-soc-stretch:u-boot-2018.09-r0 do_install_builddeps: Function failed: do_install_builddeps (log file is located at /home/myo/work/isar/src/trunk/isar/build/tmp/work/debian-stretch-armhf/u-boot-2018.09-r0/temp/log.do_install_builddeps.5395) ERROR: Logfile of failure stored in: /home/myo/work/isar/src/trunk/isar/build/tmp/work/debian-stretch-armhf/u-boot-2018.09-r0/temp/log.do_install_builddeps.5395 Log data follows: | DEBUG: Executing shell function do_install_builddeps | Get:1 file:/isar-apt isar InRelease | Ign:1 file:/isar-apt isar InRelease | Get:2 file:/isar-apt isar Release [3563 B] | Get:2 file:/isar-apt isar Release [3563 B] | Get:3 file:/isar-apt isar Release.gpg | Ign:3 file:/isar-apt isar Release.gpg | Get:4 file:/isar-apt isar/main armhf Packages [544 B] | Reading package lists... | mk-build-deps: warning: debian/changelog(l1): badly formatted heading line | LINE: ${PN} (${PV}) unstable; urgency=low | mk-build-deps: warning: debian/changelog(l2): found blank line where expected first heading | mk-build-deps: warning: debian/changelog(l3): found change data where expected first heading | LINE: * Generated package. | mk-build-deps: warning: unknown information field '' in input data in parsed version of changelog | hostname: Name or service not known | dpkg-architecture: warning: specified GNU system type arm-linux-gnueabihf does not match CC system type x86_64-linux-gnu, try setting a correct CC environment variable | dh_testdir | dh_testroot | dh_prep | dh_testdir | dh_testroot | dh_install | dh_install: Compatibility levels before 9 are deprecated (level 7 in use) | dh_installdocs | dh_installdocs: Compatibility levels before 9 are deprecated (level 7 in use) | dh_installchangelogs | dpkg-parsechangelog: warning: debian/changelog(l1): badly formatted heading line | LINE: ${PN}-cross-build-deps (1.0) unstable; urgency=low | dpkg-parsechangelog: warning: debian/changelog(l2): found blank line where expected first heading | dpkg-parsechangelog: warning: debian/changelog(l3): found change data where expected first heading | LINE: * First version | dpkg-parsechangelog: warning: unknown information field '' in input data in parsed version of changelog | dh_compress | find: 'debian/-cross-build-deps': No such file or directory | dh_fixperms | dh_installdeb | dh_installdeb: Compatibility levels before 9 are deprecated (level 7 in use) | dh_gencontrol | dpkg-gencontrol: error: illegal package name '${PN}-cross-build-deps': character '$' not allowed | dh_gencontrol: dpkg-gencontrol -p${PN}-cross-build-deps -ldebian/changelog -Tdebian/${PN}-cross-build-deps.substvars -Pdebian/${PN}-cross-build-deps returned exit code 255 | debian/rules:20: recipe for target 'binary-indep' failed | make: *** [binary-indep] Error 2 | Error in the build process: exit status 2 | dpkg: error: cannot access archive '${PN}-cross-build-deps_1.0_armhf.deb': No such file or directory | mk-build-deps: dpkg --unpack failed | WARNING: exit code 2 from a shell command. | ERROR: Function failed: do_install_builddeps (log file is located at /home/myo/work/isar/src/trunk/isar/build/tmp/work/debian-stretch-armhf/u-boot-2018.09-r0/temp/log.do_install_builddeps.5395) ====== On 2/13/19 4:13 PM, claudius.heine.ext@siemens.com wrote: > From: Claudius Heine > > Hi, > > so after having access to the ilbers ci I could find some issues with > this patch. > > I will try to describe the issue I think happened here: > > Initially I added the 'do_transform_template' task with a 'before > do_build' that normally just triggers the template generation process if > the default task 'do_build' is run. The 'do_transform_template' task has > the default '${DISTRO}-${DISTRO_ARCH}' stamp-extra-info that we have to > add to pretty much all new tasks in isar. > > That might be ok for normal recipes, but the buildchroot-* recipes add > stuff to the virtual default `do_build` and that now depend on the > `do_transform_template` task and its dependencies. > > Currently that is a bit to complex for me to exactly figure out how > those errors get triggered, but since that works in the internal CI, but > not on ilbers, that messes up the bitbake task order. > > So my solution is to remove the 'before do_build', now > 'do_transform_template' is no longer executed per default. 'dpkg-base' > and the image classes add their own dependencies if they need that task. > > Currently the build a ilbers ci still fails, because apparently > gettext-base is not installed there. I added gettext-base as a > dependency to the user_manual.md > > regards, > Claudius > > Changes from v2: > - put subprocess into context manager > - added 'gettext-base' isar dependency > - remove 'before do_build' from addtask > > Changes from v1: > - fixed spelling mistakes of documentation > > Claudius Heine (1): > meta: added do_transform_template task as templating system and switch > > doc/technical_overview.md | 25 ++++++++ > doc/user_manual.md | 1 + > meta/classes/base.bbclass | 1 + > meta/classes/dpkg-base.bbclass | 2 +- > meta/classes/template.bbclass | 62 +++++++++++++++++++ > .../debian/{changelog => changelog.tmpl} | 2 +- > meta/recipes-bsp/u-boot/files/debian/control | 19 ------ > .../u-boot/files/debian/control.tmpl | 19 ++++++ > meta/recipes-bsp/u-boot/u-boot-custom.inc | 12 ++-- > .../debian/{changelog => changelog.tmpl} | 2 +- > .../linux-module/files/debian/control | 11 ---- > .../linux-module/files/debian/control.tmpl | 11 ++++ > meta/recipes-kernel/linux-module/module.inc | 7 +-- > 13 files changed, 130 insertions(+), 44 deletions(-) > create mode 100644 meta/classes/template.bbclass > rename meta/recipes-bsp/u-boot/files/debian/{changelog => changelog.tmpl} (74%) > delete mode 100644 meta/recipes-bsp/u-boot/files/debian/control > create mode 100644 meta/recipes-bsp/u-boot/files/debian/control.tmpl > rename meta/recipes-kernel/linux-module/files/debian/{changelog => changelog.tmpl} (74%) > delete mode 100644 meta/recipes-kernel/linux-module/files/debian/control > create mode 100644 meta/recipes-kernel/linux-module/files/debian/control.tmpl > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov