Re: [PATCH v2 1/4] dpkg-base: Lock do_adjust_git against each other

[Jan Kiszka <jan.kiszka@siemens.com>]

On 13.08.21 15:55, Henning Schild wrote:
> Am Thu, 12 Aug 2021 13:48:49 +0200
> schrieb Jan Kiszka <jan.kiszka@siemens.com>:
> 
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> This is needed since e47ada143469 because we now adjust the links to
>> mirrors in DL_DIR which may collide with other tasks doing this at the
>> same time.
>>
>> Locking with also be needed soon for establishing the host-side link
>> to the download dir.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  meta/classes/dpkg-base.bbclass | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/classes/dpkg-base.bbclass
>> b/meta/classes/dpkg-base.bbclass index ec8fbc1..fe16846 100644
>> --- a/meta/classes/dpkg-base.bbclass
>> +++ b/meta/classes/dpkg-base.bbclass
>> @@ -55,6 +55,7 @@ python do_adjust_git() {
>>  }
>>  
>>  addtask adjust_git before do_dpkg_build
>> +do_adjust_git[lockfiles] += "${DL_DIR}/isar.lock"
> 
> The name of the file and the location suggest pretty wide locking ...
> could sound like the whole DL_DIR is locked, by isar ...
> 
> I know that is a "pattern" but not sure it is a good one. Maybe using
> the task name would be better.

Yeah, could move the lock into ${DL_DIR}/git.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux