From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6995471841453146112 X-Received: by 2002:a5d:4808:: with SMTP id l8mr14668117wrq.349.1629053744914; Sun, 15 Aug 2021 11:55:44 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:a191:: with SMTP id u17ls6293032wru.3.gmail; Sun, 15 Aug 2021 11:55:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/tHDi3ym73PLcQul+pK+jhElFpPv6TkA2rnUTB6DgjtcNRKivU5k+HHsTQ9nL1fUjBVc3 X-Received: by 2002:a5d:5550:: with SMTP id g16mr14645264wrw.336.1629053743892; Sun, 15 Aug 2021 11:55:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629053743; cv=none; d=google.com; s=arc-20160816; b=MCxCEKWSXvjw1PAbRf65heTrAx9zBQ177FxxUviHHk8090/Bn5tI8v/FanywcdMYqw CD4xxvMCwqMJypc7ziLpmg0Lvq8DG7QvzO7a9v5ePpyuzeQ2se/hdRNVmMviFlcZhKOs LH0Kk/fClWdK6oJu49UCiPpEQ4LIq82yW7CJiABEU0EXMXOCOO/E7E+4EYGec6549GLK 4GdZ5dScNsg9g/bQpHvWlSKZqxt7hRUcoFhZXdHM4HbxavHcaOMJ3qMNOyLdbYjYOFG9 6i3yMPkNgwdb8RQmd+SUe5bw1pj2lLHrrSJlIj8PODXjTcTwiPSwwHfZX3ltik8jOp14 a7Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=2AZWmmnd0a0TJiNOHzWanRBbdmImIZl7zVi0J1Innzo=; b=s/PAZNrtfbug0dLH+ZstpEOBZnXX1h6wB/f3GXFPXdSNATnuR/LUu1Z3imeUIugSCl bWDQJXdki5p7UE1eLUUmzztPeD0ECkTCPHQAg3f/phyAkuZdAbKQL2gnZT5PFp9WyWXW 7zrL/Bu4Yx/TDZqMc3ne1kOjP+M7SPP37SNSFYbpI5aigwj0GOuaiv05r5q+gBdRGq0i YG2CNHdcBZ/tRSn7CD0cQjT5OcnPev59on0cJzlssBrRTwLJvwcziESLMGgAGTuV6Dcf xUP0i4dCpNYFpmwjQVuFua/yg2eeyBhsLuuVoINbJErX2s3QDpu/afVuW1sSy0gK/Pkb QJ6w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id l23si246572wmi.4.2021.08.15.11.55.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Aug 2021 11:55:43 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 17FIthnC019206 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 15 Aug 2021 20:55:43 +0200 Received: from [167.87.0.29] ([167.87.0.29]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 17FItgOR007158; Sun, 15 Aug 2021 20:55:42 +0200 Subject: Re: [PATCH v2 1/4] dpkg-base: Lock do_adjust_git against each other To: Henning Schild Cc: isar-users , Uladzimir Bely References: <783379a67fd56190657de0044e28b354f3e9b1a0.1628768932.git.jan.kiszka@siemens.com> <20210813155532.077d2f21@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <9e4c5384-b5f6-5dd2-0206-19f88113a873@siemens.com> Date: Sun, 15 Aug 2021 20:55:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210813155532.077d2f21@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: BVpInXHUX5Ah On 13.08.21 15:55, Henning Schild wrote: > Am Thu, 12 Aug 2021 13:48:49 +0200 > schrieb Jan Kiszka : > >> From: Jan Kiszka >> >> This is needed since e47ada143469 because we now adjust the links to >> mirrors in DL_DIR which may collide with other tasks doing this at the >> same time. >> >> Locking with also be needed soon for establishing the host-side link >> to the download dir. >> >> Signed-off-by: Jan Kiszka >> --- >> meta/classes/dpkg-base.bbclass | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/meta/classes/dpkg-base.bbclass >> b/meta/classes/dpkg-base.bbclass index ec8fbc1..fe16846 100644 >> --- a/meta/classes/dpkg-base.bbclass >> +++ b/meta/classes/dpkg-base.bbclass >> @@ -55,6 +55,7 @@ python do_adjust_git() { >> } >> >> addtask adjust_git before do_dpkg_build >> +do_adjust_git[lockfiles] += "${DL_DIR}/isar.lock" > > The name of the file and the location suggest pretty wide locking ... > could sound like the whole DL_DIR is locked, by isar ... > > I know that is a "pattern" but not sure it is a good one. Maybe using > the task name would be better. Yeah, could move the lock into ${DL_DIR}/git. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux