From: Anton Mikanovich <amikan@ilbers.de>
To: martin.banov.dev@gmail.com, isar-users@googlegroups.com
Cc: Martin Banov <mabo@universal-robots.com>,
Daniel Machon <dama@universal-robots.com>
Subject: Re: [PATCH v2] image-container-extension: exclude proc sys dev
Date: Tue, 26 Apr 2022 14:01:06 +0300 [thread overview]
Message-ID: <9e5f6707-4583-6e10-e67b-01261e8aa5ff@ilbers.de> (raw)
In-Reply-To: <20220405085804.7467-1-martin.banov.dev@gmail.com>
05.04.2022 11:58, martin.banov.dev@gmail.com wrote:
> From: Martin Banov <mabo@universal-robots.com>
>
> The patch prevents 'cp' from copying the kernel filesystems
> into the docker container.
> We had CI issues with 'cp' trying to copy /proc/<pid>/pagemap.
>
> Signed-off-by: Martin Banov <mabo@universal-robots.com>
> Signed-off-by: Daniel Machon <dama@universal-robots.com>
> ---
> meta/classes/image-container-extension.bbclass | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meta/classes/image-container-extension.bbclass b/meta/classes/image-container-extension.bbclass
> index cdec463..f4e8d41 100644
> --- a/meta/classes/image-container-extension.bbclass
> +++ b/meta/classes/image-container-extension.bbclass
> @@ -29,9 +29,8 @@ containerize_rootfs() {
> "${oci_img_dir}_unpacked"
>
> # add root filesystem as the flesh of the skeleton
> - sudo cp -a "${rootfs}"/* "${oci_img_dir}_unpacked/rootfs/"
> - # clean-up temporary files
> - sudo find "${oci_img_dir}_unpacked/rootfs/tmp" -mindepth 1 -delete
> + sudo cp -axT "${rootfs}" "${oci_img_dir}_unpacked/rootfs/"
> +
Please remove unnecessary spaces here.
>
> # pack container image
> bbdebug 1 "pack container image"
Also this patch fails on 'bitbake -c do_populate_sdk
mc:container-amd64-stretch:isar-image-base' if setting SDK_FORMATS =
"docker-archive"
prev parent reply other threads:[~2022-04-26 11:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 8:58 martin.banov.dev
2022-04-26 11:01 ` Anton Mikanovich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e5f6707-4583-6e10-e67b-01261e8aa5ff@ilbers.de \
--to=amikan@ilbers.de \
--cc=dama@universal-robots.com \
--cc=isar-users@googlegroups.com \
--cc=mabo@universal-robots.com \
--cc=martin.banov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox