From: Jan Kiszka <jan.kiszka@siemens.com>
To: Harald Seiler <hws@denx.de>, isar-users@googlegroups.com
Subject: Re: [PATCH] dpkg-raw: Fix rebuilding recipes
Date: Tue, 9 Oct 2018 12:05:21 +0200 [thread overview]
Message-ID: <9e705dc1-53cd-28d1-8d8d-a832fb887d16@siemens.com> (raw)
In-Reply-To: <23f5cd40400ecfc4074e0fb0185902fccd7bae2e.camel@denx.de>
On 09.10.18 11:06, Harald Seiler wrote:
> Rebuilding dpkg-raw packages fails because the
> DEBIAN directories' ownership is transferred to
> root in dpkg_runbuild. This commit ensures the
> ownership is reset before attempting to write
> metadata.
>
> Signed-off-by: Harald Seiler <hws@denx.de>
> ---
> meta/classes/dpkg-raw.bbclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/dpkg-raw.bbclass b/meta/classes/dpkg-raw.bbclass
> index c848f3d..806a2d4 100644
> --- a/meta/classes/dpkg-raw.bbclass
> +++ b/meta/classes/dpkg-raw.bbclass
> @@ -18,7 +18,8 @@ addtask install after do_unpack before do_prepare_build
>
> deb_package_prepare() {
> sudo rm -rf ${D}/DEBIAN
> - mkdir -p ${D}/DEBIAN
> + sudo mkdir -p ${D}/DEBIAN
> + sudo chown ${USER}:${USER} ${D}/DEBIAN
That makes no sense to me: We remove that folder first, and then create it under
the name of the current user. These two changes are redundant in that light.
Can you describe in more details what you did and how the error messages looked
like? I frequently rebuild dpkg-raw packages and never saw such an issue recently.
Jan
> cat<<-__EOF__ > ${D}/DEBIAN/control
> Package: ${PN}
> Architecture: ${DISTRO_ARCH}
>
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2018-10-09 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 9:06 Harald Seiler
2018-10-09 10:05 ` Jan Kiszka [this message]
2018-10-09 10:28 ` Harald Seiler
2018-10-09 12:17 ` Jan Kiszka
2018-10-09 12:31 ` Jan Kiszka
2018-10-09 14:23 ` Harald Seiler
2018-10-09 15:11 ` Jan Kiszka
2018-10-22 15:57 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e705dc1-53cd-28d1-8d8d-a832fb887d16@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=hws@denx.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox