public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>,
	Maksim Osipov <mosipov@ilbers.de>
Subject: Re: [PATCH v3] meta: Run depmod after kernel module installation
Date: Sun, 19 Aug 2018 09:23:41 +0200	[thread overview]
Message-ID: <9eb9c94c-e048-68f1-5662-fcb233ef7ff5@siemens.com> (raw)
In-Reply-To: <eb7b2e3f-a6e7-6054-7bac-16ec1392172e@siemens.com>

On 2018-07-09 11:50, [ext] Jan Kiszka wrote:
> Otherwise the module may not be found if the module package is installed
> on its own, i.e. without the kernel package performing the depmod run.
> 
> As we now install a postinst baseline with the right mode, the chmod on
> AUTOLOAD becomes obsolete.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> Changes in v3:
>   - remove now obsolete chmod on AUTOLOAD
> 
>   meta/recipes-kernel/linux-module/files/debian/postinst | 4 ++++
>   meta/recipes-kernel/linux-module/module.inc            | 1 -
>   2 files changed, 4 insertions(+), 1 deletion(-)
>   create mode 100755 meta/recipes-kernel/linux-module/files/debian/postinst
> 
> diff --git a/meta/recipes-kernel/linux-module/files/debian/postinst b/meta/recipes-kernel/linux-module/files/debian/postinst
> new file mode 100755
> index 0000000..baabf5d
> --- /dev/null
> +++ b/meta/recipes-kernel/linux-module/files/debian/postinst
> @@ -0,0 +1,4 @@
> +#!/bin/sh
> +set -e
> +
> +depmod -a
> diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc
> index 3075f44..76a49f3 100644
> --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -26,6 +26,5 @@ dpkg_runbuild_prepend() {
>   
>       if [ ${AUTOLOAD} = "1" ]; then
>           echo "echo ${PN} >> /etc/modules" >> ${S}/debian/postinst
> -        chmod +x ${S}/debian/postinst
>       fi
>   }
> 

Ping. Seems this fell through the cracks.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2018-08-19  7:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09  9:50 Jan Kiszka
2018-08-19  7:23 ` Jan Kiszka [this message]
2018-08-19 10:17   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9eb9c94c-e048-68f1-5662-fcb233ef7ff5@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=mosipov@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox