From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 29 Aug 2024 11:26:20 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-lj1-f188.google.com (mail-lj1-f188.google.com [209.85.208.188]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 47T9QJPr001223 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 29 Aug 2024 11:26:19 +0200 Received: by mail-lj1-f188.google.com with SMTP id 38308e7fff4ca-2f403c3ffecsf4757941fa.1 for ; Thu, 29 Aug 2024 02:26:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1724923574; cv=pass; d=google.com; s=arc-20240605; b=Ntrnlrjqk4PogWQ7iGzFxR7zSqOQ4LNiihiVHyz/x9126g895QKwlj94KDQp/Svaju tFl1giHOqbe2tkXSShNbNEAW1LupfxMx/bd7uPBiUNN54N1Eqzay+rkoayyOj5f0t9Mu 3H7OgWjBXhgmerwJotziemVivdNCodCXNvfEtjee/st8ZgOSWG6x9F9jdzAjb3wvuJUX MfOOb9vj6BRPmT1mNP1BvmPYO+fXzYSD+m7W/JIrW/8qpuQOO1vVVQ7u1aCnVyBTlrFH ukZDq3jYCXKmtmWA72X5p+w4xmJfYiALSvvVo67F+MctxQ8hYacHtF1/XRKMN7bVoWxg Tqag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:dkim-signature; bh=Fe9oQTHww4Rxv5s3j/8TsioRTsymXGoqblvegVb8pPs=; fh=+ArBCNh8aKhf+snXFNgnqTBd1U+Ksr+8KzWnHQqx0ok=; b=eR39YIT053d2esoyp51fa2u/j22K5lSr/tu4F3nw6bWey5BTYRDsfCOjzqN7rGxkvo ZHxOuZ8nwoOvqtPAkiidA20+mmXW+r65ErGhqY4A156TwnfUTVitprQVyp4nppV0QgGd /yjWLtdpgJmpnuvqI46aCRow4E4+2ntnL6+I2bBc3DsWOoputj3kS+cYb/GheVMAteCI Yvv+rzkmkusLoMBf4UKsRDbxqGGuLsP+kg+/+3NSlMeu6o/dwU5ebo7fKh7BBiD38JU9 SMGZTKlyMlT1CAobYvZesrjW5hQhB9+RQecNRnzwn2TRXYRJLDSk4tZRZ+RG52LO3skA 0oYw==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1724923574; x=1725528374; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:in-reply-to:from:content-language:references:cc :to:subject:user-agent:mime-version:date:message-id:sender:from:to :cc:subject:date:message-id:reply-to; bh=Fe9oQTHww4Rxv5s3j/8TsioRTsymXGoqblvegVb8pPs=; b=GH6c+rgnGWTWGzWDWj9dDKTeakif9Xh40XVkrqGY1ijYjhe5bbkLmY+BN5prjvZuAR 85GSptwm5i1DsmPdBz9mPNUZ0XlRc8ennS6ROm/EEVbwT8O5WO3LymCkpVs3XtJ/urYm ciwJDB31cHSv+Wbbh/zWWSZJlFPktBANZcPe4WwSytvBEv5GzZuHsDVDvUWSXlm/YVbX WX2J/2Phxn1mFNQpTbxtNTh5SooxPiKS5ofM3VjRk/9d7340znwvyHOpt7jwzrXopmYo ix1wX5xxhuVWO0p0mOXUWhoWyrVWpBKKXOYUG2lk0brCUPeM1jyLDKYhgYGzAAi/b7q9 9cQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724923574; x=1725528374; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:in-reply-to :from:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:x-beenthere:x-gm-message-state:sender :from:to:cc:subject:date:message-id:reply-to; bh=Fe9oQTHww4Rxv5s3j/8TsioRTsymXGoqblvegVb8pPs=; b=svZqTfdLahG804Yxzm3ZhEfWO0Nz/DfOfcfeULKerB0jN5ySO/kL8DTi8+b8zIYXmo bjiquRRS/nhh8h2H6gDOiHyYtd/Uddv+GBiWCJ7GSRxWmCPWHsMbBsR3Af5sBEqzaVeI XeaOOAl5/VLYGeYCwQjHGoOUxB+dsPunlm2xC7OYXmfAeYFU7Wonl8U890O3aW+CM5tn GDuZiqNdsHXbFrGKtDkxbTkSoAllKxFGSXVuhKRkjslNAkoSRlLhXIy5Mrraua7BWDP1 JGwUsAJ3lKNzesa6ToVv/77gdDCEgwPybBcbQ5KCOoibRmxhez0ze2eukb5p2WPYdav4 6/eg== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCWpz5Uw2/WTaLBEsGknKK2K+uYewQIJdp/9+gFSks/2g0fn3Jst4XoL7gKe9wo5lnrvgI/h@ilbers.de X-Gm-Message-State: AOJu0YzAlD92A4iqBWrjdx1HG694h4obLlch1g3oPtZqB4Jt4DhqERbT Va8rUMH3PozbP9whEoUX4/9efzD9QZKIxqXvI4N+x/QrG+/6+4+X X-Google-Smtp-Source: AGHT+IF4DSxaWypTC4+NOgo9hJ5XSAi6tbclmav0LZ54hmHerV8IycQRFyYNWz7DdhZEtr1T4AAcWQ== X-Received: by 2002:a2e:802:0:b0:2f3:f6ab:9513 with SMTP id 38308e7fff4ca-2f61054aaebmr17692941fa.44.1724923573081; Thu, 29 Aug 2024 02:26:13 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:2ac2:0:b0:2f3:f9d5:8c72 with SMTP id 38308e7fff4ca-2f6108a7161ls3120941fa.0.-pod-prod-08-eu; Thu, 29 Aug 2024 02:26:11 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVHNKjzvHXlU0Goqads9nfQOnCau+fJ24r3lvh0Kh//dtVFL5XKZji3VOVlRgV2TB6hzcK+mMUrDTY9@googlegroups.com X-Received: by 2002:a05:651c:506:b0:2f3:a854:78f6 with SMTP id 38308e7fff4ca-2f6104f2907mr16887281fa.34.1724923570709; Thu, 29 Aug 2024 02:26:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1724923570; cv=none; d=google.com; s=arc-20240605; b=L/R8z8DInYQ0PQOP4BPpQBLAD3Na1GsL2Wy2VAocHOF9RFLIherLLjZ57DLQpZ8+Ib XpT599QeB6hptwyysR6qH7cVb8YNg9CYigrtqw8C+g+tFr1AEmDczDgzE+tf4BL+wn2b Tl0G0Dbtbn28l0O0gudhqyxCCn5HesWIHxSghprda2pRQ2q4w+PZKIGwXmKA9JI03ceS ZW6OtycjaUtsa9iikV6K8Mwuc8+to5w6fAebGVUFk5SCsGxGcVL8Xzf+LSlGHwcilOmg m7+2c+2Vib7Jh2tuz5lDc+75CISppOADGcpgkz9iCQiaMuqA3LPBVBwq5BsV368QMLX3 UtVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=8sJehuh7OLviC3VYq5wKHfyakPAPP61/29os4bYjoBY=; fh=GA3vjnx6porcsK9LKV/5zMG4rFTtxwidnkMc3/IU5Q8=; b=WBObcl7Q38AoIRUYEZynhC79dl5dZ7jIOoLzOEb/Kk1XLGzBR5gQkaEQoPArpBbSX5 1FtTxo/8D09E03dwjn7p6rqdmL1LXgUu/O71OwYKtM5NTob4Bl2q0zd7i+m8fnWhZI8D uaMMZEOxkMRjQW3gVv1MbDHPSyp2rgL1L+2/lvkbHgLkLdFSq2bJPG7b3SA6nfXCyYzu 3uscbOEaWsmUiv7tvV15bt7H4eHHGUIk7yvOPEAPG1LTVyaq1CLelffXLrAWn+mxE/92 gQ5+++mG+8ltLLZrLMsHyGqmAgxYpmdFxq4OSR0ZlwGOEvj/fNyXc5RH3d4UsnNeWdmF vcMg==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 4fb4d7f45d1cf-5c225cb9e22si24606a12.0.2024.08.29.02.26.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Aug 2024 02:26:10 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 47T9Q7gr001212 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Aug 2024 11:26:08 +0200 Message-ID: <9ecb2ac7-9abd-4782-8498-7c5216fc99ca@ilbers.de> Date: Thu, 29 Aug 2024 12:26:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] meta: Drop lazy and recursive unmounts To: Florian Bezdeka , isar-users@googlegroups.com Cc: Jan Kiszka , Baurzhan Ismagulov References: <20240619104126.105252-1-amikan@ilbers.de> Content-Language: en-US, ru-RU From: Anton Mikanovich In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: amikan@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: gMLF+AuSMBx1 28/08/2024 16:05, Florian Bezdeka wrote: > Hi all, > > I'm not 100% sure, but it seems I'm facing some problems with this > patch. I know about the situation that we sporadically saw some > mounting issues and that patch tries to expose such issues. > > At least my issue seems to reproduce to 100%... > > See below... > > On Wed, 2024-06-19 at 13:41 +0300, Anton Mikanovich wrote: >> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc >> index faf22a50..6bc667e7 100644 >> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc >> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc >> @@ -341,7 +341,7 @@ do_bootstrap() { >> echo "deb-src ${line}" >> "${ROOTFSDIR}/etc/apt/sources.list.d/base-apt.list" >> >> mkdir -p ${ROOTFSDIR}/base-apt >> - mount --bind ${REPO_BASE_DIR} ${ROOTFSDIR}/base-apt >> + mount -o bind,private "${REPO_BASE_DIR}" "${ROOTFSDIR}/base-apt" >> else >> install -v -m644 "${APTSRCS}" \ >> "${ROOTFSDIR}/etc/apt/sources.list.d/bootstrap.list" >> @@ -378,10 +378,10 @@ do_bootstrap() { >> >> # update APT >> mount -o bind,private /dev ${ROOTFSDIR}/dev > That means that we mount /dev from "the host" into the rootfs/chroot > environment, right? "Submounts included", no? > > I'm facing the following error with that. The isar build is executed > inside a container / pod running on a k8s cluster. > > Inside the container the following steps are executed: > > build-bookworm: > script: > - kas build > - sudo rm -rf build/tmp/work/debian-bookworm-amd64/buildchroot-target > > The rm command triggers the following errors: > > rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/shm': Device or resource busy > rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/termination-log': Device or resource busy > rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/mqueue': Device or resource busy > rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/pts': Device or resource busy > > My assumption is that isar is not cleaning up all mounts. I think the > interesting part is about /dev/termination-log. > That device is mounted into the pod by the k8s infrastructure. > > I think we should never mount that into the chroot, or make sure it is > properly unmounted again... > > Any thoughts on that? Any additional information needed? > > Florian Hello Florian, The line you are pointing to is inside isar-bootstrap preparations, while your error is pointing to busy mountpoints in sbuild-chroot, managed by rootfs.bbclass. Anyway private mount private mount does not forward or receive propagations. It means no external submounts will be mounted inside rootfs and no Isar mounts will be mounted to external /dev. Can you check which mountpoints are left after the build (before rm)? -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/9ecb2ac7-9abd-4782-8498-7c5216fc99ca%40ilbers.de.