From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6680759771290664960 X-Received: by 2002:aa7:da13:: with SMTP id r19mr6383147eds.204.1556117737283; Wed, 24 Apr 2019 07:55:37 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:1d47:: with SMTP id o7ls2767251ejh.0.gmail; Wed, 24 Apr 2019 07:55:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqwdvwerexAD6cRauMJfCITyHUyXZX/lsETIubpIt5AI9fmiZ1zrdUWr+WzDOyD0/4hwuYfd X-Received: by 2002:a17:906:bc2:: with SMTP id y2mr16554773ejg.98.1556117736803; Wed, 24 Apr 2019 07:55:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556117736; cv=none; d=google.com; s=arc-20160816; b=xAP5cXw48+NMYUSNHR3kDvf+5vgkoLZst0ntmGUD0IHU+EMtrgAIdI5GCHP7fjkonx 7ipUDoSa++gUxy7V9WFVq8heYsKHX+eUtwBTFBMV+YQymMQnKyStQEdDxUpejnX8jvSt 499JaDKeiBGTG2sORFKp6LFKnsXSF3eYDZRlth2KeKtkrMdWjfT60ttAeePoVtB4F+p0 ngsoTQxM7a6Zz4wcRe5h/yjOZoD/DRETZYcPMb48QkWw70EBCtztBmm/9Z9Ils4tZu3t i/MnvV/CI7R4nE0viMW8/vDpwzVrLZMiA/7IDdMeS4SFguKn4OP9ZLieYv87NJewY3G0 vIXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=RXVnBfl81vns4H6+ovZIiIL1mL/6GzG92TvFELi+Qig=; b=sD77ytai+fvVOErjD3hLg/kqH2qV0TOsLEvHXEfllRZtV8OREiSmJxRIHKRqV0h5r4 5REL/OEdOIJ28hH1Dm7YslVcJWQ6CXCGJsGfkS8MQ17ngQ1IdgDmd/5wQZ6AASJI628E m4OCKBM3w/RAHjSAqB6zxfs9KcHa5UpwAhCw+e8YHUAnH4YQQVof7Y81ajcmZBv/n2iW aojRyVCuJCFcIiOG9fVHPHNMupstvLPwpNsAEjCoSgLhkQgNgxpXyYx0UG3Xsn4BkdDW lqpSvleX1DL2N1LABUbWxO/hVAW93LiFGFpUhH5tyvnBcI+OV+dHnztZJphUoLFhtCm7 wcrQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id j5si809674ejm.1.2019.04.24.07.55.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Apr 2019 07:55:36 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x3OEtaJx016455 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 24 Apr 2019 16:55:36 +0200 Received: from [139.25.69.232] (linux-ses-ext02.ppmd.siemens.net [139.25.69.232]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x3OEtamH023941 for ; Wed, 24 Apr 2019 16:55:36 +0200 Subject: Re: [PATCH 0/6] pre-processing pipeline and transient package replacement To: isar-users@googlegroups.com References: <20190418112545.1201-1-claudius.heine.ext@siemens.com> <1732702c-ab31-eca1-e889-43ee78e67428@ilbers.de> <3899d35f-f79d-b459-caf0-ba04e87d18b6@siemens.com> <6b08e2b3-7b62-a312-e94a-239562191ac2@ilbers.de> <9d18a087-49c8-eaee-019c-83e33e643f1b@siemens.com> <20190424143809.GG21981@yssyq.m.ilbers.de> From: Claudius Heine Message-ID: <9ef21f4f-fc21-1908-0115-00a8660fd509@siemens.com> Date: Wed, 24 Apr 2019 16:55:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190424143809.GG21981@yssyq.m.ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: YxvuaRs1DamS Hi Baurzahn, On 24/04/2019 16.38, Baurzhan Ismagulov wrote: > On Wed, Apr 24, 2019 at 10:38:08AM +0200, Claudius Heine wrote: >> Well there are different kind of patchsets, some patchsets implement >> features and some just cleanup/refactor code. The latter ones might contain >> a number of small improvements all over the code base. They are related in a >> sense that they 'do' the same (refactoring/cleanup), not necessarily with >> the same code pieces. But they might work towards cleaning >> up/refactoring/preparing the code for a bigger feature or rework that comes >> later. >> >> So what you are saying that you would prefer instead of putting all those >> small refactoring changes together in one bigger patchset, that I should >> submit all those patches separate from each other? An then state that the >> feature/rework patchset depends on all of them? >> >> I think that will cause more work on every ones end (especially with the >> slow CI build), but if that is what needs to be done when contributing to >> Isar, I will look into reordering my patchsets accordingly and maybe write >> some scripts to automate this pipeline for myself. > > The current practice resulted from past discussions, in which amending patches > without reviewing again or applying series in part had been objected to. IIRC there were objections about reordering patches within one series, since they normally depend on each other and always describing those dependencies explicitly does not really make sense IMO. I would also object to modifying a patch content without making it clear first what the issue with it is. Fixing spelling or grammar mistakes is fine IMO, especially in commit messages, as long as it doesn't change the content itself to much. Just applying some cleanup and refactoring patches from a series in order, without applying the feature (if it contains one) or some other latter problematic patches is fine as well IMO. > I > haven't looked at the proposals in detail yet, but in general, if we can > improve the process to save overall effort, I'm for it. Well the first goal should be to improve the code. Therefore fixes, cleanup and refactoring patches, if they make sense, should be merged fast. For features, new dependencies or bigger/backward incompatible rework (UX changes), there should be a discussion etc. maybe with help of an RFC patch to demonstrate those ideas. Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de