Re: [PATCH v3 06/16] sdk: Add support for adding self-defined sdk packages

[Jan Kiszka <jan.kiszka@siemens.com>]

On 06.10.20 11:00, Baurzhan Ismagulov wrote:
> On Wed, Sep 30, 2020 at 09:19:15PM +0200, Jan Kiszka wrote:
>>> 1. I've tried the following:
>>>
>>>    . ./isar-init-build-env build
>>>    bitbake -c do_populate_sdk mc:qemuarm-buster:isar-image-base
>>>
>>>    When I look into tmp/deploy/images/qemuarm/sdk-debian-buster-armhf.tar.xz,
>>>    etc/apt/sources.list.d/isar-apt.list is not present. Am I missing anything?
>>
>> Was that with SDK_INCLUDE_ISAR_APT = "1"? It's opt-in now, see patch 9.
> 
> Yes, I forgot to mention that, sorry for the confusion. The commands I used,
> hopefully correct now:
> 
> . ./isar-init-build-env build
> echo 'SDK_INCLUDE_ISAR_APT = "1"' >>conf/local.conf
> echo 'ISAR_CROSS_COMPILE = "1"' >>conf/local.conf
> time bitbake -c do_populate_sdk mc:qemuarm-buster:isar-image-base
> cd tmp/deploy/images/qemuarm
> sudo tar Jxf sdk-debian-buster-armhf.tar.xz
> ls sdk-debian-buster-armhf/etc/apt/sources.list.d/isar-apt.list
> ls: cannot access 'sdk-debian-buster-armhf/etc/apt/sources.list.d/isar-apt.list': No such file or directory
> 

OK, need to check again. Cannot explain yet why that should happen,
given the change in patch 9. Maybe I have a regression further down the
series...

> 
>>> 2. The series still removes isar-apt description in p11.
>>
>> It's opt-in now, the common case for most users remains setting
>> SDK_INSTALL. We are only leaving the option to ship all the packages,
>> including all the useless ones, for special purposes.
> 
> I'm referring to the following hunk:
> 
> - - Check that cross toolchains are installed
> -
> -:~# dpkg -l | grep crossbuild-essential-armhf
> -ii  crossbuild-essential-armhf           12.3                   all          Informational list of cross-build-essential packages
> -
> - - Install needed prebuilt target packages.
> -
> -:~# apt-get update
> -:~# apt-get install libhello-dev:armhf
> -
> - - Check the contents of the installed target package
> -
> -:~# dpkg -L libhello-dev
> -/.
> -/usr
> -/usr/include
> -/usr/include/hello.h
> -/usr/lib
> -/usr/lib/arm-linux-gnueabihf
> -/usr/lib/arm-linux-gnueabihf/libhello.a
> -/usr/lib/arm-linux-gnueabihf/libhello.la
> -/usr/share
> -/usr/share/doc
> -/usr/share/doc/libhello-dev
> -/usr/share/doc/libhello-dev/changelog.gz
> -/usr/share/doc/libhello-dev/copyright
> -~#
> 
> This explains to the user how Debian multiarch works with option 2. This
> example works inside or outside of the chroot. We should not be removing
> documentation for a supported use case, thus NAK here.
> 

This hunk looks pointless to me. Why should the user try out all that
stuff? It's the duty of the SDK creator to do that upfront and ship a
properly working package.

Jan

> 
> 3. In 08/16: Suggest "conpilation" -> "compilation".
> 

Thanks, will fix.

But please comment inline, not out of context.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux