From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7243694205603676160 X-Received: by 2002:a05:6512:28a:b0:4f4:db63:23a0 with SMTP id j10-20020a056512028a00b004f4db6323a0mr9759093lfp.33.1686805635273; Wed, 14 Jun 2023 22:07:15 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:641d:0:b0:4f3:b4ba:1eb5 with SMTP id y29-20020a19641d000000b004f3b4ba1eb5ls822193lfb.1.-pod-prod-06-eu; Wed, 14 Jun 2023 22:07:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5P4mfnYPhijdnqv+QKiq1Kt925X5h1fHwaxanSDliFzhwpSCZ55IQOXZ5tcJzCY3OhCYBv X-Received: by 2002:a19:6415:0:b0:4f7:4170:a5c9 with SMTP id y21-20020a196415000000b004f74170a5c9mr5981012lfb.66.1686805633386; Wed, 14 Jun 2023 22:07:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1686805633; cv=pass; d=google.com; s=arc-20160816; b=xzLaJFKCvkncj2oiGAN+22VqHbven03+xn6oqEuzihREl1zCglXt5S4FxQWrN6tqLE 4sUebe5JDhxvIYDK7kpt+2t58OxGq2Dgi4fPHBW3TFhQ00fLV52tolgrxf8BmvvJcGRJ BgnCYgN6NdgZ2J8UjpN2iCvTRcnnoeM2CLYA3f9fKYjQCAsXIwA4QGtifjg1ODZqxx9d C0XgWGWBU+uMgr4ClGzjLfzv6s67GqPTGJRmPWuOL15C2oyKJYJMZCSWUzWrLRM6Il5C SZi5tvu7GZK9SUXPfcUwgH0IudSPbINNbDd1jLo6222P7QrApgfnlsBQxPrECPG11GlN Dvqg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=l3l0KhnB0NxbgQAe5e5KUBkOJOXZqycBeNB6Tdn4ZAU=; b=gyUMdg5U4N2EJgf7sEZoDt1BZDmgzu1nJwEoq7x38gSE87LUNAu5ry8nzW2YcMhp9b rvp3D4G9yA3zgRar/y/846UNfJZX1tfZ6LFoWnIpPNk+GX6JxGHJlbVnFcn9S4jG5+8x JLP1ynxmwt31/MTKJ/tnLFh8ZSPiqqtNuqrmbqLYJmnyG+Z5zstbEXHuDErw7Smu7x6t wdGHfTKXhhYeB5BdSGRwfqAZjXX3ZlIE9DPfwlKfYWmhCsxW7oolfhBWYTUydxNgAvzl kcvkdifoW8YTEfmrNFoMGO2O7QCxZLNLeSaPiWhRqAUWiSyS2olzljahuRXKCaDDpoVr 4K+A== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=ml5C9InY; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7d00::618 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20618.outbound.protection.outlook.com. [2a01:111:f400:7d00::618]) by gmr-mx.google.com with ESMTPS id i16-20020a056512341000b004f5128c1aebsi1051443lfr.2.2023.06.14.22.07.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Jun 2023 22:07:13 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7d00::618 as permitted sender) client-ip=2a01:111:f400:7d00::618; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=ml5C9InY; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7d00::618 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ClOdNd+1qIWmn9OHLG4Crmuuk4l0WwDen1Ps1Rfijd3aceQcv4UBsJRjUX+nnGwLioHTOn3Ze5vzXBxQTMF5fkE4HLgnqOK8L1JNmuSyUsDrVyFLG56htr7yGkwQLbohB9SW5h86Xy/kXD/kJiYlE+LlubnFXjrfG8QG/AHzjfK57EZg2CcqYbLm0Hw4UIY0uDNE8DpdU0BvcfDB5Llag3nRIYFVczPCIW4Q7Vljx62OaHLXmHIkXcPWphLPKJPnwGhRsgY6EarLh0sPvNz0mjRGuOWT92yYcciWeTjwmIHLy8H2tzdXVWcoQwUjM9SLAQgJqUmMbk/OcYlMEJB78g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l3l0KhnB0NxbgQAe5e5KUBkOJOXZqycBeNB6Tdn4ZAU=; b=MSkDAQWb4XIGTsPW+ID7g3MXhdOLJAU8aSi3GYlSU7ZDsz43EsVy3OHsa0HKp9kTX39fz6DQ55/p7lZyPDlceonif1e61Gxip5k6Y2rYgAIElTNR31ovxDRo8wtyztI8vZq21bdoFSsWRarQqZadbXX1J1/WIU9sTV+IGpPdqHF73tlGjrFrmFk2RBDVRsQd2x6LrzfvUWXtrRqq2WDfsi6G9sbpBRO+LQHt6BuyNX8Uo/E3OHMgNa7kc8oek7TqTV4lj87y5c+uHCB32f+EImelfnlxjEOIMHyUCi2+Q7piIY/J4OSPEihjNFDmdB4AtigX7t45oHUgxB8dO3xGKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l3l0KhnB0NxbgQAe5e5KUBkOJOXZqycBeNB6Tdn4ZAU=; b=ml5C9InYRXs5pK1ytCLN9aZ7hJJvI7h/QA8q2wo7SyYlIZU6PaMQhAIQHZv3nOUS7ZPzrQb9VllvfIHq7CEVLiDyiVViNMSqp2ECPF7alBpi3r7dm7wXsiwqnk8u5k9fyOdwxxqenPvSdPyQ+Uk4tokz/MS14Jzl8YxbYKWsxb4qgsYqpEOWsbm2HN8xF0H7JUZ8AVXn10caaodeGCZSYp6MqF5eDLx9oCvL46FrBN06nA/90lDrxUNSCy7K1qkZMLi0Vfscua0Dj/R0pcs1Yw6GcpH+eSkGKUi7CVlNLqvMG2pQ0sbd+6F9zxf8xa79LKtnUT1C52nb2sUdgXv/8A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by VI1PR10MB3278.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:137::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Thu, 15 Jun 2023 05:07:11 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::53c2:174a:8b13:ce94]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::53c2:174a:8b13:ce94%3]) with mapi id 15.20.6477.037; Thu, 15 Jun 2023 05:07:11 +0000 Message-ID: <9f692085-26e8-adde-b5a4-698b87052760@siemens.com> Date: Thu, 15 Jun 2023 07:07:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 08/10] meta-isar: Remove qemuamd64-sb settings from multiconfig Content-Language: en-US To: Uladzimir Bely , isar-users@googlegroups.com References: <20230612071256.8688-1-ubely@ilbers.de> <20230612071256.8688-9-ubely@ilbers.de> From: Jan Kiszka In-Reply-To: <20230612071256.8688-9-ubely@ilbers.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0088.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::13) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|VI1PR10MB3278:EE_ X-MS-Office365-Filtering-Correlation-Id: c7c2e9eb-afbf-4276-7bc6-08db6d5e604e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dC/qDiYEYncmPKPPKwJ1LDrbdq+DAIywW7KQcy0QCTTF1YjK3WeGR+U7D2IU++d/6nRH5GuwGh04bBnS9+KXA2UWcj1ket07a+S5C+bZvQBFoWq41XA0V00AqnQKnv47JPXnvKd2fP8jVnFDSW121A5nYSjvQJ2vSkFYg5hd31oElXi8nuFwv0DoYFIpXVX31oNwo4B54WfGKF4C0K2Sq8nhdDLrL0UTxJEcuaVfK4R/hcN1FMGhJd2WytIo2cxzKeoARLv9OIOnUynVP1bxIcCAN0MHHuL8/Z12cUTNK6a9fYwTx6ryGRJDVDyAl8DiG1jcL7bkhMtXkT92Bd8YaZx+ZG8UQMy1OjxcqYoZki7LfE27HFbKZ0wVCoRE+QeT1qnRGR0/B7AtAhsut+nb3vU/UcLSEy0/APVZIELZjWEzzq2aADkLsV/7QbQaPL2HjKjy8utXqxftGusDOEhefy++GXDXs2ctry7ZJwZvYA4iFh21d7f9AYG0wsOII64kqngq8AfbMLbPTTkMdvzxlsStyJLK+Cdp6peikMzAwAXXpTS+rRWfdd1uv4yvrWdbox/cq9XH0yqqvwLhmce0qSbRUCAN+d86PltGXJE4Y0w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(136003)(39860400002)(376002)(346002)(451199021)(44832011)(31686004)(5660300002)(2616005)(186003)(83380400001)(26005)(6512007)(6506007)(53546011)(2906002)(966005)(6486002)(8936002)(8676002)(41300700001)(6666004)(66946007)(36756003)(82960400001)(38100700002)(316002)(478600001)(66476007)(66556008)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ak5DWkJHZ0wwaXhQd3ExOEdnYjdKWEpzZFRtUW9aYjl6dnVJTHZ4SVZrc3Fr?= =?utf-8?B?eGhrZFBJZC9mdkd1amZmMENWalF5OEUycVlhQW03VUQ4b2Uxd2JVNjJDQzh6?= =?utf-8?B?YnJKV21CWVRMNi8rNVlnRkx5T0dwOUQvemRVQSsyL2MxaDdHLy9DN2EzNktm?= =?utf-8?B?WVpVY1dxM1pNeEdQMTN2QlF4NGZUTHIyRzBUNGZHYmNFY0NPQ0RqaCsvZmQ0?= =?utf-8?B?VkVLT1FaSDhFZnYxdnNjVzlwTTdqTEpKanJwVWllWGJXemZMNW5wWlJ1cFo3?= =?utf-8?B?anhQRVgxM0VCOUdGVktUYm8vMlVrNWFBcWI0L29KUHZFem5xVHIwZmxTYkFY?= =?utf-8?B?UUxjYkJxSTFaZ20zMFNmZ01hR1ZUQ2FVUzVJSzlaS2dUSm43cDAwQXoyKzB4?= =?utf-8?B?THJuYnhUUXoraDRkdEhEZHl5Y2N0enl0dHpvRmZnZHFOZFRzTE1RVi9MNHdT?= =?utf-8?B?ekJHVmtQbWczQ08xZW1jTmQ3RW1STFk3UFZRK0VWQ3FaOFZXKzlpMjlPcU9y?= =?utf-8?B?NHlXbUsxY29YNS83SlRTb2IvSUdSTGEyQk90NVdIZXZDNU5pcGMvMVBFejcy?= =?utf-8?B?U2lUcTIydjVpam1KRFVLY3RZSXF5emVPbFIzcU1oL0hKMk9SSXh0MXRYOHNz?= =?utf-8?B?STl2KzRUejJWM1pVZktxaU45ZUdqaVAybnJ4QWdubG02Z1ZFL2xHY0lHRUsz?= =?utf-8?B?WVdIWGtIRFh4a2Y4UG5iUGZjK0xycDFablQzQSswVEU2dXBObkQrdlN4V2Jw?= =?utf-8?B?aXUxUkNTS1BsVm4zZngvRjJ1MUdNcVcrV1N1RVJ1UGhLZGxuMjBhMlIyNEVh?= =?utf-8?B?dm94K2t3aGZYMjloWHpScFdCdTlXZDlVYTlmM2hSTmJUTStvUGFIbnpvd2xJ?= =?utf-8?B?UkFKZlY5c2dEbGpSVGtRQ3JERGEwbEhjbDZiaFBEeForNEdoTnhhR1o4RUE0?= =?utf-8?B?MEhWeDhiVmtqZHVDWkJ0TE9IRk1QVnhzbEluTXdLSDRGdndMTVcwNDc0aDlK?= =?utf-8?B?MHIyWk5JZ2NURitPMHdoVFc0RjM4UXkrWHA2bjltWm52alFTTkhaai9HaVo0?= =?utf-8?B?cDlLbjkzZmY3blF4QkxlUUJjVGQ2RzdEN0pBOUl6amxZenlmclRBeFo0anY0?= =?utf-8?B?NG5QcTgxMEVMbSthanoxT1dwbnVWUlBxeXFaSlZhYzRYbEdvQmpReVUrYXVz?= =?utf-8?B?Y1JNTWpOZUYzdzViR3NyVDRGRkhYOHVIYnNRWlZxTnZGZEVRdyt3WWkyQTRv?= =?utf-8?B?RStyYjNNUGhwNkhqdmNkUjRiQmtOdlFJZUxsR2RqeHhhRzMxNG5nQ3VWSUNh?= =?utf-8?B?ZzNWRVJKaEVoZmZZc2RvalFsVE9BeHBlRnlrOHNzV3ZqbWZEWmtRNStGNTll?= =?utf-8?B?MlFpQS83TkJIMmQvcXlaaW95UG80Mk1VTW5jSm05dk84ODExQ3hSZE51cTM2?= =?utf-8?B?NzcyWnFwOUVKaHZPOEpVR0dRdjcvYmZlNkFBVXFrRlBqa0tXWjZOSWx5VXhl?= =?utf-8?B?dVVPaVhxRXQwZ1Z1V045SFZ1aHorUVh6VjBZaHhUYlRTT3FtRktBL1hsRjVK?= =?utf-8?B?czFpOTQvN0FrU0VlYmp2VnBpTzB3ODhIdnkycjVVZWR3ZHBIK1dVQWE3RmFw?= =?utf-8?B?YndMV0ZUYysxUk14RDlOY1podEVoSjZiUWk2WkdqRGwrZi9STHREeGZuWXZy?= =?utf-8?B?QWVpVDZ6QlhOWjlXQ1VQZHdqeWVZNGxKMCt1cDFpdm1WcWRGVG9nMUdUVjNV?= =?utf-8?B?dkpMRnhGdnhUQmYwbjFGQ3UvcjFWT29SVDdCWklPSmdwYjlGYlB3THpqalNw?= =?utf-8?B?aElBWFRXMFMxaHlGZVlTSEdjRkRVblNwL3ptRndremQrMW5wYW44aVRDZEtY?= =?utf-8?B?SEJZK3RjMEJveUYyRXVmT1VYNHFWSDJZc2NmWm5vdlhwTkZkUEdaRDFOajVI?= =?utf-8?B?Y0gxanllUFFhYWxCMXFCeXZDTTFnSUNrMVdVbER0cjdPNkorQlNQOTR2MnJP?= =?utf-8?B?cGsydzFLQ2RQZjZ1Y05LVzkzTEM0dCtHYXM3WGRmek1JRTl5djhwZks2ZVBZ?= =?utf-8?B?bUtzaU1Eb3g0NTRldFhRSmh2RGczNXorOG9iK01idCtUakxTMlc3WDl5ZzB6?= =?utf-8?Q?vRd3QwjTzZ42o/xvqSeyrIXM/?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7c2e9eb-afbf-4276-7bc6-08db6d5e604e X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 05:07:11.4207 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w0AjNNL0U78ATMp6Tp3YilsoxC/3iWW9mo7yZSlCTj3thcod3qG+iTOkVx5hYeDaHVKr33IRGYsKxRb1+2eolQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB3278 X-TUID: fbnvpqFQSKqc On 12.06.23 09:12, Uladzimir Bely wrote: > From: Anton Mikanovich > > Machine-related configuration should be done in machine config, so move > it from multiconfig. > > Signed-off-by: Anton Mikanovich > Signed-off-by: Uladzimir Bely > --- > meta-isar/conf/machine/qemuamd64-sb.conf | 9 +++++++++ > meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf | 10 +--------- > 2 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/meta-isar/conf/machine/qemuamd64-sb.conf b/meta-isar/conf/machine/qemuamd64-sb.conf > index c581ab39..419db3b2 100644 > --- a/meta-isar/conf/machine/qemuamd64-sb.conf > +++ b/meta-isar/conf/machine/qemuamd64-sb.conf > @@ -9,6 +9,15 @@ IMAGE_FSTYPES ?= "wic" > WKS_FILE ?= "sdimage-efi-sb-debian" > IMAGER_INSTALL += "${GRUB_DEBIAN_SB_CHAIN}" > > +# include public keys > +IMAGE_INSTALL += "sb-mok-public" > +# include signed example module > +IMAGE_INSTALL += "example-module-signed-${KERNEL_NAME}" > + > +# add MOK utilities to insert MOK into EFI > +IMAGER_INSTALL += "${GRUB_DEBIAN_SB_MOK}" > +IMAGE_PREINSTALL += "mokutil" > + > IMAGE_INSTALL += "sshd-regen-keys" > > QEMU_ARCH ?= "x86_64" > diff --git a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf > index 19a105eb..85ce3a65 100644 > --- a/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf > +++ b/meta-isar/conf/multiconfig/qemuamd64-sb-bullseye.conf > @@ -1,12 +1,4 @@ > # This software is a part of ISAR. > + > MACHINE ?= "qemuamd64-sb" > DISTRO ?= "debian-bullseye" > - > -# include public keys > -IMAGE_INSTALL += "sb-mok-public" > -# include signed example module > -IMAGE_INSTALL += "example-module-signed-${KERNEL_NAME}" > - > -# add MOK utilities to insert MOK into EFI > -IMAGER_INSTALL += "${GRUB_DEBIAN_SB_MOK}" > -IMAGE_PREINSTALL += "mokutil" This is an anti-pattern when you want to allow reusing the machine configs outside of Isar testing scenarios, see also [1]. Jan [1] https://groups.google.com/d/msgid/isar-users/b37eca8a55e91777ec3fdb54c989326b54c0253f.1685895669.git.jan.kiszka%40siemens.com -- Siemens AG, Technology Competence Center Embedded Linux