Re: [PATCH v7] dpkg: Restore support for replacing pre-installed packages in sbuild-chroot

["'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>]

On 10.02.25 11:59, Anton Mikanovich wrote:
> 09/02/2025 11:19, Jan Kiszka wrote:
>> On 07.02.25 16:57, Anton Mikanovich wrote:
>>> Hello Jan,
>>>
>>> It looks like this change creates one more issue.
>>> Here are simple steps to reproduce:
>>>
>>> Prepare test recipe:
>>>
>>> $ cat meta-isar/recipes-app/hello/pcre2.bb
>>> inherit dpkg
>>>
>>> SRC_URI = "apt://pcre2"
>>>
>>> CHANGELOG_V = "<orig-version>+isar"
>>>
>>> do_prepare_build() {
>>>          deb_add_changelog
>>> }
>>>
>>> Go to kas shell (qemuamd64 bookworm):
>>>
>>> $ kas-container shell
>>>
>>> Perform those steps:
>>>
>>> builder@b5422048da4a:/build$ bitbake -c local_isarapt cowsay
>>> builder@b5422048da4a:/build$ bitbake -c build pcre2
>>> builder@b5422048da4a:/build$ bitbake -c cleansstate sbuild-chroot-target
>>> builder@b5422048da4a:/build$ bitbake -c build cowsay
>> The outcome is expected: local_isarapt is incorrectly run prior to
>> deploy_deb of pcre2. This won't happen during a normal build when cowsay
>> DEPENDS on pcre2, though, because of do_local_isarapt[deptask] =
>> "do_deploy_deb".
>>
>> Now, if you used ISAR_REBUILD_ESSENTIAL_PKGS in your actual scenario, we
>> do have problem because your patch 21a05608d85b forgot to adjust
>> meta/classes/essential.bbclass. I'll send a fix.
>>
>> Jan
>>
> After some testing with ISAR_REBUILD_ESSENTIAL_PKGS="pcre2" the issue is
> still
> there. Steps to reproduce (clean build inside kas,
> ISAR_REBUILD_ESSENTIAL_PKGS
> is set to "pcre2"):
> 
> builder@a1f979144422:/build$ bitbake -c build pcre2
> builder@a1f979144422:/build$ echo -e "\npython
> do_rootfs_install:append() {\n\n}" >> /work/meta/classes/rootfs.bbclass
> builder@a1f979144422:/build$ bitbake -c build pcre2
> 

Let me try. Maybe we have more regressions piled up since the patch was
merged.

> So the question is the same: which use case does your original commit
> suppose
> to fix?

A) the one from above
B) when you are rebuilding some non-essential package that happens to be
   in the sbuild-chroot already

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/9fa19809-92c6-4adb-93cc-2a307943c1bc%40siemens.com.