From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7057120643105423360 X-Received: by 2002:a37:9102:0:b0:5f1:8c87:1dda with SMTP id t2-20020a379102000000b005f18c871ddamr18888857qkd.37.1645624907865; Wed, 23 Feb 2022 06:01:47 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a37:b55:0:b0:476:45e7:cb49 with SMTP id 82-20020a370b55000000b0047645e7cb49ls10467756qkl.6.gmail; Wed, 23 Feb 2022 06:01:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJwXgnti6jxR1Urrcmr7kDm/ZEsHanuoAxZp2erAAaFE+TVvGvUCt67weJAUNQiRrANy8MTi X-Received: by 2002:a05:620a:1505:b0:4e0:e5d3:4074 with SMTP id i5-20020a05620a150500b004e0e5d34074mr18560319qkk.309.1645624906953; Wed, 23 Feb 2022 06:01:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1645624906; cv=pass; d=google.com; s=arc-20160816; b=a7oSwL7kiOXHU/NHNt5Y8HYHFgo1mBWM82e3PsdA0hdhbtmMNb+u/wK7i0E8XPACYp Z1ox7gedt7ZGEgsPcCeAIrBZiIVAmITlzLRFZZ265WfdV0ikzHh5bXBWC0al7cmRGA8J QDtbMMXSvsQFQJe/lWlYG56A9CjXkeshZpVBAgCDBbEh6MPH15zuqPzwDrpaQbBNwwB1 R9M6MwZn7GxIMefNdEBXJnf3X5+2m/qwMVOIXgsylAvcisTSdwjnM/1vpL9LnpZsTnsT AM1aE34mzy5XOvF809wO2Z7bREe0Ev6ZiwtyixVqs707HjRLixMVlEiGhQ8/C+Zu9UiI gi4Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=SlysslCvxpLpRrogWpP/ofBVMjrLVC+ZLJajQehJ+2s=; b=ztZp+LSeM0sh45K9CIjtsYwDf3LRFPl2oQ3y3oaaBUEibNsZwFOev1LL55VgkY9ooK iuudJ3PQrnMY2v1XoObORGOkGYfg3oJubgA3fFB8FJN3+hoaEYgxlUkKd++rUiHds7Ja oxeJeMfLf25NduE9ucXL/hX6ZVLiNUyB1O18FuMEMVM5XdnsKHIBOFFRoWoQyhe6is7i umsJM/bQHapGDDVYsg1h5PCI3tA08Zn94oSUYnmBu0eYFZUc32Zy5wWPLh+v201SELf2 p/GDuktQ0f8X8VWEIDLWThSP28Ru8etVQuVRan9XbgI0qpAAgi1El9SFfJBzj072oMJc sToQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=KLkYGk3W; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7d00::601 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20601.outbound.protection.outlook.com. [2a01:111:f400:7d00::601]) by gmr-mx.google.com with ESMTPS id 11si250488qkj.3.2022.02.23.06.01.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Feb 2022 06:01:46 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7d00::601 as permitted sender) client-ip=2a01:111:f400:7d00::601; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=KLkYGk3W; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7d00::601 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ISHoizXxXglMBrrp2bN3kTRJ75T+SLJbOVgn2lU/B1+gqpp5DYcdFn3fkkjRyPQjArtbgVQX/G8EyNSh8cM36IqTtBT54f0lyDTxx0HhVfmZE4XZqwF170iSJU8DUPR9FR5t8ccwjiSIKwo6O8oj9fmSlqhbUdFXZBaN3V9Z2/dlfowaWh1vsdpiQjRwAeimqx1MeFvu0E61AeojezdyVy6BiNrxwnIcVukNoqwk7UtbDM8S9N6SG4ZM7tNCBhow15tSXzk54s670OTqTA/zHEoYvNsO4xx6hzVHHcIc4KNuVdtCVu4jcSjUN/M7ioxMLhkb8YB+7GB1HRoI/KbeBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SlysslCvxpLpRrogWpP/ofBVMjrLVC+ZLJajQehJ+2s=; b=GfDv8VRdleWYfH9qm1MtAJIDuopaEVy28Kg6Xozs3ZElCiX+2Ls9H+F3z+dazkXRDqgG47XqwU78W4SOSEc8Zi1cHra4/5GzlTwyECueKp6kXWyFk/FQUw4mykSK8CbnTow6LrQl3KUtWU+embauclbhYl8T1IeW2sEAv3jsNvzcOPlvZv3CLAoaaGZCooG4YVpajNCAl6f8iNHxkSTNDeRl0dJcH7P6lIj7S/wVtdyGoYdpQ1e0/uh1u/3lHLayWmYrVkxn6OjpY16Z4uPrxQvZCjL9TpNayFJ1yNjeEOLNE8qxkJupaK4I3+KXA1xqfjyW21DPTDZanafseyG69g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.70) smtp.rcpttodomain=ilbers.de smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SlysslCvxpLpRrogWpP/ofBVMjrLVC+ZLJajQehJ+2s=; b=KLkYGk3WCcr27MaYQe8IPOKhsaX+F9jz5t5xrEdf4IDxHsc86p0NTFGLPDSjWSDVVM50lYuJBihUtTnyIlA4GuWPOLk7v4KbJrdZBsjfywPro0F3umtwcDQSG3EM5xkEfxEh3Cj7NEV5sA3AId6l1tSipYQl0VqRh6tp5Hg4XexuVNeTdsD2Mr+3k/b3atSDYT6wyaB+IYWt4KjLfFnO79GKzs9pJbTRkGXGKXGJl+A57NMns1lnYbzAjBizQaJSLnA+LDosDdteUvDWhnLVpPv7qWtOWiH2c/vmQXAh6UGKHEGulpekCoZhQgsrt0CxaMS6lVyLs/XxQ9deibp7UQ== Received: from DB8PR04CA0023.eurprd04.prod.outlook.com (2603:10a6:10:110::33) by DB7PR10MB2492.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:4d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Wed, 23 Feb 2022 14:01:44 +0000 Received: from DB5EUR01FT051.eop-EUR01.prod.protection.outlook.com (2603:10a6:10:110:cafe::12) by DB8PR04CA0023.outlook.office365.com (2603:10a6:10:110::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.23 via Frontend Transport; Wed, 23 Feb 2022 14:01:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.70) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.70 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.70; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.70) by DB5EUR01FT051.mail.protection.outlook.com (10.152.5.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5017.22 via Frontend Transport; Wed, 23 Feb 2022 14:01:44 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SJA.ad011.siemens.net (194.138.21.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Wed, 23 Feb 2022 15:01:44 +0100 Received: from [167.87.32.158] (167.87.32.158) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Wed, 23 Feb 2022 15:01:44 +0100 Message-ID: <9fdcdb0e-fee6-1c60-19a8-819f40c1059a@siemens.com> Date: Wed, 23 Feb 2022 15:01:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 6/9] optee-os-stm32mp15x: Do not use shell environment Content-Language: en-US To: Uladzimir Bely , References: <20220213074111.23232-1-ubely@ilbers.de> <20220213074111.23232-7-ubely@ilbers.de> <57982af9-8bf0-227e-a170-acad96eb6a26@siemens.com> <2574298.lGaqSPkdTl@home> From: Jan Kiszka In-Reply-To: <2574298.lGaqSPkdTl@home> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [167.87.32.158] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 987540ea-4cd4-4e20-1d1d-08d9f6d50692 X-MS-TrafficTypeDiagnostic: DB7PR10MB2492:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: voloZOMApU+4QrYEPWCOKvx/bGEawkQM3VhjuyUcuHwmcuyoHZQs9csl/oCOElqDhfW3V84y97Fvgnvn2MSzHbm+S/bs/ZtuiIiBx1dh60gCpjYC++5ypNt420JcTYsB0lI3LYj+HMSrivM8AnzYY+SpwIXkqIHXjkWmpuMoTNQgEuH2xOqd0qZC2cbye2kRiSV94TkSFLs9AkvgUaqmA5iFCStsc5hYMIhV71HZjzGlNnv8Z+jpbpHxUXqlwx5K2f/rUUjs2hQ7KRX4z+Szanx6S4oGrpGZHx4zFE5BnsNMKGux9VMzvC98rx8uV/V7Nq6Dm8VagRgOyETN9X6yV7TkeVEpJYjuiuUOwd75wXCXGWV7mHnYvqiX3+qh5ZUUfVnOSmwlnImzhHDWO6OokqzIY9JBCR2zwkT4TFNVIn3b4xaYhHGorF4z2nAjCbq4ZLlNH9P7IIeHc6iO8dHtQ+YkEjxkzgImmEJjMvR4siPgH01iwAvNQrMyysJGKrgEbLMqSR/iiLRR8eFSUTL82MqcDrCfNe2s04nRSqezTbjCBghplbdHjN87m9p9wfgWDtxP2EOX9afiwt4w6Bcm6Gy8W1UFZwHv8GWYc0gzjXgKyELBEXRCwofsXXc8N07inOC6/b1ZZeeIFcsszre3m+ocg9+ym4zDV171i1FvEeIwI18DGJdEk+QZFx37avWTvzwt1+zmupVVFhTIY9KmTXxCWNddJV2BZHc0GBgt2o+F4m9iPHioMVIzEAOVF1Z6 X-Forefront-Antispam-Report: CIP:194.138.21.70;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:hybrid.siemens.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(110136005)(6706004)(26005)(8936002)(8676002)(16526019)(5660300002)(70206006)(186003)(70586007)(336012)(83380400001)(7596003)(356005)(31696002)(7636003)(82310400004)(316002)(44832011)(16576012)(82960400001)(86362001)(47076005)(956004)(36860700001)(36756003)(2616005)(2906002)(40460700003)(53546011)(508600001)(31686004)(3940600001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 14:01:44.7560 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 987540ea-4cd4-4e20-1d1d-08d9f6d50692 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.70];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR01FT051.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR10MB2492 X-TUID: tEn7FO028O04 On 22.02.22 13:29, Uladzimir Bely wrote: > In the email from Tuesday, 22 February 2022 09:49:38 +03 user Jan Kiszka > wrote: >> On 13.02.22 08:41, Uladzimir Bely wrote: >>> Move export of TEE_IMPL_VERSION variable directly to debian/rules. >>> >>> This makes building process more Debian-like. >>> >>> Signed-off-by: Uladzimir Bely >>> --- >>> >>> meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb >>> b/meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb index >>> 0fa2005d..9c0efaf1 100644 >>> --- a/meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb >>> +++ b/meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb >>> @@ -21,5 +21,8 @@ OPTEE_BINARIES = "tee-header_v2.stm32 >>> tee-pageable_v2.stm32 tee-pager_v2.stm32"> >>> # Set version manually to PV, the tarball does not contain any hint. >>> # Alternative: pull from git and add git as build dependency. >>> dpkg_runbuild_prepend() { >>> >>> - export TEE_IMPL_VERSION=${PV} >>> + cat << EOF >> ${S}/debian/rules >>> + >>> +export TEE_IMPL_VERSION=${PV} >>> +EOF >>> >>> } >> >> I think I commented on this anti-pattern elsewhere already: This can >> lead to piled-up extra lines in the target file. Now that it's merged, >> please fix up on top, e.g. using a sed rule that avoids duplicate >> patching or appending to the unpack step. >> >> Please also check if you used it elsewhere in fix those spots accordingly. >> >> Jan > > I tried to see the problem with line duplicates you are talking about and I > couldn't reproduce it. Any way to invalidate do_build (recipe modification, > manual task invalidation by bitbake, etc) makes ${S} to be renewed, so "old" > lines are not presented here. So, this kind of export appears only once. > Generally, such artifacts come from unpack or patch, and every stand-along call of do_dpkg_build can cause such aggregation. But you are right, in this case the debian folder is copied in from clean source, and we do not see an aggregation. But we may see it if the underlying include once changes and uses a different way to feed in debian/. Jan -- Siemens AG, Technology Competence Center Embedded Linux