From: "Moessbauer, Felix" <felix.moessbauer@siemens.com>
To: Baurzhan Ismagulov <ibr@radix50.net>,
"henning.schild@siemens.com" <henning.schild@siemens.com>
Cc: "isar-users@googlegroups.com" <isar-users@googlegroups.com>,
"Schmidt, Adriaan" <adriaan.schmidt@siemens.com>,
"jan.kiszka@siemens.com" <jan.kiszka@siemens.com>
Subject: RE: [PATCH 1/1] RFC: Package perf from linux kernel tools
Date: Wed, 20 Jan 2021 15:23:18 +0000 [thread overview]
Message-ID: <AM0PR10MB1939687D1ABFBE66DAAB702689A20@AM0PR10MB1939.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210119163107.GW22444@yssyq.m.ilbers.de>
Hi,
today I implemented the packaging in the kernel recipe and fixed some
nasty aspects like exact version numbers in the patches.
I'll send this patch to the mailing list as well.
One issue is still that we need per-kernel patches.
If anything in the original makefile of perf changed, our patches do not apply.
That lead me to the initial approach with having a dedicated package with multiple recipes,
to have different patch-sets per kernel version (and put it into the responsibility of the user).
Another issue with the kernel-recipe approach is that it's no longer possible to use the Debian kernel but customize / fix the linux-perf-<version> package.
Maybe we need both.
@Schild, Henning (T RDA IOT SES-DE):
Having the Python stuff in a dedicated commit is definitely a good idea.
It's already in its own patchset. I'll send a v2 to the list as well.
Best regards,
Felix
> -----Original Message-----
> From: Baurzhan Ismagulov <ibr@radix50.net>
> Sent: Tuesday, January 19, 2021 5:31 PM
> To: Moessbauer, Felix (T RDA IOT SES-DE) <felix.moessbauer@siemens.com>
> Cc: isar-users@googlegroups.com; Schmidt, Adriaan (T RDA IOT SES-DE)
> <adriaan.schmidt@siemens.com>; Schild, Henning (T RDA IOT SES-DE)
> <henning.schild@siemens.com>; Kiszka, Jan (T RDA IOT)
> <jan.kiszka@siemens.com>
> Subject: Re: [PATCH 1/1] RFC: Package perf from linux kernel tools
>
> Hello Felix,
>
> On Tue, Jan 19, 2021 at 01:41:58PM +0100, Felix Moessbauer wrote:
> > This patch adds the linux-perf-4.19 package for a kernel that is build
> > with ISAR.
> > As the perf binaries have to be version specific, we patch the
> > corresponding files from the kernel tools source to incorporate the
> > major and minor version number.
> > These patches are copied over from the official debianization of perf
> > that is done in the src:linux package.
> > Additionally, we package the perf python bindings as well and provide
> > them as module "perf_4_19" (in the tools-perf-python.patch).
> >
> > As this debianization is not part of the kernel receipt, the perf
>
> Suggest "receipt" -> "recipe".
>
>
> > package can be based on a different patch version of the kernel.
> > While this might be intended, it is now the responibility of the user
> > to ensure that both the kernel and the linux-perf-<version> packages
> > are compatible.
> ...
> > .../linux-perf/files/tools-perf-install.patch | 58 +++++++++
> > .../linux-perf/files/tools-perf-python.patch | 55 ++++++++
> > .../linux-perf/files/tools-perf-version.patch | 119 ++++++++++++++++++
>
> The patches look common sense to me; ideally, it would be better to handle that
> in the kernel and have a single kernel source package. I wonder why Debian
> hasn't upstreamed that yet -- whether there were any technical problems, or just
> no one happened to look at that. That said, I personally could live with this till
> we have a better solution.
>
> If nothing works, maybe we could relax the goal of being able to build any given
> kernel version and experiment with conditional execution paths.
>
>
> With kind regards,
> Baurzhan.
next prev parent reply other threads:[~2021-01-20 15:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 12:41 [PATCH 0/1] " Felix Moessbauer
2021-01-19 12:41 ` [PATCH 1/1] " Felix Moessbauer
2021-01-19 16:31 ` Baurzhan Ismagulov
2021-01-20 15:23 ` Moessbauer, Felix [this message]
2021-01-20 15:26 ` Henning Schild
2021-01-21 10:52 ` [PATCH v2 0/2] " Felix Moessbauer
2021-01-21 11:56 ` Jan Kiszka
2021-01-21 15:00 ` Moessbauer, Felix
2021-01-21 16:35 ` Jan Kiszka
2021-02-09 8:58 ` Anton Mikanovich
2021-02-17 10:18 ` Baurzhan Ismagulov
2021-01-21 10:52 ` [PATCH 1/2] feat: package linux-perf-<version> in kernel recipe Felix Moessbauer
2021-02-17 10:28 ` Baurzhan Ismagulov
2021-02-18 8:01 ` Moessbauer, Felix
2021-02-18 8:28 ` Jan Kiszka
2021-04-22 9:52 ` Anton Mikanovich
2021-04-27 9:24 ` [RFC v2 0/2] " Felix Moessbauer
2021-04-27 9:24 ` [PATCH v2 1/2] RFC: Package perf from linux kernel tools Felix Moessbauer
2021-04-27 9:24 ` [PATCH v2 2/2] Add wrapper to load correct python perf module based on kernel Felix Moessbauer
2021-01-21 10:52 ` [PATCH 2/2] feat: add and package python bindings for perf Felix Moessbauer
2021-01-20 11:12 ` [PATCH 0/1] RFC: Package perf from linux kernel tools Henning Schild
2021-01-20 11:21 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR10MB1939687D1ABFBE66DAAB702689A20@AM0PR10MB1939.EURPRD10.PROD.OUTLOOK.COM \
--to=felix.moessbauer@siemens.com \
--cc=adriaan.schmidt@siemens.com \
--cc=henning.schild@siemens.com \
--cc=ibr@radix50.net \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox