public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Schmidt, Adriaan" <adriaan.schmidt@siemens.com>
To: "henning.schild@siemens.com" <henning.schild@siemens.com>,
	"Moessbauer, Felix" <felix.moessbauer@siemens.com>
Cc: "isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: RE: [PATCH v3 1/2] always invoke ISAR_RELEASE_CMD to invalidate downstream tasks on change
Date: Thu, 4 Nov 2021 11:50:50 +0000	[thread overview]
Message-ID: <AM4PR1001MB12201125592ACAF624E528F7ED8D9@AM4PR1001MB1220.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20211103191620.786b9a9c@md1za8fc.ad001.siemens.net>

Henning Schild, Mittwoch, 3. November 2021 19:16:
> Am Wed, 3 Nov 2021 15:09:56 +0100
> schrieb "Moessbauer, Felix (T RDA IOT SES-DE)"
> <felix.moessbauer@siemens.com>:
> 
> > Here, the deployed image contains the wrong tag.
> > When building with SState, even deleting the build/tmp folder does
> > not help as everything is already in the cache.
> 
> I know that case, where you build a second time for a tag ... That is a
> good example. While i would personally never build a release in a
> "rebuild" but always on a clean cache. BUT would expect a non-clean
> sstate cache to not cause harm.
> 
> To that point i guess we need a solution and it should be included in
> another round of the sstate series.
> If the solution is along the lines of this patch i would say that an
> API changelog entry will be needed, and maybe revisit the user manual
> what it has to say about the CMD.

I have tested this together with the sstate series, and I can confirm that the dependency on IMAGE_BUILD_ID is registered as expected, so in case the output of ISAR_RELEASE_CMD changes, the image will be rebuilt.

We could pull this into the sstate patches, but I think it's less confusing if we don't. And ideally merge this before the sstate series.

Adriaan


  reply	other threads:[~2021-11-04 11:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 12:36 [PATCH v3 0/2] Improve handling of ISAR_RELEASE_CMD Felix Moessbauer
2021-11-03 12:36 ` [PATCH v3 1/2] always invoke ISAR_RELEASE_CMD to invalidate downstream tasks on change Felix Moessbauer
2021-11-03 13:42   ` Henning Schild
2021-11-03 14:09     ` Moessbauer, Felix
2021-11-03 18:16       ` Henning Schild
2021-11-04 11:50         ` Schmidt, Adriaan [this message]
2021-11-03 12:36 ` [PATCH v3 2/2] Ensure generation of /etc/os-release is idempotent Felix Moessbauer
2021-11-03 13:46   ` Henning Schild
2021-11-03 18:20 ` [PATCH v3 0/2] Improve handling of ISAR_RELEASE_CMD Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM4PR1001MB12201125592ACAF624E528F7ED8D9@AM4PR1001MB1220.EURPRD10.PROD.OUTLOOK.COM \
    --to=adriaan.schmidt@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox