RE: [PATCH v2 03/10] rootfs: recursively depend on packages

["Schmidt, Adriaan" <adriaan.schmidt@siemens.com>]

> On 12.10.21 14:36, Adriaan Schmidt wrote:
> > This fixes a bug.
> > So far, this only worked when the dependency-of-dependency packages
> > were in isar-apt because they were just built. This explicitly
> > enforces do_deploy_deb on *all* dependencies.
> 
> More curiosity: I'm not yet understanding the error scenario. A rootfs
> depends on a package recipe A, and that means on the completion of that
> recipe's do_deploy_deb task. If that recipe A depends on another package
> recipe B that one needs to be in isar-apt, thus has to finish its
> do_deploy_deb as well. But why could A have finished its build when B didn't
> even run do_deploy_deb yet? If A depends on B, it also depends on B's
> do_deploy_deb task, no?

The rootfs depends on A's do_deploy_deb, but only A's do_prepare_build depends on B's do_deploy_deb.
If we can produce A (do_deploy_deb) from cache without running its do_prepare_build, then B might not be there (which is exactly what happened to me).

Thinking about it I'm wondering if the same thing can happen when building a package, and if actually also do_prepare_build in dpkg-base needs to define recrdeptask instead of its current `do_prepare_build[deptask] = "do_deploy_deb"`?

Adriaan

> 
> >
> > Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
> > ---
> >  meta/classes/rootfs.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
> > index f9151c5..bd8a241 100644
> > --- a/meta/classes/rootfs.bbclass
> > +++ b/meta/classes/rootfs.bbclass
> > @@ -152,7 +152,7 @@ rootfs_install_pkgs_install() {
> > do_rootfs_install[root_cleandirs] = "${ROOTFSDIR}"
> >  do_rootfs_install[vardeps] += "${ROOTFS_CONFIGURE_COMMAND}
> ${ROOTFS_INSTALL_COMMAND}"
> >  do_rootfs_install[depends] = "isar-bootstrap-${@'target' if
> d.getVar('ROOTFS_ARCH') == d.getVar('DISTRO_ARCH') else 'host'}:do_build"
> > -do_rootfs_install[deptask] = "do_deploy_deb"
> > +do_rootfs_install[recrdeptask] = "do_deploy_deb"
> >  python do_rootfs_install() {
> >      configure_cmds = (d.getVar("ROOTFS_CONFIGURE_COMMAND", True) or
> "").split()
> >      install_cmds = (d.getVar("ROOTFS_INSTALL_COMMAND", True) or
> > "").split()
> >
> 
> --
> Siemens AG, T RDA IOT
> Corporate Competence Center Embedded Linux