From: "Schmidt, Adriaan" <adriaan.schmidt@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>,
"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: RE: [PATCH v2 08/10] sstate: add caching to isar-bootstrap
Date: Tue, 19 Oct 2021 08:11:22 +0000 [thread overview]
Message-ID: <AM4PR1001MB1220759495D81C4BEAD54A78EDBD9@AM4PR1001MB1220.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <154a80a5-97c4-c17d-7ca0-462ae0f73315@ilbers.de>
> -----Original Message-----
> From: isar-users@googlegroups.com <isar-users@googlegroups.com> On Behalf Of
> Anton Mikanovich
> Sent: Mittwoch, 13. Oktober 2021 16:17
> To: isar-users@googlegroups.com
> Subject: Re: [PATCH v2 08/10] sstate: add caching to isar-bootstrap
>
> On 12.10.21 15:36, Adriaan Schmidt wrote:
> > Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
> > ---
> > .../isar-bootstrap/isar-bootstrap.inc | 39 +++++++++++++++----
> > 1 file changed, 31 insertions(+), 8 deletions(-)
> >
> > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> > index b8af676..a1cdf19 100644
> > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> > @@ -263,14 +263,6 @@ def get_host_release():
> > rel = platform.release()
> > return rel
> >
> > -do_bootstrap[vardeps] += " \
> > - DISTRO_APT_PREMIRRORS \
> > - ISAR_ENABLE_COMPAT_ARCH \
> > - ${DISTRO_VARS_PREFIX}DISTRO_APT_SOURCES \
> > - "
> > -do_bootstrap[dirs] = "${DEPLOY_DIR_BOOTSTRAP}"
> > -do_bootstrap[depends] = "base-apt:do_cache isar-apt:do_cache_config"
> > -
> > do_bootstrap() {
> > if [ "${ISAR_ENABLE_COMPAT_ARCH}" = "1" ]; then
> > if [ -z "${COMPAT_DISTRO_ARCH}" ]; then @@ -398,6 +390,37 @@
> > EOSUDO
> > }
> >
> > addtask bootstrap before do_build after do_generate_keyrings
> > +do_bootstrap[vardeps] += " \
> > + DISTRO_APT_PREMIRRORS \
> > + ISAR_ENABLE_COMPAT_ARCH \
> > + ${DISTRO_VARS_PREFIX}DISTRO_APT_SOURCES \
> > + "
> > +do_bootstrap[dirs] = "${DEPLOY_DIR_BOOTSTRAP}"
> > +do_bootstrap[depends] = "base-apt:do_cache isar-apt:do_cache_config"
> > +
> > +SSTATETASKS += "do_bootstrap"
> > +BOOTSTRAP_SSTATE = "${WORKDIR}/bootstrap-sstate"
> > +do_bootstrap[dirs] += "${BOOTSTRAP_SSTATE}"
> > +do_bootstrap[cleandirs] += "${BOOTSTRAP_SSTATE}"
> > +do_bootstrap[sstate-plaindirs] = "${BOOTSTRAP_SSTATE}"
> > +do_bootstrap[sstate-interceptfuncs] = "bootstrap_sstate_prepare"
> > +
> > +bootstrap_sstate_prepare() {
> > + sudo tar -C $(dirname "${ROOTFSDIR}") -cpf
> > +${BOOTSTRAP_SSTATE}/bootstrap.tar --one-file-system $(basename
> > +"${ROOTFSDIR}") }
> > +
> > +bootstrap_sstate_finalize() {
> > + sudo tar -C $(dirname "${ROOTFSDIR}") -xpf
> ${BOOTSTRAP_SSTATE}/bootstrap.tar
> > + sudo ln -Tfsr "${ROOTFSDIR}" "${DEPLOY_ISAR_BOOTSTRAP}"
> > +}
> > +
> > +python do_bootstrap_setscene() {
> > + sstate_setscene(d)
> > + bb.build.exec_func('bootstrap_sstate_finalize', d) }
> > +
> > +addtask do_bootstrap_setscene
> > +do_bootstrap_setscene[dirs] = "${DEPLOY_DIR_BOOTSTRAP}"
> >
> > CLEANFUNCS = "clean_deploy"
> > clean_deploy() {
>
> I think it's better not to move existing flags for do_bootstrap to have clear
> git history.
You are right. Changing for V3.
Adriaan
next prev parent reply other threads:[~2021-10-19 8:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 12:36 [PATCH v2 00/10] Add sstate-cache Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 01/10] oe imports in central location Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 02/10] wic-img: create deploy dir Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 03/10] rootfs: recursively depend on packages Adriaan Schmidt
2021-10-13 14:29 ` Jan Kiszka
2021-10-13 14:43 ` Schmidt, Adriaan
2021-10-13 15:09 ` Jan Kiszka
2021-10-13 15:18 ` Schmidt, Adriaan
2021-10-13 16:01 ` Jan Kiszka
2021-10-19 8:10 ` Schmidt, Adriaan
2021-10-12 12:36 ` [PATCH v2 04/10] base: remove unneeded "before do_build" task dependencies Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 05/10] dpkg: add explicit dependency to isar-apt Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 06/10] meta: add sstate feature from oe Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 07/10] sstate: configure Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 08/10] sstate: add caching to isar-bootstrap Adriaan Schmidt
2021-10-13 14:17 ` Anton Mikanovich
2021-10-19 8:11 ` Schmidt, Adriaan [this message]
2021-10-12 12:36 ` [PATCH v2 09/10] sstate: add caching to rootfs Adriaan Schmidt
2021-10-12 12:36 ` [PATCH v2 10/10] sstate: add caching to debian packages Adriaan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR1001MB1220759495D81C4BEAD54A78EDBD9@AM4PR1001MB1220.EURPRD10.PROD.OUTLOOK.COM \
--to=adriaan.schmidt@siemens.com \
--cc=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox