do_adjust_git in dpkg-base.class

do_adjust_git in dpkg-base.class

[Lisicki, Raphael]

Hello everybody,

the function do_adjust_git in dpkg-base.class breaks git for all operations outside of the buildchroot. E.g. it is not possible to use git in a prepare_build command, as it is not yet done in the buildchroot, but the git adjustment has already been done.
I would suggest to move the call to do_adjust_git into dpkg_do_mounts and maybe even undo it afterwards, so that targets that run after build can also have access to a working git repo.

Best regards
Raphael Lisicki

Re: do_adjust_git in dpkg-base.class

[Jan Kiszka]

On 07.02.19 14:03, [ext] Lisicki, Raphael wrote:
> Hello everybody,
> 
> the function do_adjust_git in dpkg-base.class breaks git for all operations outside of the buildchroot. E.g. it is not possible to use git in a prepare_build command, as it is not yet done in the buildchroot, but the git adjustment has already been done.
> I would suggest to move the call to do_adjust_git into dpkg_do_mounts and maybe even undo it afterwards, so that targets that run after build can also have access to a working git repo.

Moving it earlier should probably be fine. But undoing after some step can cause 
troubles when your rebuild your target and do not restart the task that applies 
the adjustment.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: do_adjust_git in dpkg-base.class

[Henning Schild]

I never was a fan of that messing with git step. Unfortunately my patch
against bitbake was never merged, one that would use true clones and
eliminate the problem with the "link".

At the moment you have to live with that. Maybe we can find a way of
patching the git argv from within the fetcher implementation of Isar.

Henning

Am Thu, 7 Feb 2019 13:03:58 +0000
schrieb "[ext] Lisicki, Raphael" <raphael.lisicki@siemens.com>:

> Hello everybody,
> 
> the function do_adjust_git in dpkg-base.class breaks git for all
> operations outside of the buildchroot. E.g. it is not possible to use
> git in a prepare_build command, as it is not yet done in the
> buildchroot, but the git adjustment has already been done. I would
> suggest to move the call to do_adjust_git into dpkg_do_mounts and
> maybe even undo it afterwards, so that targets that run after build
> can also have access to a working git repo.
> 
> Best regards
> Raphael Lisicki
> 

Re: do_adjust_git in dpkg-base.class

[Henning Schild]

Am Thu, 7 Feb 2019 13:03:58 +0000
schrieb "[ext] Lisicki, Raphael" <raphael.lisicki@siemens.com>:

> Hello everybody,
> 
> the function do_adjust_git in dpkg-base.class breaks git for all
> operations outside of the buildchroot. E.g. it is not possible to use
> git in a prepare_build command, as it is not yet done in the
> buildchroot, but the git adjustment has already been done. I would
> suggest to move the call to do_adjust_git into dpkg_do_mounts and
> maybe even undo it afterwards, so that targets that run after build
> can also have access to a working git repo.

Even if the patching was done later, you would see the same problem in
the first rebuild. Since the patching does not get undone.

If you need to use git you can enter the buildchroot and call it with
"mount; sudo chroot -E ..." ... the repeating pattern. Or you might get
away with "git -C somewhere/in/dldir" ... hack, or "git clone
file://somewhere/in/dldir ${WORKDIR}/git_host". Now thinking about that
we might enable adjust_git to keep a host copy for you, if you ask
for it ... somehow. Or you write your own _prepend it with "cp -r git
git_host" ;).

Henning

> Best regards
> Raphael Lisicki
>