From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7108629846932062208 X-Received: by 2002:a05:600c:524b:b0:3b4:8c0c:f3b6 with SMTP id fc11-20020a05600c524b00b003b48c0cf3b6mr21340158wmb.50.1664171866926; Sun, 25 Sep 2022 22:57:46 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:255:b0:228:a25b:134a with SMTP id m21-20020a056000025500b00228a25b134als10600098wrz.0.-pod-prod-gmail; Sun, 25 Sep 2022 22:57:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM673yISUb7xLDmVgtsjtqYE/EXjz1NXKSOJffPI1WSrMi8HhdTvdpkynoF1gpeZHqQj3gyD X-Received: by 2002:a5d:5887:0:b0:22b:1255:42e5 with SMTP id n7-20020a5d5887000000b0022b125542e5mr12605243wrf.114.1664171865484; Sun, 25 Sep 2022 22:57:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1664171865; cv=pass; d=google.com; s=arc-20160816; b=PIDmegBPHLv4+dF2Zlp7e1ECKNFSHbO0ALxGSeqDh2UATG4C66E+ka7R0vPY3BMTEi NWT7BFxQEH/jQyPsfAUNbmPczGaAJ/Zf4zEiwBT4fcQKO6RofCNlOqwXj+TM5E2TQj/3 QqdnEc2ky5X1ivoAgbzt9uVHRJJiFdTcpzzbK4GlOlqI5S5LGmtN1v32hvJN6wSL93ZX 9w738UC6IR43P+c7Sa5aa1YBqVdZHZd5nKEY1SCn+1o/ZpWil+Fb0YHNPTERE3A4KF03 hEG85WYyMIDYRdcVgQJBNVUwl60S2Z/W676m60aOp75Izv5rp/F580IEEQaR21MRikee NEHA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:document_confidentiality :msip_labels:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=t3Wwux1uz1FpJpanTGD/qMFxL3bbCgFvyimqpAlYOy0=; b=CzByLp08mklLHRJVKGF6AW74ILgiXixXfzfI2qKOpStNyGejMT6RK7qn+9Zrng3iTV ggs6J05fSNbsT0sQSyJl5ozTK5EC15OdH/wXpHpTmE+mWY0/cwWVpbnkzegkyz3cZPZv 1/pDOx6Jb+IHlauJ1eSmfVTWAdv8OWDcjW7oM/SmooGJdT7nzV2q0o+hTZ9b036Oc/EK Ihpk6FAQn9QZF7pfjV3XzBl7BE050xJliMC3UyDGcQKmcbn1P8TaF1iEQ1mh3XR7WLOh wn/cjANmWzVrt7hXh0+cJ1WWGulIFXQoQIoYKstLN3HK07Q0FeAUil0IdZOG4KUjgs5r DthQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=EDTazwUQ; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.21.86 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2086.outbound.protection.outlook.com. [40.107.21.86]) by gmr-mx.google.com with ESMTPS id ck5-20020a5d5e85000000b0022a48262c0bsi386126wrb.2.2022.09.25.22.57.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Sep 2022 22:57:45 -0700 (PDT) Received-SPF: pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.21.86 as permitted sender) client-ip=40.107.21.86; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=EDTazwUQ; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.21.86 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QidZ2aplz5lL6QqYDnYLpx5Pf4XK0rxKHUoc8cL2JsNQqdPAD28e43KmWNpvQS+YHAnHtmUScenyI5DR7I3f+LdT3dGuOz8NgYG1vhHPdTHkK2A+jojco3XQ2NA12qUGbr/O9D50907yzV37WcrqA378HI+Dn+VOqj/hjM1IiZC35E6YOY+5rqBRQVg7P/vfmVx6LuzbCWthfDnNFRvkCOAo0drvbgxnTsZGGGmc3gyInp6nKnU9wYDWpmdyQCjhfcBMf+xRCvMeRi9++hVWUsaSz7RZy4GculhVzXbL12bTq2tb6LN1kuBK//S2H3RVK9xiqAgL/OSsXDhzC+uz0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t3Wwux1uz1FpJpanTGD/qMFxL3bbCgFvyimqpAlYOy0=; b=mrtopy+C9UJ+81qqF93FgGIC77IZYF/ylw2+roaNwSxz+1CT13Bi+jsrM7MoQHWUSybHuOqGtOCdE+GLgkC0rQ6DVyH8s5t5u3DaEJv0o3MN3U55uVfAPaWodif95fJv8NRlNBE04vNKe6Bjt7Mk+PRvEQ7FP9yrN+8RNHobYjpVvuo8DUHHFdMVp6L7s7QPq6g3kE24HSn4VE3Bwkyj0NzX2tGecPRpxybOWrhg0qCxAVxnCJMoFZpqsUO8q+toGMmFScVqCNRCKJRKoyW5xNunm+atZ99ECvGNp66bkFqpBlY3EpqRhGFZ8ikczcti/bF/mYgi68NO40ISmi7Wlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t3Wwux1uz1FpJpanTGD/qMFxL3bbCgFvyimqpAlYOy0=; b=EDTazwUQDQtaO/ircJHVF+RIfu0a1mjc5ZGjKkPHC+fiQ3xG6P1Agg5IfVIUBtkYleKtcx/eEVbLte2VerGxMcugVg1HqIqsKGGO9Ia1jZTBT/SoORQCyUYVPgSIGJXKbaHAKJnrENrATUFdLPiQv6yjkkfVTwouEQjZju6os3M7A9C4pDNv+rK4sVDI9frSdAnAPF8RCEKHvAqqTcCeaf9FlASdz8B7cKgXThJ40NIPs8hQtyosp8BKgEDrbiINxfVZJJAsqtrXfzNk2l5c7cSiT5E3mLizm/H+wCRc1nPTuIw+XTBT+fxnSJvOsPp1XCiPgbLe6sAGmTjZPQ9ohg== Received: from AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:418::19) by AS2PR10MB7249.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:60a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 05:57:41 +0000 Received: from AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM ([fe80::c4af:eadd:4808:738d]) by AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM ([fe80::c4af:eadd:4808:738d%7]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 05:57:41 +0000 From: "Moessbauer, Felix" To: "Kanagarajan, Vijaikumar" , "Schild, Henning" , "jan.kiszka@siemens.com" CC: "isar-users@googlegroups.com" Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision Thread-Topic: [PATCH v2 2/2] wic: Update to the latest revision Thread-Index: AQHYfvrQK6SOklEV50OiVPoB2xycY61Nf+UA//+ObwCABg6wgICdCxAQgAGhwgCAAAxtAA== Date: Mon, 26 Sep 2022 05:57:41 +0000 Message-ID: References: <20220613075401.2059119-1-Vijaikumar_Kanagarajan@mentor.com> <20220613075401.2059119-3-Vijaikumar_Kanagarajan@mentor.com> <20220613110206.0fa05e12@md1za8fc.ad001.siemens.net> <476c6e8a8687499a85fced0e07299815@mentor.com> <8babb01d7eae44e0b9faecad59cdc1d4@mentor.com> <6157334379c44f8b938983d5c4dfd8b1@mentor.com> In-Reply-To: <6157334379c44f8b938983d5c4dfd8b1@mentor.com> Accept-Language: en-US Content-Language: de-DE X-Mentions: jan.kiszka@siemens.com X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Enabled=true; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_SetDate=2022-09-26T05:57:37Z; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Method=Standard; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Name=restricted; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_ActionId=f3afea29-d3bd-47f4-8f42-9364a3e5cf77; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_ContentBits=0 document_confidentiality: Restricted authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM9PR10MB4869:EE_|AS2PR10MB7249:EE_ x-ms-office365-filtering-correlation-id: 6f32adc7-4132-4e23-9fde-08da9f840654 x-ld-processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cb5fbRbA0NxWdG3pcFGOhf1NHBuobj7FwBdaV2UUj/qsy47SARf0U14L4LSwCw2xtL4Q+Ayx1J9dYJew83mheJ4XX/rbMqBGzXJ41OV0KB9rYIYyxOIepNRMAhzZdLLUnHS1vNUjz8VNAWw4bhgrqLCqeK2u7VQSzeC0cWbBIrgaShrF/Z3PQjIWYlePUSqBy8DNkOdGh5CbjJpl+S38b4qw2BRsOiiYvBpK0HwuVhFPDrPucp3kpeEUvqY3RMzphSmMlhXYFG3D21JUxAsEqGaodP+Gozo1TIArcdbPmJdxd72/HFupGl4TuCOA0Nq8yBtaTPVL2myeO/FQBB9zg5z6Le0bbiMz/+8PS6SvqrJgAI1Cf4sQ5DTyyzqtpMehklf4z2mrTznQh36Nr64tlhuGk0QCGl4t7CKt82ag+VqFBnqNzxQLhzTBeg6l1Whdv2b8eqgVpOYKMsR5k48xCgYm2a/gvtaKtOV3X+FwIemgmI4yv2ynVl4tch4dVAslI2EXbor1EHQnsLX3ZsL3rJNBgEehc65Zq+qJIbg5ZICdHrcH3R4UWQsEsvwt7dA7XyUngsyd4dh1YNpUQIg4f8UNCMP3f3O2xezqIgArhgRlGqYBz4msDzZlavckjUle9qBgYLiynyHia7c97vphcudgE9WHMu3CbGG/dy+PfC9vNpkbZOOkZJi6A//Vc/mB16pbrS42hbBVJDM/gd4R8EQD0vPqG7rXpUI/PS1mlsHjAtr5x74tEe6KQDIG4ktYMJc8cJb0Qu8CDTKhCYXujwmA3Kyf0Y+Ke2wFSSnVZwg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(396003)(366004)(136003)(451199015)(53546011)(9686003)(30864003)(26005)(5660300002)(33656002)(8936002)(2906002)(38070700005)(15650500001)(66556008)(66946007)(76116006)(66446008)(64756008)(66476007)(4326008)(8676002)(7696005)(6506007)(52536014)(41300700001)(122000001)(38100700002)(86362001)(55016003)(186003)(82960400001)(966005)(316002)(6636002)(71200400001)(110136005)(83380400001)(478600001)(45080400002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xRpOcXqGGMPDTfOt0q2pDaJT5Hu4OUA0MbOTY3fHBDU9cCjuLKE+IUe87hUq?= =?us-ascii?Q?VeHyevd/gYXV60atTfwqNcOAh/CW8Ye5LzzhP1Wxm+nZCdAZj+rWxQVLhAZF?= =?us-ascii?Q?xXuopvZL40FQZWGtmpuSCzZXOKNHY+nm8zEIcul1cDnSjK5g0LmkAHsLLxMI?= =?us-ascii?Q?H4DJVFjJVBIZlZsMhp5jJpEw9QUQm7NEBkdePN9jpY9jEvhGJRbmpsIFDPv5?= =?us-ascii?Q?yndOTFKsyDf3mYLyeDYANbGJzZc+xQLeKKg6JBEZ48km496MbpTfRL8k8SHg?= =?us-ascii?Q?PLCtGvF6U5qasQw88OsC57XtLpjz9AotKGRMFMq8YEMuIrzocdddIUccoqTz?= =?us-ascii?Q?o9nzY1/ilhYrd48o8+c++84WzM6FNrlLciHAQce+2C6AMB2IQi3MC0ORlW0D?= =?us-ascii?Q?/pCl/dUZUni06IF1UYnAicfh452oRQadw0cw95XkMUFPoSRsedCE/HhAY7k/?= =?us-ascii?Q?I/cZ4UcivVjFSjLugsah+9khJdL2QAnt7s8ZJz4I1ivVbFhoXZzmMB2NHWSs?= =?us-ascii?Q?VdeRcupKPVacI8L3UXoCEOpK8+Yr0BxLVvSOuFQuQG3vEv1x55UfWkhrEOWx?= =?us-ascii?Q?mMqxeFGnzqgkdI4W1f+L7kxzZVOwPPaKMeqmhcrG8q/wDTQYGXLEtAM0hsLc?= =?us-ascii?Q?/VdVn0Eb7mBwT+qejxjUY+LoZrPG1mRLbqyiTFL8L6OjtyK2OnlDpM5IOUBl?= =?us-ascii?Q?Syvmx/2KkdwtzJ9f1CSWb2RvksO5+n9MjeakTtNsm/YK38Ieg/fBiQN4r1Ma?= =?us-ascii?Q?SuNcdZoOqpKe2KeQzRKevG5RcxpNEMI6SdLHPHPvqYBCtR9+nfw7J+utycux?= =?us-ascii?Q?bZpMhyZ3fAlv3mth0IxArlRoM2j6ji0gpu9rC1RiDc7DywIXefzLYU/VAzZg?= =?us-ascii?Q?7adYOP6MpEV6dANc/A2FzV3vqHaZnzhFf2XDuXR9if46M5wIWplidYTFp5io?= =?us-ascii?Q?OzFARm2xHq6NR/h0utg8CCafL2gg+W0fGYWAa8v0uAS7yzsJNi/qjNNqcDEv?= =?us-ascii?Q?XRUbZixPgy7+buF7wcIbSbPGN34409P91ou+L+ShCovVXTM88GkFqomluOf8?= =?us-ascii?Q?7D7mlTlyhJv2It92+gvlXtmFd/DVH/WUCRFJk9lHeNbiQ1c63zkinRHgqowP?= =?us-ascii?Q?FrAYVtCYIpDwCfUD8zg2zFunvicq+/fP4DOdql7HGbjyxE2cQKFwATadPV+C?= =?us-ascii?Q?w4pcszn6hq6HMxcx2d97jAlU9y2SsV5d9jjCRyvQ7dl6tKBGgl8I6jcCXOvh?= =?us-ascii?Q?clPOer+vu+eCYjmkgHGlpfDM22aPFUJYe2QCSUXoVJJpKZ7d4mP/yeldTfwk?= =?us-ascii?Q?uStYsYJn7NydcSlXkfb26M3rpSQ1jh9XOBd5k8uJkEore7tz90pg7wZlVsAo?= =?us-ascii?Q?QR9zrRe10gBLqSj43k0DdVQfmSZgrzwqudZMlfG8/tf1rcdUlZYMTzcov55U?= =?us-ascii?Q?Xtk1OuqOm0S/CJlZGsrt0L1+AubaCy1RsUuAD2I5VfqBDI01YpcxAuHzyaT2?= =?us-ascii?Q?BHx45S0+7uIms2Hwo6Op7fvfYj/tqojSrkvn5Vn2Fiimrwp4yhfq7I8N5dKV?= =?us-ascii?Q?pTupgWSN4/Qecsd1RuskDLtaMY98chVJvPkiE0uwojxxDYf0NLgz5EYSLyok?= =?us-ascii?Q?Kg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 6f32adc7-4132-4e23-9fde-08da9f840654 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 05:57:41.6898 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ahbpPmnbMZNy+/ABPFbFBFNe3hthnE7HaFfTagzV6yz7j8jzBmK5tudB3VgOicECvA+BWwoFu6WNaX2zrgjw/xsJsnm3Bylbom913fCcugM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB7249 X-TUID: w0LisAuBNYKd > -----Original Message----- > From: Kanagarajan, Vijaikumar > Sent: Monday, September 26, 2022 12:53 PM > To: Moessbauer, Felix (T CED SES-DE) ; Schi= ld, > Henning (T CED SES-DE) > Cc: Kiszka, Jan (T CED) ; isar- > users@googlegroups.com > Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision >=20 >=20 >=20 > > -----Original Message----- > > From: Moessbauer, Felix (T CED SES-DE) > > Sent: 26 September 2022 07:11 > > To: Kanagarajan, Vijaikumar ; > > Schild, Henning (T CED SES-DE) > > Cc: Kiszka, Jan (T CED) ; isar- > > users@googlegroups.com > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision > > > > Hi Vijai & Henning, > > > > Are there any news on this? > > I just discovered that still many (if not all) of our images are > > affected by this bug. >=20 > Hi Felix, >=20 > Unfortunately not. If we already have the latest wic, --no-fstab-update[1= ] might > help.(untested). We already have a wic version with this option, but it doesn't look right t= o add it to the root partition. Instead this option can be used for partitions that should not show up in t= he fstab at all. Indeed, the fstab entry has to be set by WIC to set settings like UUID and = filesystem. But this requires that we either remove the entry set by ISAR in image_conf= igure_fstab, or we remove the entry after generating the rootfs, but before= WIC. Opinions? @Kiszka, Jan (T CED) Felix >=20 > Thanks, > Vijai Kumar K >=20 > > > > While it is not serios, having error messages in the journal is still p= retty bad: > > systemd-fstab-generator[1491]: Failed to create unit file > > /run/systemd/generator/-.mount, as it already exists. Duplicate entry > > in /etc/fstab? > > > > Felix > > > > > -----Original Message----- > > > From: isar-users@googlegroups.com On > > > Behalf Of Kanagarajan, Vijaikumar > > > Sent: Friday, June 17, 2022 1:46 PM > > > To: isar-users@googlegroups.com > > > Cc: Kiszka, Jan (T CED) ; Schild, Henning (T > > > CED SES- > > > DE) > > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision > > > > > > > > > > > > > -----Original Message----- > > > > From: Kanagarajan, Vijaikumar > > > > Sent: 13 June 2022 14:48 > > > > To: 'Henning Schild' > > > > Cc: isar-users@googlegroups.com; jan.kiszka@siemens.com > > > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Henning Schild > > > > > Sent: 13 June 2022 14:32 > > > > > To: Kanagarajan, Vijaikumar > > > > > Cc: isar-users@googlegroups.com; jan.kiszka@siemens.com > > > > > Subject: Re: [PATCH v2 2/2] wic: Update to the latest revision > > > > > > > > > > Am Mon, 13 Jun 2022 13:24:01 +0530 schrieb Vijai Kumar K > > > > > : > > > > > > > > > > > Update to the latest wic from OE-core. > > > > > > > > > > > > OE-core Revision: 06ed2aa93fc25a681e3a00ee120d9395b04845da > > > > > > > > > > > > Signed-off-by: Vijai Kumar K > > > > > > > > --- > > > > > > RECIPE-API-CHANGELOG.md | 19 ++++++++++++++++= +++ > > > > > > scripts/lib/wic/help.py | 6 ++++++ > > > > > > scripts/lib/wic/ksparser.py | 1 + > > > > > > scripts/lib/wic/partition.py | 1 + > > > > > > scripts/lib/wic/plugins/imager/direct.py | 5 +++-- > > > > > > 5 files changed, 30 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API- > > CHANGELOG.md > > > > > index > > > > > > 2998824..436b204 100644 > > > > > > --- a/RECIPE-API-CHANGELOG.md > > > > > > +++ b/RECIPE-API-CHANGELOG.md > > > > > > @@ -406,3 +406,22 @@ groups are now created after all packages > > > > > > are installed. > > > > > > Changes in next > > > > > > --------------- > > > > > > + > > > > > > +### Wic adds / mountpoint to fstab > > > > > > + > > > > > > +In the older version of wic, any mount point named / is > > > > > > +skipped from > > > > > > adding +into the fstab entry. > > > > > > + > > > > > > +With the latest wic, this is not the case. / mount point, if > > > > > > +any, is > > > > > > added +to /etc/fstab for automount. > > > > > > + > > > > > > +Any wks file which assumed that / would be skipped from > > > > > > +/etc/fstab > > > > > > should +now be corrected. Otherwise, it might result in > > > > > > multiple / entries in /etc/fstab. +One by the > > > > > > image_configure_fstab function from image class and one by > > > > > > wic. + > > > > > > +Below is an example wks entry that might cause an issue. > > > > > > +Replace "part /" with "part" to avoid adding duplicate entry f= or /. > > > > > > > > > > I am not sure multiple entries would be an issue, i think the > > > > > last one will simply always win. It is good to have a note about > > > > > that change, but i doubt people really have to do anything. > > > > > And if anything has to be done, isar should drop the first one ce= ntrally. > > > > > > > > > > The fstab entry for root is purely for adding some weird mount > > > > > options, usually root is not mounted with fstab but with cmdline > > > > > and initrd. And not having / in fstab just makes that rootfs > > > > > more generic ... it can become part of nfs and next guy takes it > > > > > as btrfs while next guy > > > > takes it as ext4. > > > > > > > > > > Note is good, advise is not > > > > > > > > Noted. Will change the text accordingly in V3. > > > > > > Ok we cannot drop / mountpoint name(though optional). We would be > > lose > > > the ability to find out UUID of root using rootdev api. > > > This is used by some plugins. So the better way would be to use the > > > --no-fstab- update. Seems like we can set them per partition now. > > > > > > Thanks, > > > Vijai Kumar K > > > > > > > > > > > Thanks, > > > > Vijai Kumar K > > > > > > > > > > > > > > Henning > > > > > > > > > > > + > > > > > > +``` > > > > > > +part / --source rootfs --ondisk sda --fstype ext4 --label > > > > > > +platform > > > > > > --align 1024 --use-uuid +``` > > > > > > diff --git a/scripts/lib/wic/help.py b/scripts/lib/wic/help.py > > > > > > index > > > > > > 4ff7470..73e3380 100644 > > > > > > --- a/scripts/lib/wic/help.py > > > > > > +++ b/scripts/lib/wic/help.py > > > > > > @@ -940,6 +940,12 @@ DESCRIPTION > > > > > > quotes. If not specified, the default > > > > > > string is "defaults". > > > > > > > > > > > > + --fspassno: Specifies the order in which filesystem > > > > > > + checks > > > > > > are done > > > > > > + at boot time by fsck. See fs_passno > > > > > > + parameter > > > > > > of > > > > > > + fstab(5). This parameter will be copied > > > > > > + into > > > > > > the > > > > > > + /etc/fstab file of the installed system. = If not > > > > > > + specified the default value of "0" will b= e used. > > > > > > + > > > > > > --label label: Specifies the label to give to the fil= esystem > > > > > > to be made on the partition. If the gi= ven > > > > > > label is already in use by another > > > > > > filesystem, diff --git a/scripts/lib/wic/ksparser.py > > > > > > b/scripts/lib/wic/ksparser.py index 0df9eb0..a49b7b9 100644 > > > > > > --- a/scripts/lib/wic/ksparser.py > > > > > > +++ b/scripts/lib/wic/ksparser.py > > > > > > @@ -155,6 +155,7 @@ class KickStart(): > > > > > > part.add_argument('--change-directory') > > > > > > part.add_argument("--extra-space", type=3Dsizetype("M"= )) > > > > > > part.add_argument('--fsoptions', dest=3D'fsopts') > > > > > > + part.add_argument('--fspassno', dest=3D'fspassno') > > > > > > part.add_argument('--fstype', default=3D'vfat', > > > > > > choices=3D('ext2', 'ext3', 'ext4', '= btrfs', > > > > > > 'squashfs', 'vfat', > > > > > > 'msdos', 'erofs', diff --git a/scripts/lib/wic/partition.py > > > > > > b/scripts/lib/wic/partition.py index 09e491d..e50871b 100644 > > > > > > --- a/scripts/lib/wic/partition.py > > > > > > +++ b/scripts/lib/wic/partition.py > > > > > > @@ -33,6 +33,7 @@ class Partition(): > > > > > > self.include_path =3D args.include_path > > > > > > self.change_directory =3D args.change_directory > > > > > > self.fsopts =3D args.fsopts > > > > > > + self.fspassno =3D args.fspassno > > > > > > self.fstype =3D args.fstype > > > > > > self.label =3D args.label > > > > > > self.use_label =3D args.use_label diff --git > > > > > > a/scripts/lib/wic/plugins/imager/direct.py > > > > > > b/scripts/lib/wic/plugins/imager/direct.py index > > > > > > 4d0b836..c44159b > > > > > > 100644 --- a/scripts/lib/wic/plugins/imager/direct.py > > > > > > +++ b/scripts/lib/wic/plugins/imager/direct.py > > > > > > @@ -117,7 +117,7 @@ class DirectPlugin(ImagerPlugin): > > > > > > updated =3D False > > > > > > for part in self.parts: > > > > > > if not part.realnum or not part.mountpoint \ > > > > > > - or part.mountpoint =3D=3D "/" or not > > > > > > part.mountpoint.startswith('/'): > > > > > > + or not part.mountpoint.startswith('/'): > > > > > > continue > > > > > > > > > > > > if part.use_uuid: > > > > > > @@ -138,8 +138,9 @@ class DirectPlugin(ImagerPlugin): > > > > > > device_name =3D "/dev/%s%s%d" % (part.disk, > > > > > > prefix, > > > > > > part.realnum) > > > > > > opts =3D part.fsopts if part.fsopts else "defaults= " > > > > > > + passno =3D part.fspassno if part.fspassno else "0" > > > > > > line =3D "\t".join([device_name, part.mountpoint, > > > > > > part.fstype, > > > > > > - opts, "0", "0"]) + "\n" > > > > > > + opts, "0", passno]) + "\n" > > > > > > > > > > > > fstab_lines.append(line) > > > > > > updated =3D True > > > > > > -- > > > You received this message because you are subscribed to the Google > > > Groups "isar-users" group. > > > To unsubscribe from this group and stop receiving emails from it, > > > send an email to isar-users+unsubscribe@googlegroups.com. > > > To view this discussion on the web visit > > > > > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgro= u > > > ps.g > > > oogle.com%2Fd%2Fmsgid%2Fisar- > > > > > users%2F8babb01d7eae44e0b9faecad59cdc1d4%2540mentor.com&dat > > a=3D > > > > > 05%7C01%7Cfelix.moessbauer%40siemens.com%7C237b0db9bb724580ca540 > > 8 > > > > > > da5024a3ad%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C6379104 > > > > > 15537105828%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ > > Ijo > > > > > iV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sda > > ta > > > > > =3D%2F%2F1Fxy%2B%2BEgDI4RfUEZ38qy1Q82esArdBuRftDuE1t6s%3D&re > > se > > > rved=3D0.