From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7117657722680508416 X-Received: by 2002:adf:f9c9:0:b0:21d:2cec:63e9 with SMTP id w9-20020adff9c9000000b0021d2cec63e9mr41171028wrr.301.1657209605991; Thu, 07 Jul 2022 09:00:05 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:1ca8:b0:3a2:cfae:ca38 with SMTP id k40-20020a05600c1ca800b003a2cfaeca38ls903434wms.0.gmail; Thu, 07 Jul 2022 09:00:04 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uhRDgOGNNf4I5A7aaTL455L/5+6pZ5xiJSngqYfVHX63vE4kedBYUfVm/2gQiFkScWzD+I X-Received: by 2002:a05:600c:4ca7:b0:3a0:3905:d441 with SMTP id g39-20020a05600c4ca700b003a03905d441mr5384817wmp.159.1657209604784; Thu, 07 Jul 2022 09:00:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1657209604; cv=pass; d=google.com; s=arc-20160816; b=sMl7VAftk90Pygg0dW0YBnUkvPNccMNoI4sJWzZUTZwRYcic4zfNuaQhRIk1C2xRNl vWUFKKnmJKHEahwbQIRRepj+xGTIbrkRgGRnhkYY2SCPOUTIAwnLZX47Gw7nMP6KqhPC dZ0WVgHN4+PP8GYlttwo/myTNs/dzQVizATLOnK3SpUX+lJ/tLMyhlgXnurAlD6Ds8EC xZSaqoqeaJH8r4SSeB3kTUlo4pLde+2tVbGMyW/kVL+/LNlRoFDKx1kOUg0PU6bybAfe Jben1vx7BnBkFFd76S/+kxvPjUBeBqyBUdxGvJeIMu79fyktL2tyGNQUu17MhKLOjC8M uMDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:document_confidentiality :msip_labels:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=OFfMKfWFFkDUccnv3ny+2KC0gWE24Hyd3UbSq+IIqvA=; b=LHNzS3asoRXAuYAnfX1U+WOCY52dA2cN9eAE8DjWAs9nAdCt4REA1GiI25CbJJO2tn QbC7SwFOUGnu4worlc8SDKDeO6PwdcEN1o1QTqUaNbpxRJXs6nxhQBuwJPd5v5iViiG4 JX/E8Tf90ToIHQrrEA3j0mEBtbTMgmIS7Toc8CnToaMG2pIuAWZEHgZ8XkHStu1ntdVN dVkI+BFtcJqwHms+nGc+BUWDJXKZCebRhnQBvPelZhtXQ39C0JbbtbAwtlwF8IA1BebS yVVJiXEukks4gDyFff4knPpiNlEoKPXcpqrSX7VWb3lSuMJGen5/4WRd8aEvxEPl8HK+ 1FIA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=RsDtRG5q; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.104.52 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2052.outbound.protection.outlook.com. [40.107.104.52]) by gmr-mx.google.com with ESMTPS id r126-20020a1c2b84000000b0039c948d7614si116376wmr.3.2022.07.07.09.00.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jul 2022 09:00:04 -0700 (PDT) Received-SPF: pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.104.52 as permitted sender) client-ip=40.107.104.52; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=RsDtRG5q; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.104.52 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cMlUdnvccRCUkGuVYI5AokySNQ82kofzS8f7Tu901eT499id2UTFtsU9iaCcldRDDjyNJXaLknaTTYzIaCJJSUo4UIt3RYt6y5w56fRRiDe2Szn8TQGls6A0RSM2MK1/nfwbZoS/eHWtkImYDbcIr/Oyr9fZnS/0+OWyT5DqM8LJ8wqpmH2beJonRMGY1wmz7RFPuzRbJEMlPF0aLwKjBpL1A3HpycHjMyS+atyP4APPWjOK0rADhiiVT85SQbzSPAKE15fy49EwwyGHxnT+9Xm/IhoxS6Wa5ldwMqBQjD56CIvW6NMs+Ni++fChvK/0TwSznwq1FvCkDJ/wEaonLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OFfMKfWFFkDUccnv3ny+2KC0gWE24Hyd3UbSq+IIqvA=; b=KIqvXh4KrW69lPWrKvlP1rK9lB7Ik2ShNjjXYQXjRoF99uR/YlusqDPjpyhcR8l9qRnV9wJrKF8aLCsZlDSriZbaX/IUFO66VO8ibGafNL0s0df76WCCZgIzXUo84PuA+TyonEDM9fAC2Ec0z/DydkVeT12gApAqhGZ38AsNZ+FSFucQJsW2Dp4CjrIrmR5+ZJDtEuGMzzpJcpSe37qP0q/cyY3Frg8mCfrZA6ntcCpPmr1Fitfh54//UHaAWxk3P0OP/eV6NEEz/v3v4bhXvhlqX/MY7CbqL2LCHToTihXdMruZitk3+mMdsQ7bYXfUrNLKasmgcPhwq2/3ZKxbWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OFfMKfWFFkDUccnv3ny+2KC0gWE24Hyd3UbSq+IIqvA=; b=RsDtRG5qPI6KjPRZ5zT9ns8C4yTFesanjIG+HhIfvftdOYSwNAc2INGZJiZVi9yiQwivb7Z3zLINFkEk4cLtsHavcjVgQIZ6Z9mdFhxfngB/5zBGJsntpgr+HEakUVSPklxpx/K0wmmleD3uOqpc8R8rHNAFKq7Iz0rw5yfVFIW2D03KWE5vSC4Vq8t2dRaCnNDQe+Di6Lc5oqfr0ecGPS3d3DAQKLa1kbuL2/2ttTh6IbYuMcmUJF75aXu26wl4kIV4iedGMDfZmz/qNgqdWq7R8ehdjMhLERlThI+72mcBhUHCpjBzwGeR5BzslDuY81VuXXOLua+KtJM1byuI0Q== Received: from AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:418::19) by GV1PR10MB6026.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:8e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Thu, 7 Jul 2022 16:00:02 +0000 Received: from AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM ([fe80::b8fc:851:a05c:4760]) by AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM ([fe80::b8fc:851:a05c:4760%3]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 16:00:02 +0000 From: "Moessbauer, Felix" To: "Schild, Henning" CC: "isar-users@googlegroups.com" , "jan.kiszka@siemens.com" Subject: RE: [PATCH 2/2] Add support for build dependencies in linux-module Thread-Topic: [PATCH 2/2] Add support for build dependencies in linux-module Thread-Index: AQHYkhjStcI3kgZba0qLy5M97g17D61zED8AgAAAVpA= Date: Thu, 7 Jul 2022 16:00:02 +0000 Message-ID: References: <20220707154634.3860434-1-felix.moessbauer@siemens.com> <20220707154634.3860434-2-felix.moessbauer@siemens.com> <20220707175712.3497e838@md1za8fc.ad001.siemens.net> In-Reply-To: <20220707175712.3497e838@md1za8fc.ad001.siemens.net> Accept-Language: en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Enabled=true; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SetDate=2022-07-07T15:59:58Z; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Method=Standard; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Name=restricted-default; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ActionId=c979cca3-e616-4b12-92c5-b79eba26821f; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ContentBits=0 document_confidentiality: Restricted authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dacdceaa-a998-4629-2c42-08da6031c05d x-ms-traffictypediagnostic: GV1PR10MB6026:EE_ x-ld-processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: msq7LbCMk+NWmIVsRux9iQOhGrZKXbUIY8JEDLKtgiviOxGmvS+j9jrAD+Kyl+5Q4wjMkvZqVl5hSEZ38PtH7AYDj/n+ttUDsMDsgrdQ12k6SQmsnP8unUQPH154B7xeLGRIbzz8JXLgCgdKg3RNMSXG2FSDjyS59s/tMmsnIAreyoQw67K5K9FauId9IAVqtiBWldEJ2SA+oPBEpVR5lqE02kIyVjB6YrZ2BBjVEOoGKyxIFx6Bf+sGMqwD3++dp1YUlOEVWJiDdGD0ebzvQWob1qTWMreMLc7EXQdbmj4WiFD/eOKrAffYvhurmCN8AoR7TbhlbShXFs95siD1tUsWwExw2FPU3rTXloek1cZcn/2qxkg/PzUNeR4mg8PjlnXOJ92lHD2IGGoCU/UaMqlRiim+HQFlpo0jK37h3Ja4Vtq9f+4xSUNal86bEPbhEZ8GOOtas46Rav6ps/zH7IEDBgWdutBZyb0fbGSPbWHQJhmhCAnhokKfFiXq4XkFcNsZe8kuqc44ptRV7MhjcQPcnUKexD0wWSA9iNQxmzZwogwBLmANr+TGC9zQrRTMDneg2X1HxA/WahdUGanNVHfTW/E58FNgp1NG3+WKaBJEkRmkvOy26/uD6hqRqnXuRoK3c5/MlF5Wx2W5UOborUMjUEzT4/Kb0+TMiuPxHSd0QMrpuJxrzJwghviu46eah7v3I+koTEIqpAvlU6uKQhmLYV+bMefpYU04zFHtQJdlhMNCBZrIVqVI3JJRP4f18rGCcDfGSFZ+M6zV1ejJCsmjV4uXat95OrEu7MGlbxnzmZgIzjrgNKCNLsOUyNIx x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(396003)(136003)(366004)(71200400001)(9686003)(6506007)(478600001)(38070700005)(54906003)(107886003)(7696005)(41300700001)(26005)(53546011)(38100700002)(186003)(122000001)(5660300002)(4326008)(33656002)(8676002)(66556008)(66946007)(66446008)(82960400001)(2906002)(52536014)(76116006)(66476007)(64756008)(6636002)(55016003)(8936002)(86362001)(316002)(83380400001)(6862004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Bd9XCkVvCGHRIPRaDbq4CdVcFAju/B+uda/juF6VsyYTE9w3A/G3+lZQx4S8?= =?us-ascii?Q?w1dF2m2IlvfgtFgXFw+thMzTi0EbTWNJ8dQSyO6RmlWa59rScG+8oZn1YL9I?= =?us-ascii?Q?funj05ZNk1B6hOppCRTIgO3ApOLeOLbv0/ZbE2Slvagl57D/7Jl3/S2B1sNw?= =?us-ascii?Q?qVSFVKy5cWos/+YGUuwbMsnFL6utPTmMbPjOV8xhaLh6HGyGyMICzkfP9Ee5?= =?us-ascii?Q?3XjKqjwrJ5ICVIf6IzbkJwzV6h8mWm3odX+GMs/MjfYkqGaiNWuBDmv5WfTg?= =?us-ascii?Q?X/Fo9jeC5VLebLD4Lgvy1aBehgTEpgusbhovdnyNJSIatxjhAS1Kqfusk5wC?= =?us-ascii?Q?dcc//h5ZSajDnXYjgRyvmmsPwxmG0z5F04P78hSMLNn00GjS3I09TCNIJEPa?= =?us-ascii?Q?/2P8VY2+U+KTyCJYNk08UZkJAnZvCmNfOhp5N9UBPJg7XET4EJNpELwvr+QX?= =?us-ascii?Q?g0KRBxLEk6m1tw1eg69g7FnZlXPxjOnfkuMNJZdZLY5Zy9N8QEjpct1n5o0d?= =?us-ascii?Q?3HnX4fhI843XxLb2shllml6JNC7+99NQn7yhFqSvkFemOr3MggCsWMRZyyGD?= =?us-ascii?Q?J2JFVoUMDblIVzGcU9uUxFRZ20sC7yCsXK5kF9+26+27+dAGbNcPXibUSaum?= =?us-ascii?Q?HZqnyVZ8wWKjHYewuZsfbRjcYrU6Mqb1OiETr572javnrBhxvxlGl6o8Rzws?= =?us-ascii?Q?9YPsEIrlso/Kf3I760SgXNcTv2H0DdEubT2oVKfKRlCziZJ3/j1ug253dCHM?= =?us-ascii?Q?qDvTB+E8VhGzYNZ0RBtQM5FnoRBvoJHQJCyUBnNLF8Cep3kfMLMs5fnj0/jl?= =?us-ascii?Q?Ps77A7eVRASUkdRTOA8IyCnMOb/yf/Qe2x7PMiRmNc2B46NQ3uyJA2nrCGlw?= =?us-ascii?Q?/fqdTVbgVBj+HQllDDEZv1R60F7l+g5EBQ0zdQk49g8kG4sU/4c/QxfGrDyV?= =?us-ascii?Q?JUmSlck9BVyQX8kWi34jb47WlYe9ePRBE6gAmRLE2EHWEjH0IY4lbUtutqXi?= =?us-ascii?Q?scZswJRN06bAHABTWvevjdYE59wgeR0fiPf+FLBK7coHMwhZa0nYNGUYem89?= =?us-ascii?Q?TgPQDFlmmamErNcw1fINqbALYQLgXvrFQMxNEUEJ4n9Oy2ubzyokh+OrFzqO?= =?us-ascii?Q?ThbRA7YWtJxCsaupo4okiI/v0GB8kbvrfcDFJmsj6uwUFQc+2dLLsnWUwv6D?= =?us-ascii?Q?yO3z04icVmPQ1oIdri0K6hHuO41mW/8qDXzyspy1tXKpccmbz1wAgXAPMeIe?= =?us-ascii?Q?a0mbhBegYubw2Vb4X1DAsBFACBkvets7w3atYVopFrcvcrw/ShiRwQZAmrpy?= =?us-ascii?Q?eDD3/JQ6tcf+DYkSCvm9BdzdQ4+/J137qZ8Xea1/dm/dBhqtpXrVrQIrFQkI?= =?us-ascii?Q?lCsLS5aVAHFkonNC8AwGXbiovICNThUyJ5w7TGNVI0T+K3FB+i4KunQpqeTA?= =?us-ascii?Q?RQCd3EpTqtnOaLZxMWAWnrZAoDemmwc/1jE5Fsh+U48cUEEgIhRb17cifknK?= =?us-ascii?Q?nyDjrKI2dCyJXJVjG6EG2GBVHSBfa3mBKyyjpoXuZJQ9ANq0bigNbDceXZXj?= =?us-ascii?Q?5k7hMigQ53hrfxn7LpwdLo3PU2rCovEAdeoLhtrzQczGXvUv4RMLT8BTJfOy?= =?us-ascii?Q?kg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: dacdceaa-a998-4629-2c42-08da6031c05d X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 16:00:02.3029 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UWDY/J+yWRCHyYAwuJl25+bsu18x7832fO+lATRZukVsRswzhmes7Jb6YKhJBxVy5CiwfT2RPzN44gK1HbciqrHIESBTWwfJowbIHrKw8tI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR10MB6026 X-TUID: 4VC9UFuWAbSa > -----Original Message----- > From: Schild, Henning (T CED SES-DE) > Sent: Thursday, July 7, 2022 5:57 PM > To: Moessbauer, Felix (T CED SES-DE) > Cc: isar-users@googlegroups.com; Kiszka, Jan (T CED) > > Subject: Re: [PATCH 2/2] Add support for build dependencies in linux-modu= le >=20 > Am Thu, 7 Jul 2022 17:46:34 +0200 > schrieb Felix Moessbauer : >=20 > > This patch adds support to add additional build dependencies when > > building a linux-module by using DEBIAN_BUILD_DEPENDS. > > > > Signed-off-by: Felix Moessbauer > > --- > > meta/recipes-kernel/linux-module/files/debian/control.tmpl | 2 +- > > meta/recipes-kernel/linux-module/module.inc | 3 ++- > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git > > a/meta/recipes-kernel/linux-module/files/debian/control.tmpl > > b/meta/recipes-kernel/linux-module/files/debian/control.tmpl index > > d3f4dfe9..67b08244 100644 --- > > a/meta/recipes-kernel/linux-module/files/debian/control.tmpl +++ > > b/meta/recipes-kernel/linux-module/files/debian/control.tmpl @@ -2,7 > > +2,7 @@ Source: ${PN} Section: kernel Priority: optional > > Standards-Version: 3.9.6 > > -Build-Depends: ${KERNEL_HEADERS_PKG} > > +Build-Depends: ${DEBIAN_BUILD_DEPENDS} > > Maintainer: ISAR project > > > > Package: ${PN} > > diff --git a/meta/recipes-kernel/linux-module/module.inc > > b/meta/recipes-kernel/linux-module/module.inc index 97eff294..a5c4336a > > 100644 --- a/meta/recipes-kernel/linux-module/module.inc +++ > > b/meta/recipes-kernel/linux-module/module.inc @@ -16,6 +16,7 @@ PN .=3D > > "-${KERNEL_NAME}" KERNEL_IMAGE_PKG ??=3D "linux-image- > ${KERNEL_NAME}" > > KERNEL_HEADERS_PKG ??=3D "linux-headers-${KERNEL_NAME}" > > DEPENDS +=3D "${KERNEL_HEADERS_PKG}" > > +DEBIAN_BUILD_DEPENDS =3D "${KERNEL_HEADERS_PKG}" > > > > SRC_URI +=3D "file://debian/" > > > > @@ -26,7 +27,7 @@ inherit dpkg > > TEMPLATE_FILES =3D "debian/control.tmpl \ > > debian/changelog.tmpl \ > > debian/rules.tmpl" > > -TEMPLATE_VARS +=3D "KERNEL_NAME KERNEL_TYPE KERNEL_IMAGE_PKG > > KERNEL_HEADERS_PKG PN" +TEMPLATE_VARS +=3D "KERNEL_NAME > KERNEL_TYPE > > KERNEL_IMAGE_PKG KERNEL_HEADERS_PKG DEBIAN_BUILD_DEPENDS PN" >=20 > In general such lists are way easier to maintain and look at diffs as mul= tiline. i.e. >=20 > TEMPLATE_VARS +=3D "\ > FOO\ > BAR\ > BLA\ > " True, but I don't like these cosmetic changes as well. >=20 > You want to not just add the new but likely also drop the old right? No, it is still used in the debian/rules. This is fine, as the values do not necessarily carry the same value. Felix >=20 > Henning >=20 > > do_prepare_build[dirs] +=3D "${S}" > > do_prepare_build() {