From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7071266692367646720 X-Received: by 2002:a05:600c:3d12:b0:38c:9768:b42 with SMTP id bh18-20020a05600c3d1200b0038c97680b42mr33713645wmb.151.1648458702501; Mon, 28 Mar 2022 02:11:42 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:1da0:b0:38c:aa6a:36fb with SMTP id p32-20020a05600c1da000b0038caa6a36fbls9417403wms.2.canary-gmail; Mon, 28 Mar 2022 02:11:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLgSLdcywnCDnK9VU3neUndvcNOs1MvrTP3OiW8QRWzB4T9Grhk/wq8Cvl9bk2s7ZzY0WO X-Received: by 2002:a1c:7518:0:b0:37c:7eb:f255 with SMTP id o24-20020a1c7518000000b0037c07ebf255mr33789565wmc.29.1648458701645; Mon, 28 Mar 2022 02:11:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1648458701; cv=pass; d=google.com; s=arc-20160816; b=ZL5/2pHE10ijBRuBivkV5M3RpUhXwD0EdhsO957UrqcTaO87egK7a2iwsTiCZpABs2 H4O4gh2gbum+Nui8Hgxqe9K59TUvbepmn/eBPt2XHNzMlmc3/sGU6QumkbY2fYzHWOD1 wuUDtkua3ToeS3SuFhH6qYBYFPeHxWR8W9vKqwbEUzJ9F82rS/8a1ZqQJgh6Qhsn1Y4c nBsxYB2kEfncNVs66kpN38UmrLZb0ZYHhGfzbjeT8FWTCmCGaei4zGT4M8bPuWa91AWD 72nPxJvD5OqQmBNuLAyRgrUwlcdxmoSbuEHS32ZD9DGMdc9GEsJuT3Id7+NqEMnJ0IDB EySw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:document_confidentiality :msip_labels:content-language:accept-language:in-reply-to:references :message-id:date:content-class:thread-index:thread-topic:subject:cc :to:from:dkim-signature; bh=gVhrkek0v8snN7YRG0qWAPBfofEhJLk9AgZycIYvIco=; b=hPMhW41+jotEN2nQNsgHicYyDalaFHzLb2waXF0wdZWm5Jmwgq1E5LCPUhyYpFNUuU iO9ycihX8FlD0XaOvwdGhMO7rKR/49+Q4CH98mpbEjbBVhdNPLHb8K03igZRulaK63sw SEXehl8kIPbsccHk0HxvQQDd2Q/4wmzK+U7u3QNpMTLByCFdJteXLg3bP2SaGPRBE4wN FhOTwj3m0jdILalRHwWr3taarNgCZ9dYAdHPjEoFdBGpBq6+G/pUrEX5hvQlXLD3iLXF rs5W5J7nGxAoZh/GhU3GGmyNuVGDYZpnpLW0vIUdv4l0Oty7q/+0rOEeomvc8LRXpr1t bo9g== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=uvJCGtBk; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 2a01:111:f400:fe02::629 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0629.outbound.protection.outlook.com. [2a01:111:f400:fe02::629]) by gmr-mx.google.com with ESMTPS id n190-20020a1c27c7000000b0038cc502f48fsi626465wmn.1.2022.03.28.02.11.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Mar 2022 02:11:41 -0700 (PDT) Received-SPF: pass (google.com: domain of felix.moessbauer@siemens.com designates 2a01:111:f400:fe02::629 as permitted sender) client-ip=2a01:111:f400:fe02::629; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=uvJCGtBk; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 2a01:111:f400:fe02::629 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gicaUWwQ6Ah3mv6yPXCUhPEPS519GAdkOC3J+leD2J+khVRWbBicjWQGp6rLBipxsdv9M/8J2YKb67bTOBuFMZ4a8WbyIb6/EZsrztJ92NN2bLOjMrblPtK6gru2IqWHa2ctpVuJ6R9FOev+JoxIkC2Phcncw/steBD/uV79MLQXvQMV4vfIDVT9fzvA02wDdioaNVCE4Xk3BU/aYYjJ7TESZJgods2AmL0BYg1oQ6v921OZRWsaJ0tPy5n0QL3V1f9WoZAjeU653f4zBYMV+H7NArg6ft2yQkEiO2hJP9GhzIR8qKDO7pMoITS4evlk6dssN+Jo2LlkBe+Va227NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gVhrkek0v8snN7YRG0qWAPBfofEhJLk9AgZycIYvIco=; b=JpmTTtxySB9QO1SN49zX070RJbiRhszAzMGF0/QT2mqL9DGuj0wdeJnVhjSBoD5YhBcHbcOFg4kUpv6jKFvIw/hEBTgz5zEd3Xpp/IgGQIIfSRsAKKKO4/AGtbWXR6s6JmTPmqZCNNbF1UlWwx1JSt4LVjcXbrHF1IQ6S27GBzzhqRZwPAyFf4wy0lersAm7zLDjhrHeYOy8THSEK1XrG8d6x3AIbFp0oQlht6oAdAFYRj4dS6cuFc4O1BWReF2eSuoEVDqUV9Sz0v4JhHzsUA3XxGWVO2DG0NegNv7HYRoZXZcxozYv4jhKMzsDnopyybUBAtUiagbZ2cFGwdtFQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gVhrkek0v8snN7YRG0qWAPBfofEhJLk9AgZycIYvIco=; b=uvJCGtBk0+DT3DKNYkXMoUvGFp2xVDR4euSv6Dy7P5kr9scgIijyJByCdNdb2frnij1EtHWnMiyDe/Q9/unG3kxzS+4xRRzhyn6LjIY6ynTovjtFb77Y6pugSUnd7XixkFEt/3kxqgfB+0wtLePkF+mugQoKrG1LNH8yeBKnwbNFkBPUFcbKL1sZqRdF2IU+crNAnTlNzZEcdoySwDTZ+e0xF4eeA1nCMJ1zNhr8/1GNYBicYVjF68gP+GPhD+IYVCPd3Cg76DyFKj4cJ1B4MpnxfITTm6Ke4ZEs/vlTYs/sYJ1krqAaIFKp9Y9q2P+aKtjLgPng5EEc7034HnQZkA== Received: from AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:418::19) by AM8PR10MB4035.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:1cb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.17; Mon, 28 Mar 2022 09:11:40 +0000 Received: from AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM ([fe80::192:e4a1:871c:a84d]) by AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM ([fe80::192:e4a1:871c:a84d%7]) with mapi id 15.20.5102.022; Mon, 28 Mar 2022 09:11:40 +0000 From: "Moessbauer, Felix" To: "Schild, Henning" CC: "isar-users@googlegroups.com" , "amikan@ilbers.de" , "jan.kiszka@siemens.com" , "Schmidt, Adriaan" Subject: RE: [PATCH v3 2/7] Add ISAR version of biosplusefi WIC plugin Thread-Topic: [PATCH v3 2/7] Add ISAR version of biosplusefi WIC plugin Thread-Index: AQHYPgxJOJrGZGSZ306agPkYMul0WqzUhfOAgAADChA= Content-Class: Date: Mon, 28 Mar 2022 09:11:40 +0000 Message-ID: References: <20220322164525.3950970-1-felix.moessbauer@siemens.com> <20220322164525.3950970-3-felix.moessbauer@siemens.com> <20220328105133.5c20634a@md1za8fc.ad001.siemens.net> In-Reply-To: <20220328105133.5c20634a@md1za8fc.ad001.siemens.net> Accept-Language: en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Enabled=true; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SetDate=2022-03-28T09:11:38Z; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Method=Standard; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Name=restricted-default; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ActionId=539fc8c2-7b4e-4a50-905c-619ff7f0ac8b; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ContentBits=0 document_confidentiality: Restricted authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 96ae94e3-0a85-4a08-9113-08da109af844 x-ms-traffictypediagnostic: AM8PR10MB4035:EE_ x-ld-processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xoCpp6N7h2q9Fcitytv0xfCjmS7aFzOXFdhpS7+hBnLMg1I474riXvndy/N/8r1j0qa8Z5vgt0gFrqjE+NWzoh+jPgfrZd8BSldXkdf6uon8/DDPBdEZWNnq13fCKk+uAAFJQ9/hBHXtopJeRF/yZKMSgqp+Th2WIosnqEpLpF3TmPzTR98i/mwh1+6xp20fNtX3X3O6wHqkDaohL6AFAADK8rjAeM3F8OB0MUza4N3M3BKLwjbB5chJUFFX9MVM6hhwj17agU/jGDxA0GcohUj9qfEwgu/JmBneHEj6sP3JLJNpr5R7qUskkGFxRhGyEihz7UZocGU5uh4y7fgR8c6xsB2itjR9y/FEtThAKDXNlmcv6hd5YQ38X7keSn+VoI97P8wi2cGDaBdWMh+ZBfOaO9aY5xRGCwcwD1NlBtXTB6cbsQcLfdb0P5iG0EJRyx6L8JCngx0r5VbYD3y2ZWdK19ikNjiCyIM+T+nCimbcwG9udE8q/xD5ytFn3zDPtAdBbR03mVT1+sbS+8a2VfCeQZypW7u/2/qdgdX5ohwaUTDXRNOOS5zg4UJIEwuMdShF057R5Oz2ci+x7uFvgXeA4niFwQmHgoMVu2rFpxyWvlTRrlTJ13eQLb4aEEKvHuwCyhR/mcV6T4CPVLXwEnBqUJlPzCfiVOwbG4lko29j89XmI3/IdHxofUFSE60p9KbCD/MOfROIdQQY0JauFg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(107886003)(55016003)(33656002)(66556008)(2906002)(9686003)(86362001)(316002)(71200400001)(52536014)(66946007)(6862004)(8936002)(508600001)(38100700002)(4326008)(122000001)(26005)(76116006)(38070700005)(186003)(8676002)(6636002)(64756008)(5660300002)(7696005)(54906003)(66446008)(66476007)(6506007)(82960400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RrWjG1eXo1uZTU3GIUxB9867TsXxiGlz4aZgBIGgOE3iRmt7pyPIlSvagLpv?= =?us-ascii?Q?yObIA/5F77vm8R4tyf7mLTJ+CZCI7phzWKTEJu/eeKyTaIcOkzPxhy5a5sLX?= =?us-ascii?Q?mAf164Q7T/OEsT/ZkDkx10Lz5PyXQ/SsH42yo58njJ381GBBUDveSLpb7CS3?= =?us-ascii?Q?FnnrO6BDKX0BQyI/R+bK6R2dXWyIsP0O7mz30PAnrJ2mk4tOPoWr6YK8MbJF?= =?us-ascii?Q?W1o4JNB2cmpYVODeRNPxPcrnyhr5EWr1CQhcYkl525BEdNuaVu/pt7zgFgSo?= =?us-ascii?Q?q7SgfppdEDL5uWzUwRGDnsX69WoIa53iLwEQCCg0dNTim8cPtyyL/v+cVMt3?= =?us-ascii?Q?iKTf5hytzrhAifDSSrhVn2SeXt63sE34NzWDgLhvgyy7npg5REPvxyhSTiD0?= =?us-ascii?Q?Q+Mqvc+7nyj8dGDaUW0qI06BKQtEPQ6V3N6cKCB5km3niqO3543ERa0jCyZy?= =?us-ascii?Q?GMEU1D80uFIECbM/GlwHFHN3n0wlbwixkErlxh3i97TSTnAKfo1ZG349yHYr?= =?us-ascii?Q?BrJQOPW7wF1ddY6X8D38GMogNwUke1JvtcUbzkcHdk+Elz2KWRuVxM3xSxm3?= =?us-ascii?Q?VPqNQBzm+kSsLSqW7rQEOCK//uctonGc+XzRRhF+wQfTNPCJhJOu6SDLH1fh?= =?us-ascii?Q?pILpXtHYI6HxZ1OTdX4fKui8zoncfqDYj12u3+Pm6cpf6zWb9iKUBgzHeaeH?= =?us-ascii?Q?74T4vX/BNFlOH8LiGrNbJAZz0yrExUk9QK6nSMJ+Dw7fE60GoU5fmAW2t0Du?= =?us-ascii?Q?5so4vF9j4sf7ewefsh5/MuXqLRHmFlBNZO/zhysY383y6S4kpZ2C3hPMkWCQ?= =?us-ascii?Q?66AiRaRZzeAkiUiqf598Qx8tAY83EIzNs3aMkSVCWHBeFEWGMEgw1nabPNJi?= =?us-ascii?Q?HzsmfHn8mPks878r0sGvLACKGW0otRPuXeamWfPYegAnAXMQ50ldAPYZb1EH?= =?us-ascii?Q?qc87GquxP8mEuvUjPxknu+JF3EnyPE0Dpkpx1rGy8Da+QQOCbl7z1iZPuYXo?= =?us-ascii?Q?RxY4kYmYrd6MJtQPfJJZmsKpPT1OfVC8a81AnSbKJtXyZC+L9uEndZ7G5toV?= =?us-ascii?Q?BhW/PiEtqB/surWqs/ZWjhnMpzQRx3pP7frJuOXPuVldcuGZPGDGi0FHHgTc?= =?us-ascii?Q?iv2cTTVFzfdbSHm7XZb3+VZvyj8DKmMWXf9sdPSkp6JbtrbF0vFYsLB8G3sY?= =?us-ascii?Q?9J7lHyC/wCTxdbEmkKIdVhpG2xvBj/xuxcAlw1Jl2op2CcNSZ2XSdg3y1d5u?= =?us-ascii?Q?eXuTqX8tnthlnrcPFSKYshmd3SuMTVP2bDkOXkBo2jHVs5aioK/VcLknTF1J?= =?us-ascii?Q?Z7D2faQNrtGCPjwRYxd3AnHe3c3vgjgti6R2RxXZLBXREcSxPZymf2TjJTiy?= =?us-ascii?Q?N2K5Y+S6DZ3Kp59fK/4qwMSzlEFcBzfCFnzSvWgbLrZkGM7NKRJapFD8iVYa?= =?us-ascii?Q?vsB9BKcDcaS3Cr1F3gtax14peaLvEe2yn/8uBVJY8lKch7fWUZqhUBECssUK?= =?us-ascii?Q?KAu/f9U4cE8APPm+jrsiAjQ6AG+bemJ8X31kA1fGeTe7UG5jrdeT+WzI05nS?= =?us-ascii?Q?Qrrupt8K2aHH7B7tSNmOhnAMeuYW6wZ7mcDkJKci3XxRZp9/TOjbXiIit0X0?= =?us-ascii?Q?ZsCnIWYq3BDB5NcMJes1a+by4YN4Bj7+XBoNZB6AjkTloV8avozSsxJyjsxK?= =?us-ascii?Q?Zbsg6G/RFnm3vhZxxYg3fNc1tDXaymvsBGnD/QYvv1zOJodHK7Dgt7I6azBR?= =?us-ascii?Q?LFljGJaW9b+PQFLPgDfkP3DBjlAy7/4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 96ae94e3-0a85-4a08-9113-08da109af844 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2022 09:11:40.1816 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AlOiLrKdIwfTMzRNXWo+xBwTasMz6GgsDod1GcUYJlRsc3yPhxTUSjiQUX5kZ7umCRyn7gueXwVVuR2fOjZ8rZiWQqJZwW300guLPbkCRUU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR10MB4035 X-TUID: /tblnoN7qq0E > > a/meta/scripts/lib/wic/plugins/source/bootimg-biosplusefi-isar.py +++ > > b/meta/scripts/lib/wic/plugins/source/bootimg-biosplusefi-isar.py @@ > > -75,10 +75,10 @@ class BootimgBiosPlusEFIPlugin(SourcePlugin): > > --ondisk sda --label os_boot --active --align 1024 --use-uuid """ > > - name =3D 'bootimg-biosplusefi' > > + name =3D 'bootimg-biosplusefi-isar' > > > > - __PCBIOS_MODULE_NAME =3D "bootimg-pcbios" > > - __EFI_MODULE_NAME =3D "bootimg-efi" > > + __PCBIOS_MODULE_NAME =3D "bootimg-pcbios-isar" > > + __EFI_MODULE_NAME =3D "bootimg-efi-isar" > > > > __imgEFIObj =3D None > > __imgBiosObj =3D None > > @@ -106,7 +106,7 @@ class BootimgBiosPlusEFIPlugin(SourcePlugin): > > loader =3D SourceFileLoader(cls.__PCBIOS_MODULE_NAME, > > modulePath) mod =3D types.ModuleType(loader.name) > > loader.exec_module(mod) > > - cls.__imgBiosObj =3D mod.BootimgPcbiosPlugin() > > + cls.__imgBiosObj =3D mod.BootimgPcbiosIsarPlugin() >=20 > Mhh, for some reason we did rename the class in that fork but not in the = EFI > one. That is indeed not consistent. However, I don't know about the side effects= when renaming this. Looks like the class name is not part of our API as the WIC script just tak= es the name of the python file (e.g. --source bootimg-efi-isar). By that, a rename should be safe. >=20 > Maybe something to get sorted out in this series, or later. Not sure whic= h option > would be best ... i guess the consistent rename would be the conservative > option, meaning the EFI class would have to go I vote for not refactoring this as part of the series. It is technically unrelated (we just call the existing plugins) and just de= lays the integration. Felix >=20 > -class BootimgEFIPlugin(SourcePlugin) > +class BootimgEFIIsarPlugin(SourcePlugin) >=20 > Henning >=20 > > # Import bootimg-efi (class name "BootimgEFIPlugin") > > modulePath =3D > > os.path.join(os.path.dirname(os.path.realpath(__file__)),