From: "Moessbauer, Felix" <felix.moessbauer@siemens.com>
To: "jan.kiszka@siemens.com" <jan.kiszka@siemens.com>,
"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "quirin.gylstorff@siemens.com" <quirin.gylstorff@siemens.com>
Subject: RE: [PATCH 1/1] fix typo in variable name to disable cross-compilation of riscv64 package
Date: Wed, 2 Feb 2022 10:36:50 +0000 [thread overview]
Message-ID: <AM9PR10MB48692D260824658D113E18CE89279@AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <d78b4bad-7e91-ece4-7368-b6806a1741ba@siemens.com>
> -----Original Message-----
> From: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>
> Sent: Wednesday, February 2, 2022 10:45 AM
> To: Moessbauer, Felix (T CED SES-DE) <felix.moessbauer@siemens.com>; isar-
> users@googlegroups.com
> Cc: Gylstorff, Quirin (T CED SES-DE) <quirin.gylstorff@siemens.com>
> Subject: Re: [PATCH 1/1] fix typo in variable name to disable cross-compilation
> of riscv64 package
>
> On 02.02.22 10:20, Felix Moessbauer wrote:
> > The variable ISAR_CROSS_BUILD does not exist, but instead is named
> > ISAR_CROSS_COMPILE.
> >
> > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> > ---
> > .../crossbuild-essential-riscv64_0.2-isar.bb | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essent
> > ial-riscv64_0.2-isar.bb
> > b/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essent
> > ial-riscv64_0.2-isar.bb
> > index be06688f..c7ef390f 100644
> > ---
> > a/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essent
> > ial-riscv64_0.2-isar.bb
> > +++ b/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-es
> > +++ sential-riscv64_0.2-isar.bb
> > @@ -8,7 +8,7 @@ inherit dpkg-raw
> >
> > DPKG_ARCH = "all"
> >
> > -ISAR_CROSS_BUILD = "0"
> > +ISAR_CROSS_COMPILE = "0"
> >
> > DEBIAN_DEPENDS = " \
> > gcc-riscv64-linux-gnu, \
>
> Hmm, interesting, how did this work so far? crossbuild-essential-riscv64 is a stub
> package needed to create the cross-build environment, thus can't be built in it.
> Seems that was magically resolved, or did you actually notice a negative effect?
Probably the ISAR_CROSS_COMPILE was always set to 0 when building this package. Don't know. Just stumbled upon this while searching for locations of ISAR_CROSS_COMPILE.
Looks like this is either not tested in CI, or magically works...
Felix
>
> Jan
>
> --
> Siemens AG, Technology
> Competence Center Embedded Linux
next prev parent reply other threads:[~2022-02-02 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 9:20 Felix Moessbauer
2022-02-02 9:45 ` Jan Kiszka
2022-02-02 10:36 ` Moessbauer, Felix [this message]
2022-02-02 11:12 ` Jan Kiszka
2022-02-16 7:51 ` Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM9PR10MB48692D260824658D113E18CE89279@AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM \
--to=felix.moessbauer@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
--cc=quirin.gylstorff@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox