public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Moessbauer, Felix" <felix.moessbauer@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "Bezdeka, Florian" <florian.bezdeka@siemens.com>,
	"Schild, Henning" <henning.schild@siemens.com>
Subject: RE: [PATCH v3 1/1] add uuid to schroot folder
Date: Fri, 8 Jul 2022 14:37:14 +0000	[thread overview]
Message-ID: <AM9PR10MB48693120338CE4346416A3B989829@AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <d18f84eb-25fe-2424-24be-e4eaa4827335@ilbers.de>

> -----Original Message-----
> From: Anton Mikanovich <amikan@ilbers.de>
> Sent: Friday, July 8, 2022 2:47 PM
> To: Moessbauer, Felix (T CED SES-DE) <felix.moessbauer@siemens.com>; isar-
> users@googlegroups.com
> Cc: Bezdeka, Florian (T CED SES-DE) <florian.bezdeka@siemens.com>; Schild,
> Henning (T CED SES-DE) <henning.schild@siemens.com>
> Subject: Re: [PATCH v3 1/1] add uuid to schroot folder
> 
> 04.07.2022 12:15, Felix Moessbauer wrote:
> > PIDs are not unique across containers.
> > When running the build in a container (e.g. the kas container), the
> > PID of bitbake is likely the same across multiple simultaneously
> > running builds.
> >
> > This is especially the case for CI runners, where it is common that
> > multiple jobs run in parallel.
> >
> > This patch adds an additional UUID component that is injected from the
> > ISAR environment.
> >
> > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> I'm still think placing ISAR_BUILD_UUID generaion outside bitbake is not really
> good idea. This is ok for single run inside container but not so suitable for
> running several builds in one build environment (when we source isar-init-build-
> env only once and then execute bitbake over and over again).
> Current implementation is more env-unique but not build-unique.

We need both, and that is exactly what is implemented in this patch.
We need an external UUID to solve the non-unique PID problem when running in multiple containers simultaneously (like in the gitlab-ci), and we need the PID to support multiple builds in the same dir.

In the future we might want to use the unshare backend and get rid of the mountpoint altogether, but currently this is not mature enough. Hence, we need a solution to fix the sporadic breaks of the CI by PID collisions in the schroot mountpoint.

Felix

      reply	other threads:[~2022-07-08 14:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-04  9:15 [PATCH v3 0/1] " Felix Moessbauer
2022-07-04  9:15 ` [PATCH v3 1/1] " Felix Moessbauer
2022-07-08 12:46   ` Anton Mikanovich
2022-07-08 14:37     ` Moessbauer, Felix [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM9PR10MB48693120338CE4346416A3B989829@AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM \
    --to=felix.moessbauer@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=florian.bezdeka@siemens.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox