RE: [PATCH] install crossbuild-essential into base schroot

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

> -----Original Message-----
> From: Anton Mikanovich <amikan@ilbers.de>
> Sent: Thursday, August 4, 2022 9:36 AM
> To: Moessbauer, Felix (T CED SES-DE) <felix.moessbauer@siemens.com>;
> isar-users@googlegroups.com
> Cc: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>; Uladzimir Bely
> <ubely@ilbers.de>
> Subject: Re: [PATCH] install crossbuild-essential into base schroot
> 
> 03.08.2022 19:44, Felix Moessbauer wrote:
> > This patch always installs the crossbuild-essential-<distro> package
> > into the lower dir of the host sbuild schroot.
> >
> > This avoids having to install this package in the upper-dir when
> > cross-compiling, and is identical to build-essential when natively
> > compiling.
> > By that, the parallel cross-build of packages is significantly faster.
> >
> > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> > ---
> >   meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> > b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> > index aa82846b..f7c7d11b 100644
> > --- a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> > +++ b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> > @@ -9,5 +9,10 @@ SBUILD_VARIANT = "host"
> >
> >   require sbuild-chroot.inc
> >
> > +# always add the crossbuild-essentials package which is # a noop for
> > +the host distro, but significantly reduces # the download + install
> > +time when cross-compiling SBUILD_CHROOT_PREINSTALL_COMMON +=
> > +"crossbuild-essential-${DISTRO_ARCH}"
> > +
> >   ROOTFS_ARCH = "${HOST_ARCH}"
> >   ROOTFS_DISTRO = "${HOST_DISTRO}"
> 
> This will probably not work on riscv64 and any other targets with self-build
> crossbuild-essential.

The CI did not report any issues with this patch, but maybe an riscv64 test is missing...
Either we exclude these community-ports of Debian, or we simply just apply the patches for the architectures we support and we know it works (like armhf, arm64).

Even if this is just a performance thing, in layers with dozens of packages the overhead of just installing the compilers is huge.
It also bloats the upper-dir of the schroot leading to significant disk consumption.

Jan recently reported that the build time raised a lot when switching an arm64 layer to from ISAR v0.9 to ISAR-next (sbuild).
Very likely most of that came from the crossbuild-essential packages.

Felix