RE: [PATCH v3 4/5] base-apt: Predownload packages to base-apt before install.

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

> -----Original Message-----
> From: isar-users@googlegroups.com <isar-users@googlegroups.com> On
> Behalf Of Uladzimir Bely
> Sent: Friday, March 25, 2022 11:32 AM
> To: isar-users@googlegroups.com
> Subject: [PATCH v3 4/5] base-apt: Predownload packages to base-apt before
> install.
> 
> This patch uses debrepo script to predownload packages to base-apt repository
> before they are installed in buildchroot/rootfs.
> 
> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> ---
>  meta/classes/dpkg-base.bbclass               |  8 ++++++++
>  meta/classes/dpkg-gbp.bbclass                |  7 +++++++
>  meta/classes/dpkg.bbclass                    |  7 +++++++
>  meta/classes/image-locales-extension.bbclass |  7 +++++++
>  meta/classes/image-tools-extension.bbclass   |  7 +++++++
>  meta/classes/rootfs.bbclass                  | 20 ++++++++++++++++++++
>  6 files changed, 56 insertions(+)
> 
> diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
> index 86933c57..6106ca01 100644
> --- a/meta/classes/dpkg-base.bbclass
> +++ b/meta/classes/dpkg-base.bbclass
> @@ -102,8 +102,16 @@ python() {
>  }
> 
>  do_apt_fetch() {
> +    ${SCRIPTSDIR}/debrepo \
> +        --srcmode \
> +        --workdir="${TMPDIR}/debrepo/${BASE_DISTRO}-
> ${BASE_DISTRO_CODENAME}" \
> +        ${SRC_APT}
>      dpkg_do_mounts
>      E="${@ isar_export_proxies(d)}"
> +    sudo -E chroot ${BUILDCHROOT_DIR} /usr/bin/apt-get update \
> +        -o Dir::Etc::SourceList="sources.list.d/base-apt.list" \
> +        -o Dir::Etc::SourceParts="-" \
> +        -o APT::Get::List-Cleanup="0"

Hi,

This looks like a lot of code duplication.
We already have a bunch of similar calls to apt spread across ISAR.
Just to name a few:

- buildchroot/files/deps.sh
- deb-dl-dir.bbclass
- dpkg-base.bbclass
- dpkg-gbp.bbclass
- image-locales-extension.bbclass
- image-tools-extension.bbclass
- rootfs.bbclass
- isar-bootstrap.inc

With sbuilder the situation will get even worse, as the do_install_builddeps task is no longer available.
By that, users that have to prepare their sources in advance to building will manually have to fiddle around with apt to install pre-build dependencies.
Affected OSS layers I know of are meta-coral (dpkg-bazel.bbclass) and meta-iot2050 (npm.bbclass).

Maybe we should re-think our apt handling and add a proper infrastructure.
By that, we can handle all options centrally and give the user an easy to use interface to install a package.
Also error prone aspects like mounts and locks should be handled by that infrastructure.

Finally, this would significantly reduce future maintenance effort in downstream layers.

Felix

--
Siemens AG, Technology, T CED SES-DE
Otto-Hahn-Ring 6, 81739 München, Germany