From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7078983779658760192 X-Received: by 2002:a17:907:60cf:b0:6df:a8e8:3597 with SMTP id hv15-20020a17090760cf00b006dfa8e83597mr38869783ejc.111.1648647712903; Wed, 30 Mar 2022 06:41:52 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:26cb:b0:419:2d87:4ce0 with SMTP id x11-20020a05640226cb00b004192d874ce0ls2295769edd.0.gmail; Wed, 30 Mar 2022 06:41:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlnRpQKX+17xktzV4jCPwBgSWRlulKKx47Vu1L5Jzz7BgRK5eefjyiA9jUG/tPf6NHmSe1 X-Received: by 2002:a05:6402:84b:b0:419:105:f516 with SMTP id b11-20020a056402084b00b004190105f516mr10803262edz.3.1648647712021; Wed, 30 Mar 2022 06:41:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1648647712; cv=pass; d=google.com; s=arc-20160816; b=ey39HfNpiIzuaSjBhReqvxRwKPSClvAoY+LtIH220Hik7MSfgF0l0gV/HArCO32tRa IV/7ueRErzYcB9ks1crPGmCqwtSeUMwMyMwjZbtN/GHW3FeiLsPdTXqLxjRp+gwr5doX 4zDpbYUxN6/XNnGEp81WJi4/ABvPZZX3vS3XTJyoNRYIF86dtaXaB4QH5OiHFNtTK6YU Ey9Kbh9SupYCQTZNb/CnuK2/eN4WahjVXps3tJT+MhdntIS0ZkD0QPtpieVRahDiWuCo 2dG7FTOaq+GRg9870FQc+95cNqxb0L/Chc/ugAkKFGXxiu5oLXL0GyQBn9tu9c1hrIge VeDw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:document_confidentiality :msip_labels:content-language:accept-language:in-reply-to:references :message-id:date:content-class:thread-index:thread-topic:subject:cc :to:from:dkim-signature; bh=qeFmnfl9smxoLnOIio2Q7XIbYCqaj9WwTtlZxLI4Cag=; b=TMm5YyiyiXv3H9i0XEaKDQNpbeyThrjOB4vJsyVUnB6+ZfspXQOQmFcH7BIOqmIF+P jSHEVMf+yQHV3TkwSCW+oxyQTHopqC/0diYhD3sDGThU3ihIOF4o3kDs9Fq7w2Mab1t7 1Mk8LkSih7mj9WrB9c3Af1RsyzEcCauwX0a92/BhRVAw9lH0rSz/SErcbS4Cp3mZsDWZ 6TTyzNW/P8NOYZ86aBLuOwcC36mKfGAyM3LugxmMPPZOAdumECs4hSSUL3ovQCoqOGq6 AtMCFnFPdlnLJzZQ941j2OCFXrnuSlOYjx829o118NZvW1suRGvjY7xCRM0e6o1v22MA /42Q== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=SPsZHDHR; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 2a01:111:f400:fe07::614 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on0614.outbound.protection.outlook.com. [2a01:111:f400:fe07::614]) by gmr-mx.google.com with ESMTPS id r13-20020a50d68d000000b00418f6042d64si99156edi.1.2022.03.30.06.41.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Mar 2022 06:41:52 -0700 (PDT) Received-SPF: pass (google.com: domain of felix.moessbauer@siemens.com designates 2a01:111:f400:fe07::614 as permitted sender) client-ip=2a01:111:f400:fe07::614; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=SPsZHDHR; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 2a01:111:f400:fe07::614 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RsfaPGfdwhdlq+pEMYE2Fm3HbxvBe/r5N+o32Bds+TppGGKvzu4DcG/4HBHpsL21oJtg6F2s6u0UT0qBkvUbvhNnhbidgmXs4tCUHaxNco6g8cJvFR3YwRUrQYUHoNFiUuz+Jx5mlRWl0wAq2xBBUPiepdSxd88Up7KKKq+df+V1HhCdTvrL44iIHMKpF0MeY/0bAfD0K14vrX+3cJ0r0hvJxNgy+pUCjWCJVhQorfYHCceQRLtGcyZ8Qs9KtAHvHoxMeIYEhubHS4JRHxnXC/haHdMoQmJrrusz8AD6cgnRtgGCARzSzPErjjAtShVrVi8WVI7+3jNANUQUFfOMtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qeFmnfl9smxoLnOIio2Q7XIbYCqaj9WwTtlZxLI4Cag=; b=h/zkGODtEv7B+9CdZTFTiiFPEqmqIk3VxQyvcD9y7lgxZyu9093DXAl/YgQmG+LooekW+ME75FQ52EeRLDxQjtmYXshyWWdUmyffpLqUmTEtOx1CE9vWMiBiToIZAKaG30ZfIQiNkInTJ0UM/T0fD1pJzUAg9CVzDHZMcCwjb2hoDzLj181mjDugJkXtdPpvnpaCPILOu2E9rOLwP8gVOPOJxEaPLDPIwBPbN1FFPUrSvDPkhaLqotahgH0+KeDhDNTbj709nL4BXTz7PILvFKrvZq71OozZQW5enzKDCww0v6AmxZtpWxMGQlJEtnGiI3qlQv+C0QdxJAPwf86c3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qeFmnfl9smxoLnOIio2Q7XIbYCqaj9WwTtlZxLI4Cag=; b=SPsZHDHRPRQihTVNwkgPJYNKd28DMo65arIsjYbE3r9JqlUmhoLVKkKRqxESlzBDLsyfBAdXDJWc/Pfn19uw8NI1nzo7RxBXesew1uwiFsnWePX4SpOT9mZtTC251/EAAIC+LH6QgDxxtl9vyE4GNDpj2lpAM3gIc428fUO65km43XXDuhf/fw/iGb613F0lJgqo3tj6RkCfz2Er8ji0LQ55U3UQ+BK12v60vwZJ/WHEVf1aCqc0oUXa4nijuZ8smwtHxYoMKEf9zlpgCeW7S6YHDBfdNd5kO0TvzD+ttLySNQmHkDZApkVHgUdDvUtVYb9VGjlAYPuWZSSD0pylag== Received: from AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:418::19) by VI1PR10MB1855.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:802:32::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.22; Wed, 30 Mar 2022 13:41:50 +0000 Received: from AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM ([fe80::192:e4a1:871c:a84d]) by AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM ([fe80::192:e4a1:871c:a84d%5]) with mapi id 15.20.5123.019; Wed, 30 Mar 2022 13:41:50 +0000 From: "Moessbauer, Felix" To: Uladzimir Bely CC: "isar-users@googlegroups.com" , "jan.kiszka@siemens.com" , "Schmidt, Adriaan" Subject: RE: [PATCH v3 4/5] base-apt: Predownload packages to base-apt before install. Thread-Topic: [PATCH v3 4/5] base-apt: Predownload packages to base-apt before install. Thread-Index: AQHYQDPq1HK7RYwjJEWbbcF13AXgxazX87xw Content-Class: Date: Wed, 30 Mar 2022 13:41:50 +0000 Message-ID: References: <20220325103226.27033-1-ubely@ilbers.de> <20220325103226.27033-5-ubely@ilbers.de> In-Reply-To: <20220325103226.27033-5-ubely@ilbers.de> Accept-Language: en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Enabled=true; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SetDate=2022-03-30T13:41:48Z; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Method=Standard; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Name=restricted-default; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ActionId=17604d29-881a-44e2-a775-38dfc32e6225; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ContentBits=0 document_confidentiality: Restricted authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 36fbeee0-073b-4569-3d06-08da12530b0f x-ms-traffictypediagnostic: VI1PR10MB1855:EE_ x-ld-processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FO7B0DZgU7ljKWhbZlbDJAxHTi4d9KOAKNZH7K0IDHOevUIx4iOd5eJiV4/V6F3eO5KBMOcH0CUZXDsD/Ph1ADgAVWQRKxxb7QTezPf0AcIay3/tDCjA/a93JVb+qa4LIK0ekCPOybE0upERSqz/x1wXTsvOHX983Dlaaj5oQJ7wuz69KziewIwpH4R3FusXuJ4b9hrK5q3bFvHHk6RdV8e6unH3wEiJhu3c8w8Gn6BR8hOLbk6vG9xTfAfC5AtcQWVy8peg915mN9ePqeT9/S7bZ5BkRDdNEjvkAOi5GSUkeHBHDEiQiLOS+GaFtNpuLzpzFyiQSYtua47ZEgZMBTzvEHnPRYz9IDpGV3QbURlLwfIsvd+NBldBJ4uDHKngRVw+digAcJ/b0FXgxHD+3Cb+XOkvXb+7avEN29NDR3N3DaM59U5Kqo0YJATTNx42QgZIH5To37ZpICyCrZ/xOq9ihYMmLKopIJZ/szBq/BzRiTMF30w5kHmH5arlZuFfSE8xWBWV2bb3s0+7LJbxk/tBaRXXb9XS9RUFq0oigVDdkYl/bfb4BRzwf2jPFGCLVGfl595bjKCDq2xZNjxTtVcqsVITXr6/fc+GaMjEOi2y/VbZT3UKkszU7hohII+DI0WB6Vo6j7x3Iaqo0OXWPL9Pmj7j6b8v6feU8cwcSbYM7ikYQNcXaLkTG5N/0dA9AfPxk3tltlBU3D9MWC+onw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66446008)(66476007)(64756008)(6916009)(107886003)(76116006)(4326008)(66946007)(38100700002)(38070700005)(54906003)(82960400001)(316002)(8676002)(83380400001)(71200400001)(26005)(66574015)(186003)(86362001)(6506007)(9686003)(53546011)(508600001)(33656002)(7696005)(66556008)(2906002)(55016003)(5660300002)(52536014)(8936002)(122000001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?J6mcmln4fecZDnGz8tt45/aNQxwiQVf2zl1yeOnZAoO5NyNvHKnDjWIvvN?= =?iso-8859-1?Q?Aqdq2VVGQ1WHnhaNr5mGx1qLHh+ykrpoDlVbO9xeGbVNDRF+r7oUiE5ksx?= =?iso-8859-1?Q?4/lHc5sw/I8k36ex6H0W+Qcd733kBa0T19e4w1BwVi8utMBI45eOTxXuUQ?= =?iso-8859-1?Q?W9uTQhLGYTtxW36nEgF3UT8F//qTCU99ecCHOafLQMczO51KKVzkH0ugmi?= =?iso-8859-1?Q?6SQg5xb4dQ/YEjZjsCwadYNIKtJ5Pk1QqD5479M9yEkaCHqWoMBcGnNtQf?= =?iso-8859-1?Q?fGNfaf5eLqEfjYlj8b/wXU3rO2/jAAyq0ULNSKfwRuybqqOWvGR6yS4rnE?= =?iso-8859-1?Q?pYO/mkoNSIZtCMtXHl3iqG9G08tY3akSJv2IUzKWoGB/6Jz18AzRfOk/1Z?= =?iso-8859-1?Q?PITVD/xGu9mh5yh98aPq0OfmmGcMaxUeFqQh5PdvWl/Zyc89BCg8bgoWnZ?= =?iso-8859-1?Q?3EkKxd8A0WoIw1V9viiRCvW8h/2fpPoj3L7Zls/3QkeM3gWqWbEaXSCROF?= =?iso-8859-1?Q?7RX/mO1x14Tw6mQBSw819iwV8HG8a5FH8IDbGa6lH1d+wziRVi1Bk3s6iu?= =?iso-8859-1?Q?RFE12OePI7G1A39kx6+Weg9ul11YUmknfsboSx4tpScQExoZiFGFGq9E68?= =?iso-8859-1?Q?ZshZqY5tFIxGMMVmF2G//aLG4UbBLddGF5sIH8H6OY8gNzdU/zCw2TkBo+?= =?iso-8859-1?Q?wBPy/sPeE1UYnTDK0pizv/JhQtCVYMAuUmgtG7A8BLF3QDMKxASBPg07qK?= =?iso-8859-1?Q?IfbgWmlGFC7OThejvklWRv0+n+DstaCUT4tsqgR9X7IioJ1fwRPeEo5uHc?= =?iso-8859-1?Q?vcqFCam/U0McHorqrtQ1zXRGlkpOKwoWPBN5V458C/fLYLL+ureJ2wNtad?= =?iso-8859-1?Q?BwbLTG9JCSX5CFq5eaE39Fg6lK7vx0gtnm+VhYGFKT8e2UdE+fpXs+5cqf?= =?iso-8859-1?Q?XmUkrweXi5DRMq/DQFF3MY+eesY00VK9XUoWsbFZG/EeU31nJ6vk8coIO8?= =?iso-8859-1?Q?xRwaHR2M+/t4tlhVounXsX7qpJiCceGY2An36ZWiO6Ut+1R8winCWZOscD?= =?iso-8859-1?Q?dLKLKXo4rHMsi9OFU/XnyAaY2c6vHcp6t0lxTRw2dbNPHTroBSbQq46pSw?= =?iso-8859-1?Q?//f/O0jW0XPOvY+xeWHDC4f9KJrqs66WvXOOUqo9jFsrt9D6dYPJXChSZv?= =?iso-8859-1?Q?gVViqW7hGg3uAiQGobLeFVhVHeUsq4aaZwG7HiJtXy7OfaTMdrvjM+mTds?= =?iso-8859-1?Q?EbFlcrwhwAGzQ9s/FKrE604kbZLZCAVgdFFYtsWedLfstWnyJDdFAvIdlV?= =?iso-8859-1?Q?1xGQU15S570Bf9RU8eB3rAhNlBmAwlyU9WVzB1SjpPoYMLYrMTJqNqxsOH?= =?iso-8859-1?Q?bCtzdUapZkednNZLnIKVoqVWIelbhs03llhxTuEZf0nva+lSdIn8B5IUky?= =?iso-8859-1?Q?e4kYajFgEFVKo1tbyk1grsZrqIPJmgslwgsrYqHRROLSoT2IaoRW1ctbGS?= =?iso-8859-1?Q?2uvu6VpAZh/VqPPmUr00nUK9KYDYzApaYTvwjJ9gbDC32AaXXio2u8CNuZ?= =?iso-8859-1?Q?JeaCW8GcvgoJknfduSbK+YB8GP39GTuJV/XCyV4scHB3n5mdU7YK8Hs2wI?= =?iso-8859-1?Q?m+k8UIkDeHfqZzFy9G3kGyaVdk9PTcJuDcownwxKHt1C9kdVzko7Yej6Ji?= =?iso-8859-1?Q?R+jPUEgmeheCbtunh5MbIOXpvQ8DCGpe6fIp9deS/R8Ax3hEhIFGR291L7?= =?iso-8859-1?Q?DLyLaSWS0H5WK+x6aooMm1HsYd1E3SCsFTBDl+DlWJGb9smhLyuUWaHgAE?= =?iso-8859-1?Q?fRM7nFmlGcFPvQtjRpt9PbqrI/pAX/c=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 36fbeee0-073b-4569-3d06-08da12530b0f X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2022 13:41:50.0813 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XawMkEsniufs22WcCyM+2VVNbDqdG2BH48Gcci2sUCm9QujS8lUwTxO+1JTilHQ2Jci2M+aNE4Hb2XsC2vg2MI6z/TX79cXnsbP+HWcvs/k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB1855 X-TUID: yToigrTrOkjM > -----Original Message----- > From: isar-users@googlegroups.com On > Behalf Of Uladzimir Bely > Sent: Friday, March 25, 2022 11:32 AM > To: isar-users@googlegroups.com > Subject: [PATCH v3 4/5] base-apt: Predownload packages to base-apt before > install. >=20 > This patch uses debrepo script to predownload packages to base-apt reposi= tory > before they are installed in buildchroot/rootfs. >=20 > Signed-off-by: Uladzimir Bely > --- > meta/classes/dpkg-base.bbclass | 8 ++++++++ > meta/classes/dpkg-gbp.bbclass | 7 +++++++ > meta/classes/dpkg.bbclass | 7 +++++++ > meta/classes/image-locales-extension.bbclass | 7 +++++++ > meta/classes/image-tools-extension.bbclass | 7 +++++++ > meta/classes/rootfs.bbclass | 20 ++++++++++++++++++++ > 6 files changed, 56 insertions(+) >=20 > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbcl= ass > index 86933c57..6106ca01 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -102,8 +102,16 @@ python() { > } >=20 > do_apt_fetch() { > + ${SCRIPTSDIR}/debrepo \ > + --srcmode \ > + --workdir=3D"${TMPDIR}/debrepo/${BASE_DISTRO}- > ${BASE_DISTRO_CODENAME}" \ > + ${SRC_APT} > dpkg_do_mounts > E=3D"${@ isar_export_proxies(d)}" > + sudo -E chroot ${BUILDCHROOT_DIR} /usr/bin/apt-get update \ > + -o Dir::Etc::SourceList=3D"sources.list.d/base-apt.list" \ > + -o Dir::Etc::SourceParts=3D"-" \ > + -o APT::Get::List-Cleanup=3D"0" Hi, This looks like a lot of code duplication. We already have a bunch of similar calls to apt spread across ISAR. Just to name a few: - buildchroot/files/deps.sh - deb-dl-dir.bbclass - dpkg-base.bbclass - dpkg-gbp.bbclass - image-locales-extension.bbclass - image-tools-extension.bbclass - rootfs.bbclass - isar-bootstrap.inc With sbuilder the situation will get even worse, as the do_install_builddep= s task is no longer available. By that, users that have to prepare their sources in advance to building wi= ll manually have to fiddle around with apt to install pre-build dependencie= s. Affected OSS layers I know of are meta-coral (dpkg-bazel.bbclass) and meta-= iot2050 (npm.bbclass). Maybe we should re-think our apt handling and add a proper infrastructure. By that, we can handle all options centrally and give the user an easy to u= se interface to install a package. Also error prone aspects like mounts and locks should be handled by that in= frastructure. Finally, this would significantly reduce future maintenance effort in downs= tream layers. Felix -- Siemens AG, Technology, T CED SES-DE Otto-Hahn-Ring 6, 81739 M=FCnchen, Germany