RE: [PATCH] install crossbuild-essential into base schroot

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

> -----Original Message-----
> From: Uladzimir Bely <ubely@ilbers.de>
> Sent: Thursday, August 4, 2022 8:23 AM
> To: Moessbauer, Felix (T CED SES-DE) <felix.moessbauer@siemens.com>;
> isar-users@googlegroups.com
> Cc: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>
> Subject: Re: [PATCH] install crossbuild-essential into base schroot
> 
> In the email from Thursday, 4 August 2022 09:07:08 +03 user Jan Kiszka wrote:
> > On 03.08.22 18:44, Felix Moessbauer wrote:
> > > This patch always installs the crossbuild-essential-<distro>
> >
> > <distro-arch>
> >
> > > package into the lower dir of the host sbuild schroot.
> > >
> > > This avoids having to install this package in the upper-dir when
> > > cross-compiling, and is identical to build-essential when natively
> > > compiling.
> > > By that, the parallel cross-build of packages is significantly faster.
> >
> > I was wondering if that should be made dependent on
> > ISAR_CROSS_COMPILE, even though users could turn it off globally and
> > only enable it for individual packages?

I tried that before, but this leads to non-deterministic build data, as the ISAR_CROSS_COMPILE can be switched on / off on a per-receipt basis, but the lower-dir of the schroot is shared across all recipes.

> >
> > Jan
> >
> 
> This might be even more conditional.
> 
> Depending on compat arch option state, we might actually need crossbuild-
> essential-${COMPAT_DISTRO_ARCH} instead. Even in "native" builds, even
> for sbuild-chroot-target...

In the end, this is a tradeoff. Having sbuild default-dependencies in the base schroot does not affect correctness of the build (they will be installed later on anyways).
It simply reduces the amount of work that has to be done per recipe.

This patch improves the situation for cross-builds.
Adding support for COMPAT_DISTRO_ARCH is a different story.

Felix

> 
> > > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> > > ---
> > >
> > >  meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git
> > > a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> > > b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb index
> > > aa82846b..f7c7d11b 100644
> > > --- a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> > > +++ b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
> > > @@ -9,5 +9,10 @@ SBUILD_VARIANT = "host"
> > >
> > >  require sbuild-chroot.inc
> > >
> > > +# always add the crossbuild-essentials package which is # a noop
> > > +for the host distro, but significantly reduces # the download +
> > > +install time when cross-compiling
> SBUILD_CHROOT_PREINSTALL_COMMON
> > > ++= "crossbuild-essential-${DISTRO_ARCH}"
> > > +
> > >
> > >  ROOTFS_ARCH = "${HOST_ARCH}"
> > >  ROOTFS_DISTRO = "${HOST_DISTRO}"
> 
> 
> --
> Uladzimir Bely
> 
>