RE: [PATCH v6 07/12] sbuild: support of shell exports from dpkg_runbuild_prepend

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

Hi,

> -----Original Message-----
> From: Uladzimir Bely <ubely@ilbers.de>
> Sent: Monday, March 14, 2022 1:29 PM
> To: isar-users@googlegroups.com
> Cc: isar-users@googlegroups.com; Kiszka, Jan (T CED)
> <jan.kiszka@siemens.com>; Moessbauer, Felix (T CED SES-DE)
> <felix.moessbauer@siemens.com>
> Subject: Re: [PATCH v6 07/12] sbuild: support of shell exports from
> dpkg_runbuild_prepend
> 
> In the email from Wednesday, 9 March 2022 20:57:32 +03 user Moessbauer,
> Felix
> wrote:
> > Hi,
> >
> > The attached patch adds support to run the sbuild behind a proxy.
> > I briefly tested this with "bitbake mc:qemuamd64-bullseye:isar-image-base"
> > in an environment where proxies are mandatory.
> >
> 
> Hi.
> 
> I've fixed proxy in a bit different way. I found that sbuild supports so called
> 'environment filters' that allow to pass particualr variables to the build
> environment.
> 
> which, besides fixing proxy, also modifies a bit `sbuild_export()` function, so that
> no additional same lines would added to sbuild.conf on the sequential runs of
> build.

I just tested your patch and can confirm that it works.
Probably yours is the better solution anyways, as this has better support for special cases with NO_PROXY, which are hard to handle in the apt config file.

Felix

> 
> I'm not completely sure, but it seems that if some variable is added to
> $environment_filter array, it even doesn't need to be passed via sbuild_export().
> But this should be tested
> 
> > Best regards,
> > Felix
> >
> > > -----Original Message-----
> > > From: isar-users@googlegroups.com <isar-users@googlegroups.com> On
> > > Behalf Of Moessbauer, Felix
> > > Sent: Thursday, March 3, 2022 2:37 PM
> > > To: Uladzimir Bely <ubely@ilbers.de>
> > > Cc: isar-users@googlegroups.com
> > > Subject: RE: [PATCH v6 07/12] sbuild: support of shell exports from
> > > dpkg_runbuild_prepend
> > >
> > > Hi,
> > >
> > > > +
> > > > +        # Don't warn some variables
> > > > +        [ "${var}" = "PARALLEL_MAKE" ] && continue
> > > > +        [ "${var}" = "CCACHE_DIR" ] && continue
> > > > +        [ "${var}" = "PATH_PREPEND" ] && continue
> > > > +        [ "${var}" = "DEB_BUILD_OPTIONS" ] && continue
> > > > +        [ "${var}" = "DEB_BUILD_PROFILES" ] && continue
> > > > +
> > > > +        bbwarn "Export of '${line}' detected, please migrate to
> > > > templates"
> > >
> > > There are more variables that have to be excluded, e.g. all proxy
> > > related
> > > settings:
> > > (http_proxy, HTTP_PROXY, https_proxy, HTTPS_PROXY, no_proxy,
> NO_PROXY).
> > >
> > > But the proxy settings have to be passed into the sbuild environment.
> > > Currently, building behind a proxy fails (in do_dpkg_build):
> > >
> > > +-------------------------------------------------------------------
> > > +------
> > > -----+>
> > > | Update chroot
> > > |     |>
> > > +-------------------------------------------------------------------
> > > +------
> > > -----+ [...]
> > > Err:8
> > > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdeb
> > >
> .debia%2F&amp;data=04%7C01%7Cfelix.moessbauer%40siemens.com%7C0182
> a5
> > >
> c5e2f243aea7a208da05b627af%7C38ae3bcd95794fd4addab42e1495d55a%7C1
> %7C
> > >
> 0%7C637828577756022287%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
> wMDAiL
> > >
> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=gUeP
> w
> > > NL3Ypy8%2BJ0pera559edAH48WumjUlIAseLaDOU%3D&amp;reserved=0
> > >
> n.org%2Fdebian&amp;data=04%7C01%7Cfelix.moessbauer%40siemens.com%7
> > >
> C2c6b2941e0eb40ffccb408d9fd1ad566%7C38ae3bcd95794fd4addab42e1495d5
> > >
> 5a%7C1%7C0%7C637819114851078826%7CUnknown%7CTWFpbGZsb3d8eyJWI
> > >
> joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300
> > >
> 0&amp;sdata=aLGsi%2BBgf28Cm5g7GGhBY5h3eRu7cL5do5Ern45lsVA%3D&am
> > > p;reserved=0 bullseye Release
> > >
> > >   Cannot initiate the connection to deb.debian.org:80 (2a04:4e42:62::644).
> > >   -
> > >
> > > connect (101: Network is unreachable)
> > >
> > > Best regards,
> > > Felix
> > >
> > > --
> > > Siemens AG, Technology, T CED SES-DE Otto-Hahn-Ring 6, 81739
> > > München, Germany
> > >
> > >
> > > --
> > > You received this message because you are subscribed to the Google
> > > Groups "isar-users" group.
> > > To unsubscribe from this group and stop receiving emails from it,
> > > send an email to isar-users+unsubscribe@googlegroups.com.
> > > To view this discussion on the web visit
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgr
> > >
> oups.g%2F&amp;data=04%7C01%7Cfelix.moessbauer%40siemens.com%7C018
> 2a5
> > >
> c5e2f243aea7a208da05b627af%7C38ae3bcd95794fd4addab42e1495d55a%7C1
> %7C
> > >
> 0%7C637828577756022287%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
> wMDAiL
> > >
> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=82brx
> > > SbpuvOdzp1j1T7e7lx7GhRKZREwKS%2BDTkA0TIw%3D&amp;reserved=0
> > > oogle.com%2Fd%2Fmsgid%2Fisar-
> > >
> users%2FAM9PR10MB48698F892FBA3A33D2C0405289049%2540AM9PR10MB4
> > >
> 869.EURPRD10.PROD.OUTLOOK.COM&amp;data=04%7C01%7Cfelix.moessbau
> > >
> er%40siemens.com%7C2c6b2941e0eb40ffccb408d9fd1ad566%7C38ae3bcd957
> > >
> 94fd4addab42e1495d55a%7C1%7C0%7C637819114851078826%7CUnknown%7
> > >
> CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ
> > >
> XVCI6Mn0%3D%7C3000&amp;sdata=PGDjMxGm4JkrqZoktZXAJakrj3Xmxt1w8Gq
> > > vVVYmL5w%3D&amp;reserved=0.
> 
> 
> --
> Uladzimir Bely
> 
>