public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Moessbauer, Felix" <felix.moessbauer@siemens.com>
To: Srinuvasan A <Srinuvasan_A@mentor.com>
Cc: "jan.kiszka@siemens.com" <jan.kiszka@siemens.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>,
	"amikan@ilbers.de" <amikan@ilbers.de>
Subject: RE: [PATCH] bitbake.conf: Add BASE_DISTRO_CODENAME in OVERRIDES variable
Date: Sun, 25 Sep 2022 08:27:19 +0000	[thread overview]
Message-ID: <AM9PR10MB4869AB05BB7CAA03C41B352489539@AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20220923102855.1357346-1-Srinuvasan_A@mentor.com>

> -----Original Message-----
> From: isar-users@googlegroups.com <isar-users@googlegroups.com> On
> Behalf Of Srinuvasan A
> Sent: Friday, September 23, 2022 6:29 PM
> To: isar-users@googlegroups.com; amikan@ilbers.de
> Cc: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>; Srinuvasan A
> <srinuvasan_a@mentor.com>
> Subject: [PATCH] bitbake.conf: Add BASE_DISTRO_CODENAME in OVERRIDES
> variable
> 
> From: Srinuvasan A <srinuvasan_a@mentor.com>
> 
> Commit 4ffdf792 says, Switch custom kernel modules to use libssl3 by default
> and left libssl1.1 dependency only for distros not yet migrated, here they used
> overrides based on "DISTRO".
> 
> Here DISTRO is debian-bullseye or debian-buster and so on, downstream layers
> might define their own DISTRO name.
> 
> Use the overrides based on "BASE_DISTRO_CODENAME" to pick up the exact
> version of libssl for the corresponding DISTRO to better support downstream
> layers with custom DISTRO names.
> 
> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> ---
>  meta/conf/bitbake.conf                     |  2 +-
>  meta/recipes-kernel/linux/linux-custom.inc | 10 +++++-----
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index
> 19798b7..98412e0 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -67,7 +67,7 @@ KERNEL_FILE_mipsel ?= "vmlinux"
>  KERNEL_FILE_riscv64 ?= "vmlinux"
>  KERNEL_FILE_arm64 ?= "vmlinux"
> 
> -OVERRIDES =
> "${DISTRO_ARCH}:${COMPAT_OVERRIDE}:${MACHINE}:${DISTRO}:forcevariabl
> e"
> +OVERRIDES =
> "${DISTRO_ARCH}:${COMPAT_OVERRIDE}:${MACHINE}:${DISTRO}:${BASE_DIST
> RO_CODENAME}:forcevariable"
>  FILESOVERRIDES = "${DISTRO_ARCH}:${MACHINE}"
>  COMPAT_OVERRIDE = "${@'compat-arch' if
> d.getVar('ISAR_ENABLE_COMPAT_ARCH') == '1' else ''}"
> 
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-
> kernel/linux/linux-custom.inc
> index 8581dc8..96f0afc 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -1,8 +1,8 @@
>  # Custom kernel build
>  #
>  # This software is a part of ISAR.
> -# Copyright (c) Siemens AG, 2018
> -# Copyright (c) Mentor Graphics, a Siemens business, 2019
> +# Copyright (c) Siemens AG, 2022
> +# Copyright (c) Mentor Graphics, a Siemens business, 2022
>  #
>  # SPDX-License-Identifier: MIT
> 
> @@ -30,9 +30,9 @@ KERNEL_DEBIAN_DEPENDS ?= "initramfs-tools | linux-
> initramfs-tool, \
>                            linux-base (>= 4.3~),"
> 
>  LIBSSL_DEP = "libssl3"
> -LIBSSL_DEP_debian-stretch = "libssl1.1"
> -LIBSSL_DEP_debian-buster = "libssl1.1"
> -LIBSSL_DEP_debian-bullseye = "libssl1.1"
> +LIBSSL_DEP_stretch = "libssl1.1"
> +LIBSSL_DEP_buster = "libssl1.1"
> +LIBSSL_DEP_bullseye = "libssl1.1"
> 
>  KERNEL_HEADERS_DEBIAN_DEPENDS ?= "libc6, \
>                                    ${LIBSSL_DEP},"
> --
> 2.25.1
> 

ACK - tested on the Siemens internal ipc520a layer.
This fixes the broken kernel-headers package.

Felix

  reply	other threads:[~2022-09-25  8:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AQHYzzdafU+zAaufNESZAMqViN9X/63vz2pQ>
2022-09-22  6:19 ` [PATCH] linux-custom: Update to BASE_DISTRO_CODENAME instead of DISTRO Srinuvasan A
2022-09-23  9:33   ` Anton Mikanovich
2022-09-23 10:28   ` [PATCH] bitbake.conf: Add BASE_DISTRO_CODENAME in OVERRIDES variable Srinuvasan A
2022-09-25  8:27     ` Moessbauer, Felix [this message]
2022-09-26  9:55       ` Srinuvasan Arjunan
2022-09-26 10:03         ` Anton Mikanovich
2022-09-28  9:22     ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM9PR10MB4869AB05BB7CAA03C41B352489539@AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM \
    --to=felix.moessbauer@siemens.com \
    --cc=Srinuvasan_A@mentor.com \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox