RE: [PATCH v2 1/1] fix: mount pts into rootfs

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

> -----Original Message-----
> From: isar-users@googlegroups.com <isar-users@googlegroups.com> On
> Behalf Of Baurzhan Ismagulov
> Sent: Wednesday, May 11, 2022 10:04 AM
> To: isar-users@googlegroups.com
> Subject: Re: [PATCH v2 1/1] fix: mount pts into rootfs
> 
> On Mon, May 09, 2022 at 02:34:54PM +0000, Moessbauer, Felix wrote:
> > > > diff --git a/meta/classes/buildchroot.bbclass
> > > > b/meta/classes/buildchroot.bbclass index 3d2211b9..527f8ded 100644
> > > > --- a/meta/classes/buildchroot.bbclass
> > > > +++ b/meta/classes/buildchroot.bbclass
> > > > @@ -43,7 +43,8 @@ buildchroot_do_mounts() {
> > > >          fi
> > > >          mountpoint -q '${BUILDCHROOT_DIR}/dev' ||
> > > >              ( mount --bind /dev '${BUILDCHROOT_DIR}/dev' &&
> > > > -              mount -t tmpfs none '${BUILDCHROOT_DIR}/dev/shm' )
> > > > +              mount -t tmpfs none '${BUILDCHROOT_DIR}/dev/shm' &&
> > > > +              mount --rbind /dev/pts '${BUILDCHROOT_DIR}/dev/pts'
> > > > + )
> > >
> > > if recursion was removed on purpose we should probably mount "-t
> > > devpts" and not "--rbind"
> >
> > Yes, I am happy to send a v3 with that fix, but before doing so we should agree
> on a direction.
> > In the end, it would probably be better to let schroot handle our buildchroots.
> > This shouldn't be too much effort, once the sbuilder patches are merged.
> 
> I think the final solution should be removing buildchroots (we need a couple of
> days for v1, +/-).
> 
> If an interim solution would be needed, mount --bind /dev/pts from the host
> should be used. In my local projects, I had started with mount -t devpts but
> switched to --bind in 2018 due to issues (at least "sudo: no tty present and no
> askpass program specified", not sure about other packages).

IMO we will need an interim solution as downstream layers will need some time to adapt to the sbuild / schroot infrastructure.
By that, it is likely that pre sbuild ISAR will still be used for a while.

I just tested mounting the pts with --bind an this also works. Will send out a v3 soon.

Felix

> 
> In general, we'd like to work on removing the few remaining recursive mounts
> from Isar due to various issues (exponential mounts, asymmetric umounts,
> umounting problems).
> 
> For debugging issues like "which package version was available in isar-apt when
> package X was being built", maybe we could evaluate something like an option
> for cp -al or similar.
> 
> With kind regards,
> Baurzhan.
> 
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email
> to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.g
> oogle.com%2Fd%2Fmsgid%2Fisar-
> users%2FYntt4IxrlQRYBG8F%2540ilbers.de&amp;data=05%7C01%7Cfelix.moess
> bauer%40siemens.com%7C8809ce5e859c4d5fa1dd08da3324c730%7C38ae3bcd
> 95794fd4addab42e1495d55a%7C1%7C0%7C637878530630108288%7CUnknow
> n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW
> wiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=d9yj%2B0wy7ubLiCA8jV
> DRUhc60r%2FcgD%2BG9uQDmSYyiWY%3D&amp;reserved=0.