RE: [PATCH v4 0/2] Improve handling of ISAR_RELEASE_CMD

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

Hi Anton,

> -----Original Message-----
> From: Anton Mikanovich <amikan@ilbers.de>
> Sent: Tuesday, November 16, 2021 7:10 PM
> To: Moessbauer, Felix (T RDA IOT SES-DE) <felix.moessbauer@siemens.com>;
> isar-users@googlegroups.com
> Cc: Schild, Henning (T RDA IOT SES-DE) <henning.schild@siemens.com>;
> Schmidt, Adriaan (T RDA IOT SES-DE) <adriaan.schmidt@siemens.com>
> Subject: Re: [PATCH v4 0/2] Improve handling of ISAR_RELEASE_CMD
> 
> 04.11.2021 14:05, Felix Moessbauer wrote:
> > Changes since v3:
> >
> > - add API changelog entry
> >
> > Changes since v2:
> >
> > - fix bug in update_etc_os_release
> > - Strip newlines from ISAR_RELEASE_CMD
> >
> > Changes since v1:
> >
> > - remove obsolete get_build_id function
> >
> > Felix Moessbauer (2):
> >    always invoke ISAR_RELEASE_CMD to invalidate downstream tasks on
> >      change
> >    Ensure generation of /etc/os-release is idempotent
> >
> >   RECIPE-API-CHANGELOG.md                       | 13 ++++++++
> >   meta/classes/image-postproc-extension.bbclass |  6 ++--
> >   meta/classes/image.bbclass                    | 32 ++++++++++---------
> >   meta/classes/rootfs.bbclass                   |  2 +-
> >   4 files changed, 34 insertions(+), 19 deletions(-)
> >
> This patchset fails on CI with the following error:
> 
> NOTE: Running task 171 of 173
> (mc:qemuamd64-bullseye:/meta-isar/recipes-core/images/isar-image-
> base.bb:do_image)
> ERROR: When reparsing
> mc:qemuamd64-bullseye:/meta-isar/recipes-core/images/isar-image-
> base.bb:do_rootfs_postprocess,
> the basehash value changed from
> 16a8399888ee56cde01e3fd03937f3847e0f945712e4183858f58527bebc58a7 to
> b01a488185cef694cbc7e29bf07d0cf9547355f6f00c79f664491eb058b91632.
> The metadata is not deterministic and this needs to be fixed.

Unfortunately I cannot reproduce this, but this is very likely related to a not idempotent ISAR_RELEASE_CMD.
As stated in the API changelog, the ISAR_RELEASE_CMD shall be idempotent (and technically must be for MC targets).
By that, no things like timestamps must be included.

If you point me to the location where the ISAR_RELEASE_CMD is set for CI builds, I can have a look.
Another issue could be that changes to the git happen during build (e.g. adding a tag, making the repo dirty, etc...).
In that case (starting with a clean build, ending up with a dirty one), the CI generated files have to be added to the .gitignore.

In Yocto there is a lengthy discussion about the idempotence sanity check [1] and why recipes have to be written in this way.

Best regards,
Felix

[1] https://patchwork.openembedded.org/patch/133517/
> 
> --
> Anton Mikanovich
> Promwad Ltd.
> External service provider of ilbers GmbH
> Maria-Merian-Str. 8
> 85521 Ottobrunn, Germany
> +49 (89) 122 67 24-0
> Commercial register Munich, HRB 214197
> General Manager: Baurzhan Ismagulov