RE: [PATCH 1/1] fix on-first-boot for systemd >= 247

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

> > Am Fri, 22 Jul 2022 00:04:04 +0200
> > schrieb Felix Moessbauer <felix.moessbauer@siemens.com>:
> >
> > > This patch fixes the bug that /etc/machine-id is never generated
> > > when running from within an initrd with an ro rootfs.
> > >
> > > In this case, the magic value "uninitialized" has to be used instead
> > > of deleting the file.
> > >
> > > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> > > ---
> > >  meta/classes/image-postproc-extension.bbclass | 9 ++++++++-
> > >  1 file changed, 8 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/meta/classes/image-postproc-extension.bbclass
> > > b/meta/classes/image-postproc-extension.bbclass index
> > > 0c412c0d..98c697b2 100644 ---
> > > a/meta/classes/image-postproc-extension.bbclass +++
> > > b/meta/classes/image-postproc-extension.bbclass @@ -56,8 +56,15 @@
> > > image_postprocess_mark() { ROOTFS_POSTPROCESS_COMMAND =+
> > > "image_postprocess_machine_id" image_postprocess_machine_id() {
> > >      # systemd(1) takes care of recreating the machine-id on first
> > > boot
> > > +    # for systemd < v247, remove the file, else set to uninitialized
> > > +    # (required if initramfs with ro root is used)
> > > +    SYSTEMD_VERSION=$( sudo chroot ${IMAGE_ROOTFS} dpkg-query
> > > --showformat='${source:Upstream-Version}' --show systemd )
> > > +    if dpkg --compare-versions "$SYSTEMD_VERSION" "lt" "247"; then
> > > +        sudo rm -f '${IMAGE_ROOTFS}/etc/machine-id'
> > > +    else
> > > +        echo "uninitialized" | sudo tee
> > > '${IMAGE_ROOTFS}/etc/machine-id'
> > > +    fi
> > >      sudo rm -f '${IMAGE_ROOTFS}/var/lib/dbus/machine-id'
> > > -    sudo rm -f '${IMAGE_ROOTFS}/etc/machine-id'
> >
> > I would keep the rm and follow up with a conditional write. Also i
> > found that /etc/machine-id seems to be 444 at least at the end of the
> > day. If it already is at that point, the tee might fail. And it might
> > be that we need to 444 it when we create it.
> 
> I thought about that as well, but to keep the access rights (which are not 444
> initially), I decided to not remove the file.

Just found out that systemd is not in all images we generate (e.g. the SDK).
This breaks the patch.
Will send out a v2 soon, with a detection if systemd is installed.

Felix

> 
> Felix
> 
> >
> > Henning
> >
> > >  }
> > >
> > >  ROOTFS_POSTPROCESS_COMMAND =+
> > "image_postprocess_sshd_key_regen"
> 
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email
> to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.g
> oogle.com%2Fd%2Fmsgid%2Fisar-
> users%2FAM9PR10MB4869C2A9537643BF92AB960589909%2540AM9PR10MB4
> 869.EURPRD10.PROD.OUTLOOK.COM&amp;data=05%7C01%7Cfelix.moessbau
> er%40siemens.com%7Cbff2e2353511402d995b08da6bbd768e%7C38ae3bcd957
> 94fd4addab42e1495d55a%7C1%7C0%7C637940758721837057%7CUnknown%7
> CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ
> XVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=rSoTRCqgcsncXBFPUX27Nkpj
> T8rM0mr%2FH6l3sDDu1fY%3D&amp;reserved=0.