RE: [PATCH v8 08/16] dpkg: Remove builddeps install task.

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

> -----Original Message-----
> From: isar-users@googlegroups.com <isar-users@googlegroups.com> On
> Behalf Of Uladzimir Bely
> Sent: Thursday, March 17, 2022 5:50 AM
> To: isar-users@googlegroups.com
> Subject: [PATCH v8 08/16] dpkg: Remove builddeps install task.
> 
> While builddeps are now handled interlnally by sbuild, we don't need a task to
> preinstall them in buildchroot.
> 
> But for the second local (base-apt) build we need a way to keep all dependencies
> in form of .deb files in DL_DIR. This is done by executing additional commands in
> sbuild that copy them to/from an externally mounted folder.
> 
> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> ---
>  meta/classes/dpkg.bbclass   | 44 ++++++++++++++-----------------------
>  meta/classes/sbuild.bbclass |  1 -
>  2 files changed, 17 insertions(+), 28 deletions(-)
> 
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass index
> b61d182d..b3931850 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -5,33 +5,6 @@ inherit dpkg-base
> 
>  PACKAGE_ARCH ?= "${DISTRO_ARCH}"
> 
> -# Install build dependencies for package
> -do_install_builddeps() {
> -    dpkg_do_mounts
> -    E="${@ isar_export_proxies(d)}"
> -    export DEB_BUILD_OPTIONS="${@ isar_deb_build_options(d)}"
> -    export DEB_BUILD_PROFILES="${@ isar_deb_build_profiles(d)}"
> -    distro="${DISTRO}"
> -    if [ ${ISAR_CROSS_COMPILE} -eq 1 ]; then
> -        distro="${HOST_DISTRO}"
> -    fi
> -
> -    deb_dl_dir_import "${BUILDCHROOT_DIR}" "${distro}"
> -    sudo -E chroot ${BUILDCHROOT_DIR} /isar/deps.sh \
> -        ${PP}/${PPS} ${PACKAGE_ARCH} --download-only
> -    deb_dl_dir_export "${BUILDCHROOT_DIR}" "${distro}"
> -    sudo -E chroot ${BUILDCHROOT_DIR} /isar/deps.sh \
> -        ${PP}/${PPS} ${PACKAGE_ARCH}
> -    dpkg_undo_mounts
> -}
> -
> -addtask install_builddeps after do_prepare_build before do_dpkg_build -
> do_install_builddeps[depends] += "isar-apt:do_cache_config"
> -# apt and reprepro may not run in parallel, acquire the Isar lock -
> do_install_builddeps[lockfiles] += "${REPO_ISAR_DIR}/isar.lock"
> -
> -addtask devshell after do_install_builddeps
> -
>  DPKG_PREBUILD_ENV_FILE="${WORKDIR}/dpkg_prebuild.env"
> 
>  do_prepare_build_append() {
> @@ -65,6 +38,16 @@ dpkg_runbuild() {
>          bbwarn "Export of '${line}' detected, please migrate to templates"
>      done
> 
> +    distro="${DISTRO}"
> +    if [ ${ISAR_CROSS_COMPILE} -eq 1 ]; then
> +        distro="${HOST_DISTRO}"
> +    fi
> +
> +    deb_dl_dir_import "${WORKDIR}/rootfs" "${distro}"
> +
> +    deb_dir="/var/cache/apt/archives/"
> +    ext_deb_dir="/home/builder/${PN}/rootfs/${deb_dir}"
Hi,

please use the PP variable from dpkg-base.bbclass here:
ext_root="${PP}/rootfs"

Felix