RE: [PATCH] override HOME to isolate sbuild configuration

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

> -----Original Message-----
> From: Schild, Henning (T CED SES-DE) <henning.schild@siemens.com>
> Sent: Tuesday, September 20, 2022 12:59 PM
> To: Moessbauer, Felix (T CED SES-DE) <felix.moessbauer@siemens.com>
> Cc: isar-users@googlegroups.com; Bezdeka, Florian (T CED SES-DE)
> <florian.bezdeka@siemens.com>
> Subject: Re: [PATCH] override HOME to isolate sbuild configuration
> 
> Am Tue, 20 Sep 2022 11:26:54 +0200
> schrieb Felix Moessbauer <felix.moessbauer@siemens.com>:
> 
> > This patch sets the HOME env var to the package build path to avoid
> > conflicts with an existing .sbuildrc configuration in the users
> > homedir.
> >
> > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> > ---
> >  meta/classes/dpkg.bbclass | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> > index c92ea7db..70f8e772 100644
> > --- a/meta/classes/dpkg.bbclass
> > +++ b/meta/classes/dpkg.bbclass
> > @@ -17,6 +17,8 @@ dpkg_runbuild() {
> >      E="${@ isar_export_ccache(d)}"
> >      export DEB_BUILD_OPTIONS="${@ isar_deb_build_options(d)}"
> >      export PARALLEL_MAKE="${PARALLEL_MAKE}"
> > +    # override HOME to not interfer with users .sbuildrc
> > +    export HOME="${PP}"
> 
> This is not kas, maybe people want that from isar. And if they do not want it they
> can use kas.
> 
> I would bbwarn on -f ~/.sbuildrc, setting HOME to something else is pretty heavy
> and can have all sorts of fun side-effects.

I had the funny side effect that I could not build with ISAR on my sbuild + unshare enabled host.
Had a hard time to figure out why this did not work, especially as the sbuild man page is not very precise on the effect of the SBUILD_CONFIG env var.

Setting HOME there is only relevant for the sbuild invocation and also there, the HOME variable is set but quite pointless as everything happens inside the schroot.
AFAIK there is no statement in the user_manual.md regarding the configuration of host tools.

Let's put Anton in CC to get a statement from an maintainer of ISAR.

Felix

> 
> Henning
> 
> >      rm -f ${SBUILD_CONFIG}
> >