From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7044234567900725248 X-Received: by 2002:a05:6000:1b03:: with SMTP id f3mr29624616wrz.58.1640949797198; Fri, 31 Dec 2021 03:23:17 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:3b56:: with SMTP id i83ls1020823wma.0.canary-gmail; Fri, 31 Dec 2021 03:23:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJxU6zc9q6uZqaGLdc4U7EvmnyRfXNyLXxcrCa14VX8uqJJOGsLT8H1nPgwpn0nsEACOynDC X-Received: by 2002:a05:600c:2902:: with SMTP id i2mr29884905wmd.97.1640949796268; Fri, 31 Dec 2021 03:23:16 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1640949796; cv=pass; d=google.com; s=arc-20160816; b=LvnyyW8afIiLDKlWeeAj6xqO31Nj4b3BCE8IkqYBojhmvj5I1c3hVQpX3JM1cNcxp5 MdMc5bMiZaKBFGj7Zh37Dck7+/5uACDNtMLY/XA2q7KHWw4SwhlEO18A7PKhlIrB8s/1 YahB6J7D6gjjutoyn449vHwABNulqgI4ofEaITJCyeLCpyaUx3LDJIKva/Mvp8NCXDVg ZjW3A7oQNuwHwWmYQkTPx3xpqQSEEMsA02v5ZgXw1zTJsOwilPnBzJcrfAjPdm6r/2va fktKWUaq1Zbxh3gp9VujQ/fBbvc5xnL6U5csgqDPBG7o8I9tftNrbA03fgsxYc/w8B8f YK6Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:document_confidentiality :msip_labels:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=aVUDE6cqW3Ey4owzsqxNPF4G3QIBqUbMu4R7beGvj6c=; b=wlbI8xu7j8TE6ZP7RG+h4wppIbDMw8eV6GOnDvRpcjbefLx+/ShjzsYlzlcLFa82Tj lwnumbIT4tHqvJ39VP7J0ZQjuimkSt5Sa578yq87XidO2U7wEpyvm/xssA3vOOvUleNO 7Urrq32fbkcCJKhezf3OArN+5cFOoMRbAN5O7JzxgQ6vd2uQOX2Dj0GLRi5sIxrNs4Lv 2gQI8c3YMZ5QuN38cpU0Tf5e77f5XHMRz+jjnMJypShUcpSRSZyqD9tZnZXE9nUeBD4w btpLbcjaC06p3eJpb/Gc8+x6tE+9OaeAvqYV+24Y8nMYUyD11xCJNhTHYjiv0OCnIXWY bdlw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=bh5QAEni; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.8.51 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80051.outbound.protection.outlook.com. [40.107.8.51]) by gmr-mx.google.com with ESMTPS id o29si1037088wms.1.2021.12.31.03.23.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Dec 2021 03:23:16 -0800 (PST) Received-SPF: pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.8.51 as permitted sender) client-ip=40.107.8.51; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=bh5QAEni; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.8.51 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hdgpcQ2ygYOxWD6v6l3ryWruqEmHVfMkrzeFNlfzk5C9C91eRk5E0Q9/qcQ8TW6V1pK4nQPEYRoaaF9C61iIr+aJTxpnVOJcrrvZ0yq8YoV0uhAkigw+0PiFqXyR9ETp58/n6NcMIGYFnYyszeuH7fOcTi36hmGfY+SsLj0KbwMU/ou0eFQMEZ8FuribabhuAEvrkLcFV/38RdvSDBgDp4tibAbjF1lei7V4rlpd6qngEUPPX30Op4v+s/lxWRRP21n9NpWz7akE9TJMh79fKrNxlR6haYcMf2lzH+XR5bAJ8AEsZIvuG//KfNKYCZuIzG+Kha2oE8fN/l/LQ16GWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aVUDE6cqW3Ey4owzsqxNPF4G3QIBqUbMu4R7beGvj6c=; b=jZgugt+oIoSQil7M45qctzq+T/gD9wEaaRisbcNk7UjkjPIW9pzGBGjPUJwC7TH6fySjHw/cgqUV0cuXVejmwDuVzyKrjMlNFydDDvoAHURIQEc4OtPh1y03YNPGPGF0sv8PaxMPVR+hadD1Zsby5Tqh3eYgZPrqizTaLHDxqu6muPVc9nH6j2S5hI/G0Q3OwW4yE4BwomLltkg9fpDkbg9jmHD2aF+xqr55y2ZIq7puFpLSsQzIkxttkGo0FY5QGE+zOcG4PZbZYG5K9i66wx7vMO01PjrLzhSy/x3dY3N4zra9TIYPbQQjp4RyWkur8yMrDAvBMuSQDX2O09pW9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aVUDE6cqW3Ey4owzsqxNPF4G3QIBqUbMu4R7beGvj6c=; b=bh5QAEniGtmQu+wlLRiyccP9/L4Jjc7wHuIy2qh2OcNbuisZdLdGdUPhSOeCv1jMmL+7Lq/NO4c8pjIoyYa3oAJyZDhwUjzS13R3WqFtkbRouAmC8p5uhCXzEwjRLnZN7zgY6w3asXgDz5zo9CI05kzMNnjYFrpFEBSzgH2RlP70fs4Xo6cUly0KHQaH8CqVn6wzhKVyZ8GzjgRUWdCQUVcuFnFt+Jl4UnKWzfZqKd99POm6o+6Aonv8FGW+AAhrS1hpTqg3SvtOBdJiWbhcOEca/bLEKGtWIFiqYlx63FyZYzAuERiKRpT4ZOgEMKtvkHDaCTmgyEqAypnRhtf+lg== Received: from AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:418::19) by AM0PR10MB1972.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:43::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.14; Fri, 31 Dec 2021 11:23:14 +0000 Received: from AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM ([fe80::38ad:c02d:d88e:1c7f]) by AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM ([fe80::38ad:c02d:d88e:1c7f%6]) with mapi id 15.20.4823.024; Fri, 31 Dec 2021 11:23:14 +0000 From: "Moessbauer, Felix" To: vijai kumar CC: isar-users , "jan.kiszka@siemens.com" Subject: RE: [PATCH 1/1] add support for debian build profiles Thread-Topic: [PATCH 1/1] add support for debian build profiles Thread-Index: AQHX9p4Kje2cPWQhp0m9AfrRSlrmAKw9bMCAgA8NgNA= Date: Fri, 31 Dec 2021 11:23:14 +0000 Message-ID: References: <20211221190653.1142246-1-felix.moessbauer@siemens.com> In-Reply-To: Accept-Language: en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Enabled=true; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SetDate=2021-12-31T11:23:11Z; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Method=Standard; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Name=restricted-default; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ActionId=36a78379-0f4f-488b-abcd-c90c4e789672; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ContentBits=0 document_confidentiality: Restricted authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a6056d3-ce4c-497a-c737-08d9cc4fef7b x-ms-traffictypediagnostic: AM0PR10MB1972:EE_ x-ld-processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F381NdTvALjFaUDXeDu4JzvFoQWnmo56tpYrkge6xSG9X/6Jy1x8ZNjIBxzlhDrxq665IeFjVT5YGg72g8PGzUyxibIgMjMr8vSuIdZNH4NCUVqR8jFeBrIpExLmXrl1Vg5oUA7oC/wf/zCbGB9IiDLcKkaY2lORJc35xrnzrBDI8pFM6zxrfK5CwN82HtYCz50B9jtsbp+YlH2UJoYkvT1q05/oOGbubxvelL5JOXoyYtrwalPq3zW0HA0kKPGasH0fz49JgfzBkqHszIo6HOX2QPfqvJAj+dlNxjWCKqrqVMEtecUMgbgzAr1A8IWO83eeMnxquWD5ud0sEoS5ge3riLwdW946UrZTVo6aVykrvxwHRX+bh+h/anqVG2Bws3R7y9ml8ONvAOkgmxWotxMOCVVI1B4M7dUEb8aTahk07w0zYmz8YZC8PL+neXeUwWAdQyysif240/jMuwvy74YWxMJBpWg+BOwyb2znqwlvUaVftFYV4Q5K4vjQ6uQVzGOWqoWuRvxKeybOzYyRgmxKikK3bwGxqXdmFtv7TJROC/W6+8J7TSh3FS3wItIl4s/mNFZthvpD6BCu4BlRgKvrkx1yOeK32xKL0r187C9Sg8AX0vIB18yk2Ey2aM466zPh57nFq2/0bz55qqDBWDtju+G05KNRKsNUqpNaCFJ/TysuU2/42hf0Eou9TlP1eQUwUIxFZDEjj4g7aWHvlC3pJFBT8XdDI+9zRr3lLKdL13fnmsifGqD1P+5UxeRq6AS3imoCEaUtKQiibMkEiP4SsfaibLyMztQuHj1GbMw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(366004)(55016003)(76116006)(498600001)(38100700002)(71200400001)(966005)(52536014)(2906002)(186003)(6506007)(66556008)(66446008)(8936002)(7696005)(66476007)(53546011)(26005)(64756008)(82960400001)(38070700005)(122000001)(86362001)(66946007)(33656002)(83380400001)(6916009)(4326008)(45080400002)(54906003)(107886003)(9686003)(5660300002)(8676002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dSRo8V6WSyBkHxzazeYA/RLaNbdvFm2A8CVusA/p63BEM/A0mRahsSSscbHY?= =?us-ascii?Q?fDNM7Y9tehj+vyQ7y37Xcwt45VKJOAlYhtmSCNjSLJue2nH+0GXxJqVcp4cF?= =?us-ascii?Q?w16rNZg8PT2lB5+pbe47hVbNuDPAA3A7+IyBAZ9y5jp7VvZjkHqVXHRpj4Vc?= =?us-ascii?Q?GB6xUwi6ygXgL0JpE7aerb11d5b+Z3M3LxRmaAV8iwcmaPPAMJ5fbJj59ghW?= =?us-ascii?Q?Bmglp7Zb4lsINR57NbkFqR+oh0Piu5Yuh+dy3JkWv7RMDolnBFY6tPSTQMUT?= =?us-ascii?Q?QTA33jR2cjMnoUHo1E7OU0tOEYeAMMg7mHGvhno+3P153h09f3hAaCQS+uEj?= =?us-ascii?Q?drGNOhiHd+7vty9f9c9atq2vSyMEg99XrRfbRde9/BG0kcXmFTu6DoovdlVl?= =?us-ascii?Q?pn5XIQOYJ3UVZFuCmlPOiTnmfutKfsHWk+PqCw5k2hH2HvvDB0MB+z11Gm6z?= =?us-ascii?Q?w9kLNt26FU/Ai2jHrcVlslBC7LzgoZjnjagOp0QdpW0IpCcDjgJlYUtI8rGD?= =?us-ascii?Q?eDpQ4pQ1BS2EKprWKamGKLBRI+m7PKJcqlPMtIUwDSLJc4ID29BYAjMUtl54?= =?us-ascii?Q?6LV+JueB2MjYXiidj/Js5PoR62Qpm+DqNqfDF8DV1WoOTXI4Oqs5jpSbFyXm?= =?us-ascii?Q?uG6DOmzeY1KBxVG8mkxD8JdIFGdwSheybzWVhqdi1x25oxezJ+3FdKLqdKXc?= =?us-ascii?Q?ecooSmXaCxBLFLwvHks/ncjZGWmwcx4NYHNnOLUx3baz3b1TJxJ8/18oedfd?= =?us-ascii?Q?LqAoAED2ION8tkVNY5KSuMlL8YsjT05qXvHw9JHUhPe8KlMpNOp4wh+FFTl1?= =?us-ascii?Q?mL0TKQCHQA6qZCWMSH4mtveVaAmHpdPXnbU5EYMbNqYuXMQw5a0SObkVmIEg?= =?us-ascii?Q?dGyvp+1iaL5uMLKZrfGoEMmRg4+mfr+y5+CYf9eT4Vdeg9W3QA6id9547yDU?= =?us-ascii?Q?ms3SH3aS6MA3c0Fk0Bawk6UEonTV37xliw387TNWh6iJEfWbFKC1rdLjD8T5?= =?us-ascii?Q?NWszcaP0arofjXiaJ/BAIeJuDMuZHEeRugssHSnYwQ3SkMaZtFFP6I9QDBtq?= =?us-ascii?Q?xcAhz4kuDNorlPMcdgNIlx/jIIF1PdMSdkDndVIBkPEgT5b5P1PRzRwq1+Gh?= =?us-ascii?Q?hmb8TM+R99ijpBJL8bdDgjHWgF96wWOdM7ksxCxeF6wywwx9x6UE5btTNRvB?= =?us-ascii?Q?5X+xbZm/SMMnGEyO2OfNeiaPnNlJoc06t9wdG7WOnDYhSI7qaKTPB7X6iYx/?= =?us-ascii?Q?N6u3r09Jup0ZkCf0OQ0fypXLwjuafhpg3sKMSphI7T0xU9201V1hdGRXVAP5?= =?us-ascii?Q?v0Y7/f1gb/8nlFKrDDmWNg95qRZd+/9cQsBT63oBkO3uUT1qIKd6yUoQ2lv0?= =?us-ascii?Q?+Zh08d9PFFIsIOfiAtrlbyLiG7CnfXHIiyCZ03R+iAiMdlk0vAoB5Ee5rEhv?= =?us-ascii?Q?ersIzZfUpzlmxQsDTFjzHmwq1EZ8iIIG3Jz+j/vlu11fEw0Hw5KrDwtscNd4?= =?us-ascii?Q?v+QtCitj3VwCPRD1p27ogeDkwIAmSpfb21FNMr3ZfuKENbbgygGBwAnsMQf5?= =?us-ascii?Q?q6TPFh6c4YlKnOOPP4sfR6UbSd9Bw4zvm8SWUi0dP3re/1ohUJmvPndy+j6t?= =?us-ascii?Q?ta9nEAtk5hjAkQv8YiSZY3nbTK9maMK+8OC1Y3i2iPboI/ENevz9Cj65Qj2r?= =?us-ascii?Q?cwUGpQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 2a6056d3-ce4c-497a-c737-08d9cc4fef7b X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Dec 2021 11:23:14.1047 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x0pQ9BETpMarKZxhG0ogOle9CrkdYd1K29DgXXfgNGpFDLrodpGlWIO5klgSUygdg27Nlyx07T4rCwRRmZavP9ALnG7B4FcxlZfupdm1o9Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB1972 X-TUID: OxzMu6yDK0rg Hi Vijai, > -----Original Message----- > From: isar-users@googlegroups.com On > Behalf Of vijai kumar > Sent: Tuesday, December 21, 2021 9:55 PM > To: Moessbauer, Felix (T RDA IOT SES-DE) > Cc: isar-users ; Kiszka, Jan (T RDA IOT) > > Subject: Re: [PATCH 1/1] add support for debian build profiles >=20 > On Wed, Dec 22, 2021 at 12:37 AM Felix Moessbauer > wrote: > > > > This patch adds the bitbake variables DEB_BUILD_PROFILES and > > DEB_BUILD_PROFILES_CROSS. > > The values of these variables are used to define the > > DEB_BUILD_PROFILES environment variable. > > > > When cross-compiling, the DEB_BUILD_PROFILES_CROSS variable is > > defaulted to "cross", to be consistent with upstream debian. > > > > Signed-off-by: Felix Moessbauer > > --- > > RECIPE-API-CHANGELOG.md | 8 ++++++++ > > meta/classes/dpkg-base.bbclass | 12 ++++++++++++ > > meta/classes/dpkg.bbclass | 5 ++--- > > 3 files changed, 22 insertions(+), 3 deletions(-) > > > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md index > > 55836258..f95f7db5 100644 > > --- a/RECIPE-API-CHANGELOG.md > > +++ b/RECIPE-API-CHANGELOG.md > > @@ -306,3 +306,11 @@ When using the plugins it is advised to name the > > partition "/boot" and to exclud > > > > The variable is renamed to get closer to OE/Poky variables naming. > > The old naming will still also work, but with deprecation warning show= n. > > + > > +### Introduce debian build profiles > > + > > +All recipes that inherit from dpkg and dpkg-base can utilize the varia= bles > DEB_BUILD_PROFILES and DEB_BUILD_PROFILES_CROSS. > > +These variables define the DEB_BUILD_PROFILES environment variable whi= ch > is available in do_install_builddeps and do_dpkg_build. > > +The DEB_BUILD_PROFILES_CROSS bitbake variable is set to "cross" when > cross compiling. >=20 > Hi Felix, >=20 > Thank you for the patch. >=20 > We could modify the u-boot recipe to have it as an example. Good idea, I'll send a v2 out next week. >=20 > Also, It might be useful if we can say something about custom profile nam= es. > Debian has a standard[1] for those. > pkg.$sourcepackage.$anything That's true, but is it really the responsibility of ISAR to ensure that dev= elopers follow the Debian best practices? I doubt that. I would better only document ISAR specific stuff but avoid re= -documenting Debian policies / best practices. >=20 > Better to recommend users to follow it, to make sure they don't accidenta= lly > reuse one of the registered profile names when creating custom profiles. >=20 > [1] > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fwiki.= debi > an.org%2FBuildProfileSpec&data=3D04%7C01%7Cfelix.moessbauer%40sieme > ns.com%7C5bf5db77529f46681e4108d9c4c4297a%7C38ae3bcd95794fd4addab > 42e1495d55a%7C1%7C0%7C637757170088619029%7CUnknown%7CTWFpbGZs > b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > %3D%7C3000&sdata=3DaExYnPwm%2F2hvZ%2BkhJQA4Y%2BWfKRGfxet%2B > T1na%2FdpIgSQ%3D&reserved=3D0 >=20 > > + > > + > > diff --git a/meta/classes/dpkg-base.bbclass > > b/meta/classes/dpkg-base.bbclass index 6704385b..c1588528 100644 > > --- a/meta/classes/dpkg-base.bbclass > > +++ b/meta/classes/dpkg-base.bbclass > > @@ -13,6 +13,8 @@ inherit deb-dl-dir > > DEPENDS ?=3D "" > > > > DEPENDS_append_riscv64 =3D "${@' crossbuild-essential-riscv64' if > d.getVar('ISAR_CROSS_COMPILE', True) =3D=3D '1' and d.getVar('PN') !=3D '= crossbuild- > essential-riscv64' else ''}" > > +DEB_BUILD_PROFILES ?=3D "" > > +DEB_BUILD_PROFILES_CROSS ?=3D "cross" >=20 > Do we really need two variables? Is the DEB_BUILD_PROFILES not sufficient= ? Well... I implemented this patch series while working on a layer that has t= o support both arm64 and x64. With just one variable the inline python functions became a pattern because= (depending on the package), various profiles had to be activated only for = arm64 (e.g. like "nocheck", "nodoc"). That's why I prefer to have both variables. Is there any strong reason against it (apart from having two variables to m= aintain)? >=20 > > > > python do_adjust_git() { > > import subprocess > > @@ -201,7 +203,16 @@ dpkg_runbuild() { > > die "This should never be called, overwrite it in your derived cla= ss" > > } > > > > +def isar_export_build_profiles(d): > > + import os > > + deb_build_profiles =3D os.environ['DEB_BUILD_PROFILES'] if > 'DEB_BUILD_PROFILES' in os.environ else '' >=20 > Ideally the user should set DEB_BUILD_PROFILES in the recipe and the belo= w line > would be sufficient. That's for backward compatibility. We already have a ton of recipes where t= he profiles are manually activated by exporting the DEB_BUILD_PROFILES in t= he do_install_builddeps and do_dpkg_build step. IMO it's not good to "magically" overwrite environment variables, but your = points are also valid. >=20 > > + deb_build_profiles +=3D ' ' + d.getVar('DEB_BUILD_PROFILES', True) > > + if d.getVar("ISAR_CROSS_COMPILE") =3D=3D "1": > > + deb_build_profiles +=3D ' ' + > > + d.getVar('DEB_BUILD_PROFILES_CROSS', True) >=20 > Probably we can directly add "cross" and drop DEB_BUILD_PROFILES_CROSS See my comment above. >=20 > > + os.environ['DEB_BUILD_PROFILES'] =3D deb_build_profiles.strip() > > + > > python do_dpkg_build() { > > + isar_export_build_profiles(d) > > lock =3D bb.utils.lockfile(d.getVar("REPO_ISAR_DIR") + "/isar.lock= ", > > shared=3DTrue) > > bb.build.exec_func("dpkg_do_mounts", d) @@ -278,6 +289,7 @@ > > python do_devshell() { > > bb.build.exec_func('dpkg_do_mounts', d) > > > > isar_export_proxies(d) > > + isar_export_build_profiles(d) > > > > buildchroot =3D d.getVar('BUILDCHROOT_DIR') > > pp_pps =3D os.path.join(d.getVar('PP'), d.getVar('PPS')) diff --gi= t > > a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass index > > 7da73341..8e5626e8 100644 > > --- a/meta/classes/dpkg.bbclass > > +++ b/meta/classes/dpkg.bbclass > > @@ -9,10 +9,9 @@ PACKAGE_ARCH ?=3D "${DISTRO_ARCH}" > > do_install_builddeps() { > > dpkg_do_mounts > > E=3D"${@ isar_export_proxies(d)}" > > + E=3D"${@ isar_export_build_profiles(d)}" > > distro=3D"${DISTRO}" > > - if [ ${ISAR_CROSS_COMPILE} -eq 1 ]; then > > - distro=3D"${HOST_DISTRO}" > > - fi >=20 > Probably a mistake dropping the above lines? Good catch! Yes, that's a mistake. Will be fixed in v2. Felix! >=20 > Thanks, > Vijai Kumar K >=20 > > + > > deb_dl_dir_import "${BUILDCHROOT_DIR}" "${distro}" > > sudo -E chroot ${BUILDCHROOT_DIR} /isar/deps.sh \ > > ${PP}/${PPS} ${PACKAGE_ARCH} --download-only > > -- > > 2.30.2 > > > > -- > > You received this message because you are subscribed to the Google Grou= ps > "isar-users" group. > > To unsubscribe from this group and stop receiving emails from it, send = an > email to isar-users+unsubscribe@googlegroups.com. > > To view this discussion on the web visit > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgroup= s.g > oogle.com%2Fd%2Fmsgid%2Fisar-users%2F20211221190653.1142246-1- > felix.moessbauer%2540siemens.com&data=3D04%7C01%7Cfelix.moessbauer > %40siemens.com%7C5bf5db77529f46681e4108d9c4c4297a%7C38ae3bcd95794 > fd4addab42e1495d55a%7C1%7C0%7C637757170088619029%7CUnknown%7CT > WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV > CI6Mn0%3D%7C3000&sdata=3DeCOTmdSafQe7QH5a%2BG6CmdvqmUXyse9 > K06QPIZHVXMM%3D&reserved=3D0. >=20 > -- > You received this message because you are subscribed to the Google Groups > "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an= email > to isar-users+unsubscribe@googlegroups.com. > To view this discussion on the web visit > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgroup= s.g > oogle.com%2Fd%2Fmsgid%2Fisar- > users%2FCALLGG_J19GiSTcmyOgOeUftatj2kkbZMaVZReJYRon_YAmJBmA%2540 > mail.gmail.com&data=3D04%7C01%7Cfelix.moessbauer%40siemens.com%7C > 5bf5db77529f46681e4108d9c4c4297a%7C38ae3bcd95794fd4addab42e1495d55 > a%7C1%7C0%7C637757170088619029%7CUnknown%7CTWFpbGZsb3d8eyJWIj > oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300 > 0&sdata=3DKXiRwZVA0MUjQCThhD5SZ5r4DmvkqiAj5692jiNAIfw%3D&re > served=3D0.