From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7108629846932062208 X-Received: by 2002:a19:f515:0:b0:49e:da3d:1710 with SMTP id j21-20020a19f515000000b0049eda3d1710mr8174872lfb.600.1664179380860; Mon, 26 Sep 2022 01:03:00 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3b0:b0:49b:8c05:71a5 with SMTP id v16-20020a05651203b000b0049b8c0571a5ls627868lfp.0.-pod-prod-gmail; Mon, 26 Sep 2022 01:02:57 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5ub1TIuI5l6H1QsCeZZbwp3YYlV0js0d82oZ4HzHTgcdlbdgFc3WWP4BBn/JAujWHbydQH X-Received: by 2002:a05:6512:3d29:b0:498:fcd5:571a with SMTP id d41-20020a0565123d2900b00498fcd5571amr8706647lfv.70.1664179377708; Mon, 26 Sep 2022 01:02:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1664179377; cv=pass; d=google.com; s=arc-20160816; b=bTbh16JyXbTVs/zvPHGPfi9E0rz7zrROAbHiKwSjo1IgP1oo+kBSsd1QDARmuzNgD/ gO8pWRJ5JvfgqadsnD4fu/M6kwTSJ1l0rL167eb84EK3Ro6nU6ggrdb64vpXFGTVvZem wESeHiWB7ESOGlqroQY8pA8lH/N9XNZLviMrBRjsGSerBs1F48oBpa8Cprgo9zuUQg5J gviTtQ7o2qjMqARrYezMqFcXaGFCF2Wi8aMroRgbyLmgHQ6mgsVKav+BtKsJ9J1TG3lL LYPJ8Y9PhNN+xxxuEVWwvHGdAZv42Bcu9vQZxGQhum16f7byBaVyMuER8rXV1p+nEhJX ybYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:document_confidentiality :msip_labels:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=gue1DTKGtnLkrdN4ufsSlQ83S09Y5e4O05wUq51CKng=; b=QFrqeJYJ8yENs7GTCWVlCn5N6uxbL7LA3cLjRAq+e40R54xeKTdNwNqZfMsLIDC6T3 mUqT/6TSvGa8i0Ta78tgb8NycN5DOCPPXaIV4Up/sklCG83dGpNUl4bSL9dmvw9ykWEJ 0GlVFhx1kpLn6aiD5QOU/VjFj4+vDycAZk2KYpxJtWzQ+xHymWx0wb/RvM7iG5KtUBi6 okU8Nr3Dawbd1686gEL8XyGcOBNWjQp3PZBPqvuNXM0XMB5uVf/lzJ1iWiQlA76m/XXp TnGeJQcBKR6nUtKtrdlwYRDBee2EwWcIZ70W/42tjg6il5IureFj52Cm8VcE5e9eKi22 utyQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=ifmOqSDY; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.13.81 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130081.outbound.protection.outlook.com. [40.107.13.81]) by gmr-mx.google.com with ESMTPS id x9-20020a056512078900b00499b6fc70ecsi586450lfr.1.2022.09.26.01.02.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Sep 2022 01:02:57 -0700 (PDT) Received-SPF: pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.13.81 as permitted sender) client-ip=40.107.13.81; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=ifmOqSDY; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.13.81 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PzUvQ2bBdym5RIhevq2bAN4rU9ZhQfprHG+TnTgyynT2nOBm2rCyfelHMCehqB43JAdseAJm55n2AWOUK6gj9NC7dEwNyogQ8vzp2AK97FRzpuieqwzQc0l9dNgqMRtQzkWVnw5aD2o1xB/RPVJ/F+jNzD0cKeUA2kpuNZTqdJjB7ooFzelVqxj4TzhdlacEoe4D7PNTfJQQ2/veZj/nuRreINaIpck4bH+0dU+STn/9eDXOHt6CntJSBwmewHa/czKfl3KKo63aEMsVGNIdxIqenLYUZne0QaM5rfqQ8SMDpgKvqMv7w3Nrb+fqiClIIgKZdWUwDbifknNdeA9Gzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gue1DTKGtnLkrdN4ufsSlQ83S09Y5e4O05wUq51CKng=; b=jENmF7UljR0IGv9MODlsJsqVqFZ2V8scu9kotqDM03WX73sQo4A31S1qKdB7AfX27r+BENhwxCgFZsnJkGE+e01cyeP6mCWL/+gx3GXOwhqJW42iPpWAGi4zmt1UuKcMGZe2lMEi5FMX2tNl2NroTejaY+MLeVywTK4jGLvxvdcEkgKAMQkGXj3BL/BwHYJhXKUmi1boiumPFfi60uHsMAysilOEOthWnKbSPFY1htU6+QoRTsstAoIVYhDgBtv7wD9Kwyy+oGgTjMPR0zhywY95rMfaEE5DnGkZ0EyDMWoR388YiukAHbpEs8hh+swdgej3pQnuid2D84UzGArA2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gue1DTKGtnLkrdN4ufsSlQ83S09Y5e4O05wUq51CKng=; b=ifmOqSDYlMHSRxdRwaezXvcnfrQ4d2MmFXRfHNwvijjwLaC2aEi1i1erWPPosaBfB2pBOonYcRGBPUWfVWL4xKgcCr+RQaGgV4VxPrRNcfGqjFSN7abB/17thGKFTLifbxDe/jcyQuhdj4sWL8XFkPKLp8fwJtuH+vzLSvWTb71aJ2Ux+XLeE75i/jkY56XXik8FdhnswE9aCXSeb9xm2kY1RM6klZDEUrz3GjVLeUbCPjgaV6InylrVnQ+26ZXzorGkx/A3BEFjY1iuN3+Rdo6InMtizefhDq3aFzwd95uYJQI3jdP4dcTpiVMWxSx4uiTOH4GGwUiRTadYTqrapA== Received: from AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:418::19) by DB9PR10MB5526.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:309::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Mon, 26 Sep 2022 08:02:55 +0000 Received: from AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM ([fe80::c4af:eadd:4808:738d]) by AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM ([fe80::c4af:eadd:4808:738d%7]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 08:02:55 +0000 From: "Moessbauer, Felix" To: "Kanagarajan, Vijaikumar" , "Schild, Henning" , "jan.kiszka@siemens.com" CC: "isar-users@googlegroups.com" Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision Thread-Topic: [PATCH v2 2/2] wic: Update to the latest revision Thread-Index: AQHYfvrQK6SOklEV50OiVPoB2xycY61Nf+UA//+ObwCABg6wgICdCxAQgAGhwgCAAAxtAIAAI/2AgAAC2QCAAAEKEA== Date: Mon, 26 Sep 2022 08:02:55 +0000 Message-ID: References: <20220613075401.2059119-1-Vijaikumar_Kanagarajan@mentor.com> <20220613075401.2059119-3-Vijaikumar_Kanagarajan@mentor.com> <20220613110206.0fa05e12@md1za8fc.ad001.siemens.net> <476c6e8a8687499a85fced0e07299815@mentor.com> <8babb01d7eae44e0b9faecad59cdc1d4@mentor.com> <6157334379c44f8b938983d5c4dfd8b1@mentor.com> <20220926094138.36c36a30@md1za8fc.ad001.siemens.net> <7d23828243444e90afd49e7bb23717dc@mentor.com> In-Reply-To: <7d23828243444e90afd49e7bb23717dc@mentor.com> Accept-Language: en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Enabled=true; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_SetDate=2022-09-26T08:02:51Z; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Method=Standard; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Name=restricted; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_ActionId=1aaf57c5-e20b-4ba5-b183-c775e02381e6; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_ContentBits=0 document_confidentiality: Restricted authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM9PR10MB4869:EE_|DB9PR10MB5526:EE_ x-ms-office365-filtering-correlation-id: fa12fbd4-49c0-4027-4732-08da9f9584ba x-ld-processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MD2DAnUDRz2oLJQVHUaAtXlp4JH+iXh4dO5XE9MF/aoXWibWDhUhZOaP4mVI9euEOuaPMMnTS4IEFp9wEkhKz/PL87uHaUP2sv10k5XpmLwkytxh675ICtcYaAlSGF3KyicG6hb30d2BsfABf6vuOoH0E89R4cT/bmL5X4QE2UNlAs8To0MZT8TFmKg0MspU7+DTT8QDMDO9A0O4gfwEm5IVElnsQOS+7OtKaktXG9zaXhJK4fF3AYzEfCQBRp2hLgLiPO6DKcdNa2tF/Fa+8cNNoYhrX5KLEO/y7Pim6sHxbbOoxIxgCr5bqGX9dW9WwQOn4VDc1rl5yTOaqpgUGZb5b8hPO+9BNV0lt+QJy97GwZjfsPJlHh6WX/sSCafX4boOYTTfAYhHZ5OOau5kX+9pxopUOtye9kK6y+EuuowQ1CCwneTHRaACSBqdfziSIhbTydHlfF1pGOuVK5CXBv8mEmKn1KLYl6CTj0A6aJohefOKoXwM1WU0mb03ulNYYvFwAv01ENo8EJk6F4c5nUe8ACxnPJpcm8fYxeslbFYGSAHxEsRxlH6Hs5lTrjql9YJOEWJtjNJYaJqTadh3Gg9mJA4y+vJmcUXaB2AlsKA9WVUOx18tJT6p7Y6f6XH2Nbjz8wRkUdVFaP+jaj23xy0D2/7ecux/wKbkx6IeE0b1Larm32MViCok4w5lrS2360PeMThtDyGnqD2nw4FpspoRp4K3lQozHOVhuGUixWCQ6/XVSU/R0LOWvsbTboTOGSp16n5rtvbnO+WlEZDOGotZLaVTcvWZwAp0FgI8POI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(366004)(346002)(396003)(39860400002)(451199015)(26005)(30864003)(41300700001)(2906002)(9686003)(316002)(6506007)(53546011)(15650500001)(7696005)(8676002)(82960400001)(55016003)(45080400002)(8936002)(66946007)(66556008)(6636002)(66476007)(64756008)(66446008)(76116006)(4326008)(83380400001)(38070700005)(966005)(478600001)(71200400001)(186003)(122000001)(38100700002)(110136005)(86362001)(33656002)(5660300002)(52536014);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ap7YMgYEuio5J/M+09A4EEPSYnOUuuHxNBPpYqJnFJkXOhdo/tWoyXUwKd/c?= =?us-ascii?Q?vfezK7XssSg2lqn9A8Wbpl30o1bm4n+I1vrMGSyuylOHL65/GVqHaKoOcmpV?= =?us-ascii?Q?WMBhdDT3q+0CJN8a+zEeaTVFJafWQFx1xMZGcpX0QB2OsLT2ZYEthFJMGMtV?= =?us-ascii?Q?v04kP7uMRjEYn0GN2SY0Ea21JRuZ0N9KoWln9Jrw2HVMHJfuVZxQ7JzYzws9?= =?us-ascii?Q?dsFlnnFKrjFUeozCnXczRtUpVerEI/ds1XpETeHNRjY4p/kXLotlzHejrN4N?= =?us-ascii?Q?fS7LtF2D43znBk/s0XXow9eWNXBkRPBwEebtrZ9UuSMmI7pscuBeRsSJCqv/?= =?us-ascii?Q?zR7zt5epsubonkRk5Y0avBE41ZMgS5GJSXIeqmiObVbtDsdXsDaM98JoVtV1?= =?us-ascii?Q?XUxoL/lifbt4VXifr+mie7Ls3sa2p+u16JKFM21NNC1IHsAw2tLf9Q3FrCJ+?= =?us-ascii?Q?U+LZ//gJ/dvwBaCViDT2jtmslgL7ZIPJ+D4NSVuEuDsix7iCM4KnfdmBTFUn?= =?us-ascii?Q?KOMG6VwqnlYQ3kXwV6KYz948Ln+ZJmtZ96jMivmk5AFJFzRaRRAyVnGU+8nr?= =?us-ascii?Q?Ja4g7Yal8fyPFx1DXN2RmLCwnhDna0KReeqIjTRzmZi1OsmCT5qsozKdqxM8?= =?us-ascii?Q?FNEqz1r2CsxBV8TPZuyOatITGRNazY/FXDH6k358PAcdOuQCCP3p1lDQ8wuY?= =?us-ascii?Q?+7RX6Zh4QP/IGh1y7X+/LjwJq4TDRpQAY476mQsquFxcZYTVAhdarzsE0nlJ?= =?us-ascii?Q?+b6TCu6WchJ6NCLwM3KH5OZostDOP+5bhJaMjNVbUlrQhPtOsF5hiexxH52H?= =?us-ascii?Q?gF2u3ighjWuRIB6WaOkucoaanlY1InfW7vaK1WB+olWTnbF+c7MJyn29TEgF?= =?us-ascii?Q?StQPQiuftjr8WtPsivFbm8nZrgsXFdgTb24O2u25oLIDCjAvYhPcKOJNA4/9?= =?us-ascii?Q?7z2/q22LBFXnLkCEuJz7Oxzs1D4fXhu/oZszDhbjTkDNAErehAHGUU+ZGVCU?= =?us-ascii?Q?uXRD+Y1HVFmffUydO9HgEx//5p3rO2DPd6iNEoTXeZAluVB1891DlGVCblMS?= =?us-ascii?Q?XO0IbzICM9spANVTN5BKueMHrrYKBVvq2+8lF9aVejGQBoMvmuYJae8CJ2l0?= =?us-ascii?Q?6iT9/tajFhpUfmi9etTT8OZrDk0dkN4TXVBHyQ8b+F/2LzhK1FvYB7Gj7e3l?= =?us-ascii?Q?xDmMmBt4aB2mOFlu7N4IM2hkzTBJmEK10TuHlMCbBXSi2xEG5RPXfH1DDIEB?= =?us-ascii?Q?bfTjmBpLoskRE+sG/OMwAsXy9MSDVsKUWlflSdWfujTAIvfVgrIiB8cNo/Qm?= =?us-ascii?Q?0AJXrVayaxw+wL5WmQlSZ/Op5w3dOcKP2s49D0vsluosNKO4K3xqOP/HmMIc?= =?us-ascii?Q?kuqJ/wqlQpqUTUgRmrPIYakcxUZV1Z5xtUQfyVF69pjOPXo12fQ2qZZajK9G?= =?us-ascii?Q?1vSyTcl5QYcp5xNND7wdkSSPO+lsPMkKLgFqS/f2jha4v7O4NMa9Jw3PBNFs?= =?us-ascii?Q?LuWD+Fm3gI0fLZeBAeS+teKEXoHVRFNvufbneP+LcqwLAYDUBsI72gB0hg8b?= =?us-ascii?Q?R9UiEMwcGW0XQ652c2LKhXcnLYmV58tG5XmywZcZKgkOsH9WLupUYGOhnxyu?= =?us-ascii?Q?FQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: fa12fbd4-49c0-4027-4732-08da9f9584ba X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 08:02:55.1621 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8RoFnYkq2azpTKDCV+FTMyFFRStTKT44bYea8oPSbPrq9OZhNBfS1zgJ4JgEljhnABBA05uLSlBW3bDEg0uxvR/5nTP0WWN90n5gNwjdSew= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR10MB5526 X-TUID: n1hofoambxWW > -----Original Message----- > From: isar-users@googlegroups.com On > Behalf Of Kanagarajan, Vijaikumar > Sent: Monday, September 26, 2022 3:57 PM > To: Schild, Henning (T CED SES-DE) ; > Moessbauer, Felix (T CED SES-DE) ; Kiszka, > Jan (T CED) > Cc: isar-users@googlegroups.com > Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision >=20 >=20 >=20 > > -----Original Message----- > > From: Henning Schild > > Sent: 26 September 2022 13:17 > > To: felix.moessbauer@siemens.com; Kanagarajan, Vijaikumar > > ; jan.kiszka@siemens.com > > Cc: isar-users@googlegroups.com > > Subject: Re: [PATCH v2 2/2] wic: Update to the latest revision > > > > Am Mon, 26 Sep 2022 07:57:41 +0200 > > schrieb "Moessbauer, Felix (T CED SES-DE)" > > : > > > > > > -----Original Message----- > > > > From: Kanagarajan, Vijaikumar > > > > Sent: Monday, September 26, 2022 12:53 PM > > > > To: Moessbauer, Felix (T CED SES-DE) > > ; > > > > Schild, Henning (T CED SES-DE) Cc: > > > > Kiszka, Jan (T CED) ; isar- > > > > users@googlegroups.com > > > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Moessbauer, Felix (T CED SES-DE) > > > > > Sent: 26 September 2022 07:11 > > > > > To: Kanagarajan, Vijaikumar ; > > > > > Schild, Henning (T CED SES-DE) > > > > > Cc: Kiszka, Jan (T CED) ; isar- > > > > > users@googlegroups.com > > > > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision > > > > > > > > > > Hi Vijai & Henning, > > > > > > > > > > Are there any news on this? > > > > > I just discovered that still many (if not all) of our images are > > > > > affected by this bug. > > > > > > > > Hi Felix, > > > > > > > > Unfortunately not. If we already have the latest wic, > > > > --no-fstab-update[1] might help.(untested). > > > > > > We already have a wic version with this option, but it doesn't look > > > right to add it to the root partition. Instead this option can be > > > used for partitions that should not show up in the fstab at all. > > > > We do want the one from WIC. It is only coming since we patched WIC to > > support /. > > > > > Indeed, the fstab entry has to be set by WIC to set settings like > > > UUID and filesystem. But this requires that we either remove the > > > entry set by ISAR in image_configure_fstab, or we remove the entry > > > after generating the rootfs, but before WIC. > > > > I think we should try and remove the entry from that template. It > > should not be required. > > > > If we decide to solve the problem somewhere in/with WIC, we should do > > that upstream in OE. They have the same "we now have two" problem, > > where wic adds on top of a template instead of replacing the original. >=20 > This seems to me like the approach we should take. Make wic replace entri= es in > fstab instead of appending to them like how it does now. Sounds like a plan! Would you like to take care of writing the WIC patches, Vijai? Happy Coding! Felix >=20 > Thanks, > Vijai Kumar K >=20 > > > > Henning > > > > > Opinions? @Kiszka, Jan (T CED) > > > > > > Felix > > > > > > > > > > > Thanks, > > > > Vijai Kumar K > > > > > > > > > > > > > > While it is not serios, having error messages in the journal is > > > > > still pretty bad: systemd-fstab-generator[1491]: Failed to > > > > > create unit file /run/systemd/generator/-.mount, as it already ex= ists. > > > > > Duplicate entry in /etc/fstab? > > > > > > > > > > Felix > > > > > > > > > > > -----Original Message----- > > > > > > From: isar-users@googlegroups.com > users@googlegroups.com> > > > > > > On Behalf Of Kanagarajan, Vijaikumar > > > > > > Sent: Friday, June 17, 2022 1:46 PM > > > > > > To: isar-users@googlegroups.com > > > > > > Cc: Kiszka, Jan (T CED) ; Schild, > > > > > > Henning (T CED SES- > > > > > > DE) > > > > > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest revision > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Kanagarajan, Vijaikumar > > > > > > > Sent: 13 June 2022 14:48 > > > > > > > To: 'Henning Schild' > > > > > > > Cc: isar-users@googlegroups.com; jan.kiszka@siemens.com > > > > > > > Subject: RE: [PATCH v2 2/2] wic: Update to the latest > > > > > > > revision > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Henning Schild > > > > > > > > Sent: 13 June 2022 14:32 > > > > > > > > To: Kanagarajan, Vijaikumar > > > > > > > > Cc: > > > > > > > > isar-users@googlegroups.com; jan.kiszka@siemens.com > > > > > > > > Subject: Re: [PATCH v2 2/2] wic: Update to the latest > > > > > > > > revision > > > > > > > > > > > > > > > > Am Mon, 13 Jun 2022 13:24:01 +0530 schrieb Vijai Kumar K > > > > > > > > : > > > > > > > > > > > > > > > > > Update to the latest wic from OE-core. > > > > > > > > > > > > > > > > > > OE-core Revision: > > 06ed2aa93fc25a681e3a00ee120d9395b04845da > > > > > > > > > > > > > > > > > > Signed-off-by: Vijai Kumar K > > > > > > > > > > > > > > --- > > > > > > > > > RECIPE-API-CHANGELOG.md | 19 > > > > > > > > > +++++++++++++++++++ scripts/lib/wic/help.py > > > > > > > > > | 6 ++++++ scripts/lib/wic/ksparser.py | > > > > > > > > > 1 + scripts/lib/wic/partition.py | 1 + > > > > > > > > > scripts/lib/wic/plugins/imager/direct.py | 5 +++-- > > > > > > > > > 5 files changed, 30 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API- > > > > > CHANGELOG.md > > > > > > > > index > > > > > > > > > 2998824..436b204 100644 > > > > > > > > > --- a/RECIPE-API-CHANGELOG.md > > > > > > > > > +++ b/RECIPE-API-CHANGELOG.md > > > > > > > > > @@ -406,3 +406,22 @@ groups are now created after all > > > > > > > > > packages are installed. > > > > > > > > > Changes in next > > > > > > > > > --------------- > > > > > > > > > + > > > > > > > > > +### Wic adds / mountpoint to fstab > > > > > > > > > + > > > > > > > > > +In the older version of wic, any mount point named / is > > > > > > > > > +skipped from > > > > > > > > > adding +into the fstab entry. > > > > > > > > > + > > > > > > > > > +With the latest wic, this is not the case. / mount > > > > > > > > > point, if +any, is > > > > > > > > > added +to /etc/fstab for automount. > > > > > > > > > + > > > > > > > > > +Any wks file which assumed that / would be skipped from > > > > > > > > > +/etc/fstab > > > > > > > > > should +now be corrected. Otherwise, it might result in > > > > > > > > > multiple / entries in /etc/fstab. +One by the > > > > > > > > > image_configure_fstab function from image class and one > > > > > > > > > by wic. + > > > > > > > > > +Below is an example wks entry that might cause an issue. > > > > > > > > > +Replace "part /" with "part" to avoid adding duplicate > > > > > > > > > entry for /. > > > > > > > > > > > > > > > > I am not sure multiple entries would be an issue, i think > > > > > > > > the last one will simply always win. It is good to have a > > > > > > > > note about that change, but i doubt people really have to > > > > > > > > do anything. And if anything has to be done, isar should > > > > > > > > drop the first one centrally. > > > > > > > > > > > > > > > > The fstab entry for root is purely for adding some weird > > > > > > > > mount options, usually root is not mounted with fstab but > > > > > > > > with cmdline and initrd. And not having / in fstab just > > > > > > > > makes that rootfs more generic ... it can become part of > > > > > > > > nfs and next guy takes it as btrfs while next guy > > > > > > > takes it as ext4. > > > > > > > > > > > > > > > > Note is good, advise is not > > > > > > > > > > > > > > Noted. Will change the text accordingly in V3. > > > > > > > > > > > > Ok we cannot drop / mountpoint name(though optional). We would > > > > > > be > > > > > lose > > > > > > the ability to find out UUID of root using rootdev api. > > > > > > This is used by some plugins. So the better way would be to > > > > > > use the --no-fstab- update. Seems like we can set them per > > > > > > partition now. > > > > > > > > > > > > Thanks, > > > > > > Vijai Kumar K > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > Vijai Kumar K > > > > > > > > > > > > > > > > > > > > > > > Henning > > > > > > > > > > > > > > > > > + > > > > > > > > > +``` > > > > > > > > > +part / --source rootfs --ondisk sda --fstype ext4 > > > > > > > > > +--label platform > > > > > > > > > --align 1024 --use-uuid +``` diff --git > > > > > > > > > a/scripts/lib/wic/help.py b/scripts/lib/wic/help.py > > > > > > > > > index > > > > > > > > > 4ff7470..73e3380 100644 > > > > > > > > > --- a/scripts/lib/wic/help.py > > > > > > > > > +++ b/scripts/lib/wic/help.py > > > > > > > > > @@ -940,6 +940,12 @@ DESCRIPTION > > > > > > > > > quotes. If not specified, the > > > > > > > > > default string is "defaults". > > > > > > > > > > > > > > > > > > + --fspassno: Specifies the order in which > > > > > > > > > filesystem > > > > > > > > > + checks > > > > > > > > > are done > > > > > > > > > + at boot time by fsck. See > > > > > > > > > + fs_passno parameter > > > > > > > > > of > > > > > > > > > + fstab(5). This parameter will be > > > > > > > > > copied > > > > > > > > > + into > > > > > > > > > the > > > > > > > > > + /etc/fstab file of the installed > > > > > > > > > system. If not > > > > > > > > > + specified the default value of "0" > > > > > > > > > will be used. + > > > > > > > > > --label label: Specifies the label to give to > > > > > > > > > the filesystem to be made on the partition. If the given > > > > > > > > > label is already in use by > > > > > > > > > another filesystem, diff --git > > > > > > > > > a/scripts/lib/wic/ksparser.py > > > > > > > > > b/scripts/lib/wic/ksparser.py index 0df9eb0..a49b7b9 > > > > > > > > > 100644 --- a/scripts/lib/wic/ksparser.py +++ > > > > > > > > > b/scripts/lib/wic/ksparser.py @@ -155,6 +155,7 @@ class > > > > > > > > > KickStart(): part.add_argument('--change-directory') > > > > > > > > > part.add_argument("--extra-space", > > > > > > > > > type=3Dsizetype("M")) part.add_argument('--fsoptions', > > > > > > > > > dest=3D'fsopts') > > > > > > > > > + part.add_argument('--fspassno', > > > > > > > > > + dest=3D'fspassno') > > > > > > > > > part.add_argument('--fstype', default=3D'vfat', > > > > > > > > > choices=3D('ext2', 'ext3', > > > > > > > > > 'ext4', 'btrfs', 'squashfs', 'vfat', 'msdos', 'erofs', > > > > > > > > > diff --git a/scripts/lib/wic/partition.py > > > > > > > > > b/scripts/lib/wic/partition.py index 09e491d..e50871b > > > > > > > > > 100644 --- a/scripts/lib/wic/partition.py +++ > > > > > > > > > b/scripts/lib/wic/partition.py @@ -33,6 +33,7 @@ class > > > > > > > > > Partition(): self.include_path =3D args.include_path > > > > > > > > > self.change_directory =3D args.change_directory > > > > > > > > > self.fsopts =3D args.fsopts > > > > > > > > > + self.fspassno =3D args.fspassno > > > > > > > > > self.fstype =3D args.fstype > > > > > > > > > self.label =3D args.label > > > > > > > > > self.use_label =3D args.use_label diff --git > > > > > > > > > a/scripts/lib/wic/plugins/imager/direct.py > > > > > > > > > b/scripts/lib/wic/plugins/imager/direct.py index > > > > > > > > > 4d0b836..c44159b > > > > > > > > > 100644 --- a/scripts/lib/wic/plugins/imager/direct.py > > > > > > > > > +++ b/scripts/lib/wic/plugins/imager/direct.py > > > > > > > > > @@ -117,7 +117,7 @@ class DirectPlugin(ImagerPlugin): > > > > > > > > > updated =3D False > > > > > > > > > for part in self.parts: > > > > > > > > > if not part.realnum or not part.mountpoint \ > > > > > > > > > - or part.mountpoint =3D=3D "/" or not > > > > > > > > > part.mountpoint.startswith('/'): > > > > > > > > > + or not part.mountpoint.startswith('/'): > > > > > > > > > continue > > > > > > > > > > > > > > > > > > if part.use_uuid: > > > > > > > > > @@ -138,8 +138,9 @@ class DirectPlugin(ImagerPlugin): > > > > > > > > > device_name =3D "/dev/%s%s%d" % > > > > > > > > > (part.disk, prefix, > > > > > > > > > part.realnum) > > > > > > > > > opts =3D part.fsopts if part.fsopts else > > > > > > > > > "defaults" > > > > > > > > > + passno =3D part.fspassno if part.fspassno > > > > > > > > > + else > > > > > > > > > "0" line =3D "\t".join([device_name, part.mountpoint, > > > > > > > > > part.fstype, > > > > > > > > > - opts, "0", "0"]) + "\n" > > > > > > > > > + opts, "0", passno]) + "\n" > > > > > > > > > > > > > > > > > > fstab_lines.append(line) > > > > > > > > > updated =3D True > > > > > > > > > > > > -- > > > > > > You received this message because you are subscribed to the > > > > > > Google Groups "isar-users" group. > > > > > > To unsubscribe from this group and stop receiving emails from > > > > > > it, send an email to isar-users+unsubscribe@googlegroups.com. > > > > > > To view this discussion on the web visit > > > > > > > > > > > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F= % > > > > > 2F > > > > > grou > > > > > > > > > > > ps.g > > > > > > oogle.com%2Fd%2Fmsgid%2Fisar- > > > > > > > > > > > > > users%2F8babb01d7eae44e0b9faecad59cdc1d4%2540mentor.com&dat > > > > > a=3D > > > > > > > > > > > > > 05%7C01%7Cfelix.moessbauer%40siemens.com%7C237b0db9bb724580ca540 > > > > > 8 > > > > > > > > > > > > > > > > > > da5024a3ad%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C6379104 > > > > > > > > > > > > > 15537105828%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ > > > > > Ijo > > > > > > > > > > > > > iV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sda > > > > > ta > > > > > > > > > > > > > =3D%2F%2F1Fxy%2B%2BEgDI4RfUEZ38qy1Q82esArdBuRftDuE1t6s%3D&re > > > > > se > > > > > > rved=3D0. >=20 > -- > You received this message because you are subscribed to the Google Groups > "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an= email > to isar-users+unsubscribe@googlegroups.com. > To view this discussion on the web visit > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgroup= s.g > oogle.com%2Fd%2Fmsgid%2Fisar- > users%2F7d23828243444e90afd49e7bb23717dc%2540mentor.com&data=3D > 05%7C01%7Cfelix.moessbauer%40siemens.com%7C7e073a4d25ec493e0d3408 > da9f94ad76%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C6379977 > 58159199068%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjo > iV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata > =3DpT2NMVWp6ld7iDW%2BRStJABC02WCrzGDOV%2BXhvpxPKO4%3D&reser > ved=3D0.